[PR #133] [MERGED] fix: deduplicate PRs in coreping to prevent duplicate notifications #132

New issue

Closed

opened 2026-10-27 21:09:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:09:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/133
Author: @snomiao
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/8/2026
Merged by: @snomiao

Base: main ← Head: sno-fix-coreping-twice

📝 Commits (1)

0052677 fix: deduplicate PRs in coreping to prevent duplicate notifications

📊 Changes

1 file changed (+58 additions, -12 deletions)

View changed files

📝 app/tasks/coreping/coreping.ts (+58 -12)

📄 Description

Summary

Fixed duplicate PR notifications in coreping task by adding deduplication logic
Updated REPOLIST to use Comfy-Org/ComfyUI as primary source instead of comfyanonymous/ComfyUI
Reduced notification count from 25 duplicated entries to 13 unique PRs

Details

The coreping task was fetching PRs from both comfyanonymous/ComfyUI and Comfy-Org/ComfyUI repos, which share the same PRs due to organization transfer. This resulted in duplicate entries in Slack notifications (each PR appeared twice).

Changes Made

Added deduplicatePRTasks() helper function that:
- Groups PRs by their PR number (extracted from URL)
- Prefers Comfy-Org/ComfyUI URLs over comfyanonymous/ComfyUI URLs
- Returns only unique PRs
Applied deduplication to:
- Initial PR fetch from GitHub API
- Database queries for pendingReviewCorePRs
- Database queries for allOpeningCorePRs
Updated REPOLIST configuration:
- Commented out deprecated comfyanonymous/ComfyUI repo
- Using Comfy-Org/ComfyUI as the primary source

Test Results

Before:

Slack message showed x21 Core/Important PRs
Total of 25 PR entries (with duplicates)

After:

Slack message shows x11 Core/Important PRs + 2 in "Additionally" section
Total of 13 unique PR entries
No duplicate notifications

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/133 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/8/2026 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `sno-fix-coreping-twice` --- ### 📝 Commits (1) - [`0052677`](https://github.com/Comfy-Org/Comfy-PR/commit/00526775596d05d71abb8fb869621b46d22c8bf9) fix: deduplicate PRs in coreping to prevent duplicate notifications ### 📊 Changes **1 file changed** (+58 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `app/tasks/coreping/coreping.ts` (+58 -12) </details> ### 📄 Description ## Summary - Fixed duplicate PR notifications in coreping task by adding deduplication logic - Updated REPOLIST to use Comfy-Org/ComfyUI as primary source instead of comfyanonymous/ComfyUI - Reduced notification count from 25 duplicated entries to 13 unique PRs ## Details The coreping task was fetching PRs from both `comfyanonymous/ComfyUI` and `Comfy-Org/ComfyUI` repos, which share the same PRs due to organization transfer. This resulted in duplicate entries in Slack notifications (each PR appeared twice). ### Changes Made 1. **Added `deduplicatePRTasks()` helper function** that: - Groups PRs by their PR number (extracted from URL) - Prefers `Comfy-Org/ComfyUI` URLs over `comfyanonymous/ComfyUI` URLs - Returns only unique PRs 2. **Applied deduplication** to: - Initial PR fetch from GitHub API - Database queries for `pendingReviewCorePRs` - Database queries for `allOpeningCorePRs` 3. **Updated REPOLIST configuration**: - Commented out deprecated `comfyanonymous/ComfyUI` repo - Using `Comfy-Org/ComfyUI` as the primary source ## Test Results Before: - Slack message showed x21 Core/Important PRs - Total of 25 PR entries (with duplicates) After: - Slack message shows x11 Core/Important PRs + 2 in "Additionally" section - Total of 13 unique PR entries - No duplicate notifications 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:09:53 +00:00

bsakaguchi referenced this issue

2026-10-27 21:09:53 +00:00

[PR #132] fix: add pagination to /api/repo-urls endpoint to prevent timeouts #133

bsakaguchi closed this issue

2026-10-27 21:09:53 +00:00