[PR #183] [MERGED] refactor(backport): rename labels to no-backport-needed[-cloud|-core] #182

Closed
opened 2026-10-27 21:10:21 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/183
Author: @snomiao
Created: 3/17/2026
Status: ✅ Merged
Merged: 3/17/2026
Merged by: @snomiao

Base: main ← Head: sno-backport-label-rename


📝 Commits (1)

  • 1047d63 refactor(backport): rename labels to no-backport-needed[-cloud|-core]

📊 Changes

2 files changed (+32 additions, -18 deletions)

View changed files

📝 app/tasks/gh-frontend-backport-checker/index.spec.ts (+17 -9)
📝 app/tasks/gh-frontend-backport-checker/index.ts (+15 -9)

📄 Description

Summary

Rename backport dismissal labels for better readability and consistency:

  • core-backport-not-needed → no-backport-needed-core
  • cloud-backport-not-needed → no-backport-needed-cloud
  • Add general no-backport-needed label that dismisses all targets at once

New label convention on ComfyUI_frontend repo

  • no-backport-needed — dismiss all backport targets
  • no-backport-needed-core — dismiss core backport only
  • no-backport-needed-cloud — dismiss cloud backport only

Test plan

  • All 76 unit tests pass (including updated label tests)
  • Verify new labels are created on ComfyUI_frontend repo
  • Remove old core-backport-not-needed / cloud-backport-not-needed labels

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/183 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 3/17/2026 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `sno-backport-label-rename` --- ### 📝 Commits (1) - [`1047d63`](https://github.com/Comfy-Org/Comfy-PR/commit/1047d6351b0b7a8ecd783839d4b04408abfc77c3) refactor(backport): rename labels to no-backport-needed[-cloud|-core] ### 📊 Changes **2 files changed** (+32 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `app/tasks/gh-frontend-backport-checker/index.spec.ts` (+17 -9) 📝 `app/tasks/gh-frontend-backport-checker/index.ts` (+15 -9) </details> ### 📄 Description ## Summary Rename backport dismissal labels for better readability and consistency: - `core-backport-not-needed` → `no-backport-needed-core` - `cloud-backport-not-needed` → `no-backport-needed-cloud` - Add general `no-backport-needed` label that dismisses **all** targets at once ### New label convention on ComfyUI_frontend repo - `no-backport-needed` — dismiss all backport targets - `no-backport-needed-core` — dismiss core backport only - `no-backport-needed-cloud` — dismiss cloud backport only ## Test plan - [x] All 76 unit tests pass (including updated label tests) - [ ] Verify new labels are created on ComfyUI_frontend repo - [ ] Remove old `core-backport-not-needed` / `cloud-backport-not-needed` labels 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-27 21:10:21 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/Comfy-PR#182
No description provided.