[PR #184] [MERGED] feat: merge sno-bot improvements to main #188

New issue

Closed

opened 2026-10-27 21:10:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:10:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/184
Author: @comfy-pr-bot
Created: 3/19/2026
Status: ✅ Merged
Merged: 3/19/2026
Merged by: @comfy-pr-bot

Base: main ← Head: merge/sno-bot-to-main

📝 Commits (4)

8e91701 fix: resolve TS2589 deep type instantiation in zChatCompletion calls
251c4ed chore: add .logs to gitignore and remove stale TODO
a69bc54 fix: improve slack bot message processing and terminal output cleaning
290e247 feat: add video read skill with Gemini 2.5 Flash and GPT-4o support

📊 Changes

14 files changed (+656 additions, -44 deletions)

View changed files

➕ .bot/skills/video-read/SKILL.md (+69 -0)
➕ .claude/skills/video-read/SKILL.md (+69 -0)
📝 .gitignore (+1 -0)
📝 bot/cli.ts (+98 -2)
📝 bot/code/prbot.ts (+1 -2)
📝 bot/slack-bot.ts (+163 -34)
📝 bun.lock (+4 -2)
📝 lib/slack/msg-read-nearby.ts (+3 -0)
📝 lib/slack/msg-read-recent.ts (+2 -0)
📝 lib/slack/msg-read-thread.ts (+3 -0)
➕ lib/video/read-video.ts (+227 -0)
➕ lib/zChat.ts (+14 -0)
📝 package.json (+1 -0)
📝 src/createGithubPullRequest.ts (+1 -4)

📄 Description

Summary

fix: resolve TS2589 deep type instantiation — Create lib/zChat.ts wrapper to avoid excessively deep type errors from OpenAI's ChatCompletionCreateParamsNonStreaming type
chore: housekeeping — Add .logs to gitignore, remove stale TODO in createGithubPullRequest.ts
fix: slack bot improvements — cleanTerminalOutput() filters ANSI/debug noise, JSONL logging for response debugging, parse attachment text & resolve channel names from from_url
feat: video read skill — New prbot video read CLI command with Gemini 2.5 Flash and GPT-4o support for video analysis (local files + Slack-hosted videos)

Test plan

Verify bun typecheck passes (tsgo)
Test video read: prbot video read --file <video> --model gemini
Test slack bot processes messages without debug noise in updates
Verify .logs/ directory is gitignored

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/184 **Author:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Created:** 3/19/2026 **Status:** ✅ Merged **Merged:** 3/19/2026 **Merged by:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Base:** `main` ← **Head:** `merge/sno-bot-to-main` --- ### 📝 Commits (4) - [`8e91701`](https://github.com/Comfy-Org/Comfy-PR/commit/8e917015dc9352eece4df1b89b9984616724e599) fix: resolve TS2589 deep type instantiation in zChatCompletion calls - [`251c4ed`](https://github.com/Comfy-Org/Comfy-PR/commit/251c4ed0089866d9678b76a11182756a379bf41c) chore: add .logs to gitignore and remove stale TODO - [`a69bc54`](https://github.com/Comfy-Org/Comfy-PR/commit/a69bc540d1f69060d67fbb8ce65c17b4e7f95393) fix: improve slack bot message processing and terminal output cleaning - [`290e247`](https://github.com/Comfy-Org/Comfy-PR/commit/290e2474989c98a0b17b945f28c6029640fe0900) feat: add video read skill with Gemini 2.5 Flash and GPT-4o support ### 📊 Changes **14 files changed** (+656 additions, -44 deletions) <details> <summary>View changed files</summary> ➕ `.bot/skills/video-read/SKILL.md` (+69 -0) ➕ `.claude/skills/video-read/SKILL.md` (+69 -0) 📝 `.gitignore` (+1 -0) 📝 `bot/cli.ts` (+98 -2) 📝 `bot/code/prbot.ts` (+1 -2) 📝 `bot/slack-bot.ts` (+163 -34) 📝 `bun.lock` (+4 -2) 📝 `lib/slack/msg-read-nearby.ts` (+3 -0) 📝 `lib/slack/msg-read-recent.ts` (+2 -0) 📝 `lib/slack/msg-read-thread.ts` (+3 -0) ➕ `lib/video/read-video.ts` (+227 -0) ➕ `lib/zChat.ts` (+14 -0) 📝 `package.json` (+1 -0) 📝 `src/createGithubPullRequest.ts` (+1 -4) </details> ### 📄 Description ## Summary - **fix: resolve TS2589 deep type instantiation** — Create `lib/zChat.ts` wrapper to avoid excessively deep type errors from OpenAI's `ChatCompletionCreateParamsNonStreaming` type - **chore: housekeeping** — Add `.logs` to gitignore, remove stale TODO in `createGithubPullRequest.ts` - **fix: slack bot improvements** — `cleanTerminalOutput()` filters ANSI/debug noise, JSONL logging for response debugging, parse attachment text & resolve channel names from `from_url` - **feat: video read skill** — New `prbot video read` CLI command with Gemini 2.5 Flash and GPT-4o support for video analysis (local files + Slack-hosted videos) ## Test plan - [ ] Verify `bun typecheck` passes (tsgo) - [ ] Test video read: `prbot video read --file <video> --model gemini` - [ ] Test slack bot processes messages without debug noise in updates - [ ] Verify `.logs/` directory is gitignored 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:10:24 +00:00