[PR #209] [MERGED] fix: recover combined GitHub task workflow #207

New issue

Closed

opened 2026-10-27 21:10:36 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:10:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/209
Author: @benceruleanlu
Created: 7/24/2026
Status: ✅ Merged
Merged: 7/24/2026
Merged by: @benceruleanlu

Base: main ← Head: bl/fix-combined-task-failures

📝 Commits (3)

4f2ee84 fix: recover combined GitHub tasks
cb442d0 fix: skip releases without compare links
3cceaae fix: pause retired priority sync task

📊 Changes

6 files changed (+96 additions, -15 deletions)

View changed files

➕ app/tasks/combinedTaskSchedule.spec.ts (+17 -0)
➕ app/tasks/combinedTaskSchedule.ts (+10 -0)
📝 app/tasks/gh-frontend-backport-checker/index.ts (+21 -13)
➕ app/tasks/gh-frontend-backport-checker/releaseComparison.spec.ts (+33 -0)
➕ app/tasks/gh-frontend-backport-checker/releaseComparison.ts (+12 -0)
📝 app/tasks/run-gh-tasks.ts (+3 -2)

📄 Description

Summary

Pause only GitHub Issue Priorities Labeler Task in the combined task schedule because organization task tracking migrated from Notion to Linear.
Keep the enclosing Combined GitHub Tasks workflow and its frontend release/backport notification tasks active.
Silently skip any candidate release whose body lacks the repository's required GitHub compare/full-changelog link.
Preserve the original release candidate set: prerelease status is not an eligibility filter, and a prerelease with a valid compare link continues through existing processing.
Preserve Slack destinations and message formatting.

Root cause and resolution

The July 24 combined-task run failed in two tasks:

The Notion-backed priority sync resumed with stale pagination state. That integration is now retired operationally because task tracking moved to Linear, so this PR does not modify or repair its Notion implementation. Instead, the combined runner filters its named task out before task modules are loaded or executed.
The frontend backport checker threw when a candidate release body had no GitHub compare URL. A missing comparison link now yields no task and is skipped before persistence, comparison, or Slack handling.

Exact behavior

getScheduledCombinedGithubTasks() removes only the task named GitHub Issue Priorities Labeler Task from TASK_DEFS.
The pause list carries an inline comment documenting the Notion-to-Linear migration. Removing that single name reverses the pause.
Frontend release notification and frontend backport checker tasks remain scheduled by the combined runner.
The gh-priority-sync implementation is unchanged from main; none of the earlier cursor-recovery work remains in this PR.
Candidate releases still use the existing date and version-distance selection. Prereleases are not broadly excluded.
A candidate without a matching https://github.com/Comfy-Org/ComfyUI_frontend/compare/... link is silently skipped.
A prerelease with a valid comparison link follows the same backport/changelog path as any other valid candidate.
No workflow schedules, secrets, Slack channels, or Slack message formatting changed.

Validation

Focused Bun specs — 3 passed, 0 failed:
- combined schedule excludes only the retired priority-sync task while retaining both frontend notification tasks;
- missing-link candidate is skipped;
- prerelease with a valid compare link remains eligible.
Scoped oxfmt --check on the changed registry/backport files — passed.
git diff --check — passed.
Verified the PR's net diff against origin/main contains no gh-priority-sync changes.

The full scheduled task was not run locally because it requires production integrations and can send external updates. The PR-triggered combined workflow runs in its existing dry-run mode.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/209 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 7/24/2026 **Status:** ✅ Merged **Merged:** 7/24/2026 **Merged by:** [@benceruleanlu](https://github.com/benceruleanlu) **Base:** `main` ← **Head:** `bl/fix-combined-task-failures` --- ### 📝 Commits (3) - [`4f2ee84`](https://github.com/Comfy-Org/Comfy-PR/commit/4f2ee84353c1195b58499f321f4ee1c1a7a72e63) fix: recover combined GitHub tasks - [`cb442d0`](https://github.com/Comfy-Org/Comfy-PR/commit/cb442d057d72099729143213a3be5ba82f7be9c7) fix: skip releases without compare links - [`3cceaae`](https://github.com/Comfy-Org/Comfy-PR/commit/3cceaaeb85908292fbd6424af22bc6f1d2b414cf) fix: pause retired priority sync task ### 📊 Changes **6 files changed** (+96 additions, -15 deletions) <details> <summary>View changed files</summary> ➕ `app/tasks/combinedTaskSchedule.spec.ts` (+17 -0) ➕ `app/tasks/combinedTaskSchedule.ts` (+10 -0) 📝 `app/tasks/gh-frontend-backport-checker/index.ts` (+21 -13) ➕ `app/tasks/gh-frontend-backport-checker/releaseComparison.spec.ts` (+33 -0) ➕ `app/tasks/gh-frontend-backport-checker/releaseComparison.ts` (+12 -0) 📝 `app/tasks/run-gh-tasks.ts` (+3 -2) </details> ### 📄 Description ## Summary - Pause only `GitHub Issue Priorities Labeler Task` in the combined task schedule because organization task tracking migrated from Notion to Linear. - Keep the enclosing Combined GitHub Tasks workflow and its frontend release/backport notification tasks active. - Silently skip any candidate release whose body lacks the repository's required GitHub compare/full-changelog link. - Preserve the original release candidate set: prerelease status is not an eligibility filter, and a prerelease with a valid compare link continues through existing processing. - Preserve Slack destinations and message formatting. ## Root cause and resolution The July 24 combined-task run failed in two tasks: 1. The Notion-backed priority sync resumed with stale pagination state. That integration is now retired operationally because task tracking moved to Linear, so this PR does not modify or repair its Notion implementation. Instead, the combined runner filters its named task out before task modules are loaded or executed. 2. The frontend backport checker threw when a candidate release body had no GitHub compare URL. A missing comparison link now yields no task and is skipped before persistence, comparison, or Slack handling. ## Exact behavior - `getScheduledCombinedGithubTasks()` removes only the task named `GitHub Issue Priorities Labeler Task` from `TASK_DEFS`. - The pause list carries an inline comment documenting the Notion-to-Linear migration. Removing that single name reverses the pause. - Frontend release notification and frontend backport checker tasks remain scheduled by the combined runner. - The `gh-priority-sync` implementation is unchanged from `main`; none of the earlier cursor-recovery work remains in this PR. - Candidate releases still use the existing date and version-distance selection. Prereleases are not broadly excluded. - A candidate without a matching `https://github.com/Comfy-Org/ComfyUI_frontend/compare/...` link is silently skipped. - A prerelease with a valid comparison link follows the same backport/changelog path as any other valid candidate. - No workflow schedules, secrets, Slack channels, or Slack message formatting changed. ## Validation - Focused Bun specs — 3 passed, 0 failed: - combined schedule excludes only the retired priority-sync task while retaining both frontend notification tasks; - missing-link candidate is skipped; - prerelease with a valid compare link remains eligible. - Scoped `oxfmt --check` on the changed registry/backport files — passed. - `git diff --check` — passed. - Verified the PR's net diff against `origin/main` contains no `gh-priority-sync` changes. The full scheduled task was not run locally because it requires production integrations and can send external updates. The PR-triggered combined workflow runs in its existing dry-run mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:10:36 +00:00