mirror of
https://github.com/Comfy-Org/Comfy-PR.git
synced 2026-11-04 23:37:33 +00:00
[PR #214] ci: add concurrency guard to gh-combined-tasks cron to stop overlapping runs #212
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/Comfy-PR#212
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/214
Author: @claude[bot]
Created: 9/14/2026
Status: 🔄 Open
Base:
main← Head:fix/gh-combined-tasks-concurrency-guard📝 Commits (1)
fb27e42ci: add concurrency guard to gh-combined-tasks cron to stop overlapping runs📊 Changes
1 file changed (+4 additions, -0 deletions)
View changed files
📝
.github/workflows/gh-combined-tasks.yaml(+4 -0)📄 Description
Requested via Slack thread
Before:
gh-combined-tasks.yaml(the cron running 14 GitHub-polling tasks, including the #frontend release notifier) has noconcurrencyguard. When a run gets stuck on GitHub API rate limits and hits the 10-minute step timeout, the next 5-minute cron tick fires anyway and piles more requests onto the same token — compounding the rate-limit exhaustion instead of letting it recover. This has caused 40+ consecutive failed runs.After: a
concurrencygroup withcancel-in-progress: truemeans a new run cancels any still-running previous one instead of stacking on top of it, so the token gets a chance to recover between attempts.This does not fix the underlying rate-limit exhaustion itself (that needs someone with token access to check
gh api rate_limitand possibly reduce polling frequency or split up the 14 bundled tasks) — it just stops the pile-up that's making it worse.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.