[PR #217] [MERGED] chore(tasks): retire frontend release Slack notification task #216

New issue

Closed

opened 2026-10-27 21:10:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:10:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/217
Author: @claude[bot]
Created: 10/3/2026
Status: ✅ Merged
Merged: 10/3/2026
Merged by: @christian-byrne

Base: main ← Head: chore/retire-frontend-release-notification

📝 Commits (1)

23e2ff0 chore(tasks): retire frontend release Slack notification task

📊 Changes

6 files changed (+2 additions, -694 deletions)

View changed files

📝 app/tasks/combinedTaskSchedule.spec.ts (+2 -2)
➖ app/tasks/gh-frontend-release-notification/index.spec.ts (+0 -319)
➖ app/tasks/gh-frontend-release-notification/index.ts (+0 -194)
➖ app/tasks/gh-frontend-release-notification/upsertChunkedSlackMessage.spec.ts (+0 -99)
➖ app/tasks/gh-frontend-release-notification/upsertChunkedSlackMessage.ts (+0 -76)
📝 app/tasks/run-gh-tasks.ts (+0 -4)

📄 Description

Requested by Christian Byrne · Slack thread

Before

The GitHub Frontend Release Notification Task in Comfy-PR still posts ComfyUI_frontend release announcements to #frontend. Once the frontend repo's own workflow (https://github.com/Comfy-Org/ComfyUI_frontend/pull/19928) starts announcing releases, every release would be announced twice.

After

The old task is removed, so the frontend repo's workflow is the single owner of release announcements.

How

Deleted app/tasks/gh-frontend-release-notification/ (task, chunked Slack upsert helper, and their specs).
Dropped the task entry from app/tasks/run-gh-tasks.ts.
app/tasks/combinedTaskSchedule.spec.ts used the retired task's name only as a fixture string; swapped it for the Desktop release task name so the test no longer references a task that does not exist.
Left alone on purpose: the GithubFrontendReleaseNotificationTask Mongo collection and its entry in scripts/migrate-urls-to-comfy-org.ts, and the separate frontend backport checker task.

Checks: tsgo exit 0, oxfmt --check app/tasks clean, oxlint 0 errors (69 pre-existing warnings), bun test app/tasks 155 pass, 0 fail.

Required merge order

Merge https://github.com/Comfy-Org/ComfyUI_frontend/pull/19928
Merge this PR
Set the SLACK_FRONTEND_CHANNEL_ID repo variable (C075ANWQ8KS) in ComfyUI_frontend (needs a repo admin; Glary-Bot's token gets a 403 on the variables API)

Created by Claude Tag

🤖 Generated with Claude Code

https://claude.ai/code/session_0148ctrbhTbC371YqTiUXsK7

Generated by Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/217 **Author:** [@claude[bot]](https://github.com/apps/claude) **Created:** 10/3/2026 **Status:** ✅ Merged **Merged:** 10/3/2026 **Merged by:** [@christian-byrne](https://github.com/christian-byrne) **Base:** `main` ← **Head:** `chore/retire-frontend-release-notification` --- ### 📝 Commits (1) - [`23e2ff0`](https://github.com/Comfy-Org/Comfy-PR/commit/23e2ff0df380015ee576c847b0ab1b37ee0bd3cb) chore(tasks): retire frontend release Slack notification task ### 📊 Changes **6 files changed** (+2 additions, -694 deletions) <details> <summary>View changed files</summary> 📝 `app/tasks/combinedTaskSchedule.spec.ts` (+2 -2) ➖ `app/tasks/gh-frontend-release-notification/index.spec.ts` (+0 -319) ➖ `app/tasks/gh-frontend-release-notification/index.ts` (+0 -194) ➖ `app/tasks/gh-frontend-release-notification/upsertChunkedSlackMessage.spec.ts` (+0 -99) ➖ `app/tasks/gh-frontend-release-notification/upsertChunkedSlackMessage.ts` (+0 -76) 📝 `app/tasks/run-gh-tasks.ts` (+0 -4) </details> ### 📄 Description  _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C075ANWQ8KS/p1790944221486459?thread_ts=1790944221.486459&cid=C075ANWQ8KS)_ ## Before The `GitHub Frontend Release Notification Task` in Comfy-PR still posts ComfyUI_frontend release announcements to #frontend. Once the frontend repo's own workflow (https://github.com/Comfy-Org/ComfyUI_frontend/pull/19928) starts announcing releases, every release would be announced twice. ## After The old task is removed, so the frontend repo's workflow is the single owner of release announcements. ## How - Deleted `app/tasks/gh-frontend-release-notification/` (task, chunked Slack upsert helper, and their specs). - Dropped the task entry from `app/tasks/run-gh-tasks.ts`. - `app/tasks/combinedTaskSchedule.spec.ts` used the retired task's name only as a fixture string; swapped it for the Desktop release task name so the test no longer references a task that does not exist. - Left alone on purpose: the `GithubFrontendReleaseNotificationTask` Mongo collection and its entry in `scripts/migrate-urls-to-comfy-org.ts`, and the separate frontend backport checker task. Checks: `tsgo` exit 0, `oxfmt --check app/tasks` clean, `oxlint` 0 errors (69 pre-existing warnings), `bun test app/tasks` 155 pass, 0 fail. ## Required merge order 1. Merge https://github.com/Comfy-Org/ComfyUI_frontend/pull/19928 2. Merge this PR 3. Set the `SLACK_FRONTEND_CHANNEL_ID` repo variable (`C075ANWQ8KS`) in ComfyUI_frontend (needs a repo admin; Glary-Bot's token gets a 403 on the variables API) Created by Claude Tag 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0148ctrbhTbC371YqTiUXsK7 --- _Generated by [Claude Code](https://claude.ai/code/session_0148ctrbhTbC371YqTiUXsK7)_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:10:43 +00:00