Comfy-Org/Comfy-PR
1
0
Fork 0
mirror of https://github.com/Comfy-Org/Comfy-PR.git synced 2026-11-04 23:37:33 +00:00
Code Issues 18 Projects Packages Wiki Activity

[PR #29] [MERGED] [test] Add pyproject.toml generation validation #35

New issue
Closed
opened 2026-10-27 21:08:59 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-27 21:08:59 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/29
Author: @christian-byrne
Created: 7/11/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @snomiao

Base: main ← Head: test/pyproject-generation-validation

📝 Commits (10+)

  • 063a373 [test] add pyproject.toml generation validation and CI workflow
  • aafc51e [fix] add MongoDB service to CI workflow for existing tests
  • 220127c [refactor] remove complex test setup, keep useful preview scripts
  • f383fbf Merge branch 'main' into test/pyproject-generation-validation
  • bfe0916 Merge branch 'main' into test/pyproject-generation-validation
  • ade272d Merge branch 'main' into test/pyproject-generation-validation
  • 9f9d6ae Update scripts/preview-pyproject-toml.ts
  • ff3ce44 Update scripts/preview-pyproject-minimal.ts
  • f2f1412 Merge branch 'main' into test/pyproject-generation-validation
  • e7aa14d Merge branch 'main' into test/pyproject-generation-validation

📊 Changes

6 files changed (+484 additions, -8 deletions)

View changed files

📝 bun.lock (+288 -7)
📝 package.json (+4 -0)
➕ scripts/preview-pyproject-minimal.ts (+48 -0)
➕ scripts/preview-pyproject-toml.ts (+104 -0)
➕ scripts/tsconfig.json (+38 -0)
📝 tsconfig.json (+2 -1)

📄 Description

Adds test coverage and preview tools for pyproject.toml generation, ensuring the core PR creation functionality produces valid output. Also introduces CI workflow for automated testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/29 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `test/pyproject-generation-validation` --- ### 📝 Commits (10+) - [`063a373`](https://github.com/Comfy-Org/Comfy-PR/commit/063a37316ad0b72c5c3e13175a0cdd73de4bc0ff) [test] add pyproject.toml generation validation and CI workflow - [`aafc51e`](https://github.com/Comfy-Org/Comfy-PR/commit/aafc51e9ffb74fe891f6d7ade522307a542cf4c1) [fix] add MongoDB service to CI workflow for existing tests - [`220127c`](https://github.com/Comfy-Org/Comfy-PR/commit/220127cd14a201c8b3d072efc4f59a3913c10dda) [refactor] remove complex test setup, keep useful preview scripts - [`f383fbf`](https://github.com/Comfy-Org/Comfy-PR/commit/f383fbfbde0eba7df82f508527de5b3936e6ba0c) Merge branch 'main' into test/pyproject-generation-validation - [`bfe0916`](https://github.com/Comfy-Org/Comfy-PR/commit/bfe0916762f3f1caabcaccf68f425d5100544058) Merge branch 'main' into test/pyproject-generation-validation - [`ade272d`](https://github.com/Comfy-Org/Comfy-PR/commit/ade272d77459cc2bb29217bc34baee73fe16e127) Merge branch 'main' into test/pyproject-generation-validation - [`9f9d6ae`](https://github.com/Comfy-Org/Comfy-PR/commit/9f9d6ae0e8c2d6aad2db124b4189a23a396c2d75) Update scripts/preview-pyproject-toml.ts - [`ff3ce44`](https://github.com/Comfy-Org/Comfy-PR/commit/ff3ce442091dc26c07efbcca10d3f2738338c357) Update scripts/preview-pyproject-minimal.ts - [`f2f1412`](https://github.com/Comfy-Org/Comfy-PR/commit/f2f141230aea725c873f0354b64c5bd4af3441d4) Merge branch 'main' into test/pyproject-generation-validation - [`e7aa14d`](https://github.com/Comfy-Org/Comfy-PR/commit/e7aa14d5e64d8cd639e1d51e0dab8cecffc3d5ea) Merge branch 'main' into test/pyproject-generation-validation ### 📊 Changes **6 files changed** (+484 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `bun.lock` (+288 -7) 📝 `package.json` (+4 -0) ➕ `scripts/preview-pyproject-minimal.ts` (+48 -0) ➕ `scripts/preview-pyproject-toml.ts` (+104 -0) ➕ `scripts/tsconfig.json` (+38 -0) 📝 `tsconfig.json` (+2 -1) </details> ### 📄 Description Adds test coverage and preview tools for pyproject.toml generation, ensuring the core PR creation functionality produces valid output. Also introduces CI workflow for automated testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-27 21:08:59 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/release-tagger-branch-cut
matt/be-3554-claude-md-shim
cb__backport-checker-released-status
fix/gh-combined-tasks-concurrency-guard
sno-coreping-groupby-author
sno-bot
sno/fix-notion-cursor-priority-sync
fix/gh-design-self-review
fix/backport-checker-skip-non-main-releases
refactor/merge-bot-cli-into-index
fix/flaky-workflow-templates-test
sno-release
sno-qabot
sno-fix-test-2025-11-05
sno-fix-msg-post-2026-02-18
copilot/sub-pr-179-another-one
copilot/sub-pr-179-again
copilot/sub-pr-179
sno-perf-2026-03-01
sno-test-evidence
sno-fix-repolist-endpoint
sno-priorities-backsync
fix/housekeeping
sno-cloudrun
pr/oxlint-type-safety
feature/backport-label-emoji
sno-design-msgs
sno-bot--bolt
sno-fix-test-2025-10-29
sno-better-auth
sno-dedup-desktop-release-notification
feat/comfypr-bot-skills
fix/coreping-hours-from-last-activity
copilot/sub-pr-105-yet-again
copilot/sub-pr-105-another-one
sno-solve-comfy-pr-job
sno-method-cache-proxy
sno-fix-pr-hourly-ci
sno-fix-cicd-2025-10-21
fix/template-file-path-bug
sno-update-vscode-settings
sno-debug-repo-urls-endpoint
sno-pr-speed
fix-duplicate-draft-announcements
stable-tag-announce
sno-slack-dry
sno-adjust-easy-label-timeout
sno-slack-cache
sno-slack-dm
sno-pr-button
test/pyproject-generation-validation
feat/winston-logger
easylabel-debug
sno-logger
feat/frontend-release-notes-in-slack
sno-frontend-release-notification
sno-coreping
sno-setupbunv2
replace-keyv-with-bun-sqlite
sno-update-readme
push-merged-changes
sno-rename-parseUrlRepoOwner
61-test-evidence
sno-easylabel-allowlist
sno-bugcop-label
sno-fix-bugcop
sno-label-op-system
sno-notification-reply-boardcast
sno-slack-release-msg
sno-bugcop-dont-set-answered
snomiao-patch-token-bot
sno-bugcop-update-existed-task
sno-bugcop-responsed
sno-setup-lint-stage
sno-desktop-release-notification
sno-bugcop-logic-update
sno-disable-meta-editing
sno-bug-cop
sno-patch-zodv3
revert-33-copilot/fix-32
copilot/fix-32
gh-readonly-queue/main/pr-31-8a0f19f72fa4a0ee197d7ce2131d5dcd4b6bd7d0
sno-zodv3
sno-design-label-track
fix-contribute-analyze-ci
sno-db-refactor
sno-bounty
sno-pkg-update
sno-filter-unclaimed
sno-clone-single-branch
prevent-duplicate-pr
mass-pr
action-permission-write
fix-deployment-2025-01-12
fix-repository-owner
rh-update
test-robin-pr
update-readme
sno-checking-prs-failures
update-toml-pr
sno-license-updator
gmail
update-dashboard-summary
update-pr-status
storybook
toml-v4
stale-counter
toml-template-v3
sno-sep-apidoc
actions-pr-v2
publish-yaml-outdated
edit-toml-PR-message
edit-pyproject-PR-message
feat-activate-in-bun
pyproject--snomiao--ComfyNode-Registry-test
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.2
v1.4.1
v1.4.0
v1.3.0
v1.2.2
v1.2.1
v1.2.0
v1.1.0
v1.0.1
v1.0.0
v0.2.27
v0.0.2
v0.0.1
Labels
Clear labels   
bug-cop:response-received

   
Core

   
Core-Important

   
pull-request
Mirrored from GitHub Pull Request

  
stale

   
Test

   
world
No labels
bug-cop:response-received
Core
Core-Important
pull-request
stale
Test
world
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/Comfy-PR#35
No description provided.