[PR #33] [MERGED] Replace @snomiao/die with phpdie package across codebase #37

New issue

Closed

opened 2026-10-27 21:09:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:09:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/33
Author: @Copilot
Created: 7/17/2025
Status: ✅ Merged
Merged: 7/18/2025
Merged by: @snomiao

Base: main ← Head: copilot/fix-32

📝 Commits (3)

71a8dad Initial plan
51616c5 Replace @snomiao/die with phpdie package across entire codebase
190e198 Merge branch 'main' into copilot/fix-32

📊 Changes

32 files changed (+32 additions, -32 deletions)

View changed files

📝 app/(dashboard)/followup/actions/send-gmail/page.tsx (+1 -1)
📝 package.json (+1 -1)
📝 packages/mongodb-pipeline-ts/$fresh.test.ts (+1 -1)
📝 scripts/REPO_CLEAN.ts (+1 -1)
📝 src/EmailTasks.ts (+1 -1)
📝 src/FORK_OWNER.ts (+1 -1)
📝 src/FORK_PREFIX.ts (+1 -1)
📝 src/addCommentAction.ts (+1 -1)
📝 src/checkComfyActivated.ts (+1 -1)
📝 src/cli.ts (+1 -1)
📝 src/createGithubForkForRepo.ts (+1 -1)
📝 src/createGithubPullRequest.ts (+1 -1)
📝 src/createIssueComment.ts (+1 -1)
📝 src/fetchComfyRegistryNodes.ts (+1 -1)
📝 src/gcloud/GCloudOAuth2Credentials.ts (+1 -1)
📝 src/gcloud/getAuthenticatedClient.ts (+1 -1)
📝 src/gcloud/getOAuthTokenInfo.ts (+1 -1)
📝 src/gh/index.ts (+1 -1)
📝 src/ghUser.ts (+1 -1)
📝 src/initializeFollowRules.ts (+1 -1)

...and 12 more files

📄 Description

This PR migrates the entire codebase from using @snomiao/die to phpdie package as requested in the issue.

Changes Made

Package dependency: Updated package.json to replace "@snomiao/die": "^1.2.3" with "phpdie": "^1.2.18"

Import statements: Updated 32 files across the codebase to change import statements from:

import DIE from "@snomiao/die";
import DIE, { catchArgs } from "@snomiao/die";

to:

import DIE from "phpdie";
import DIE, { catchArgs } from "phpdie";

Files Updated

The migration affected files across multiple directories:

src/ - Core source files (28 files)
app/ - Next.js app directory (1 file)
scripts/ - Utility scripts (1 file)
packages/ - Local packages (1 file)
package.json - Dependency update

Compatibility

The phpdie package provides the same API as @snomiao/die:

DIE as default export for error throwing
catchArgs as named export for error handling
Same author (snomiao), ensuring API compatibility

Testing

✅ All existing tests continue to pass/fail at the same rate as before migration
✅ TypeScript compilation works (remaining errors are pre-existing and unrelated)
✅ Manual verification confirms DIE and catchArgs functions work correctly
✅ No breaking changes introduced

Fixes #32.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

fonts.googleapis.com

Triggering command: /usr/local/bin/node /home/REDACTED/work/Comfy-PR/Comfy-PR/node_modules/next/dist/compiled/jest-worker/processChild.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled

Add the appropriate URLs or hosts to my firewall allow list

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/33 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 7/17/2025 **Status:** ✅ Merged **Merged:** 7/18/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `copilot/fix-32` --- ### 📝 Commits (3) - [`71a8dad`](https://github.com/Comfy-Org/Comfy-PR/commit/71a8dad9e07b0fa4ad8ebde0a3cb6831fb5a222d) Initial plan - [`51616c5`](https://github.com/Comfy-Org/Comfy-PR/commit/51616c545c528b7003161c4e6d138bc73539c30d) Replace @snomiao/die with phpdie package across entire codebase - [`190e198`](https://github.com/Comfy-Org/Comfy-PR/commit/190e198abbbe10a21e11b75769d6d5207f5cf1ae) Merge branch 'main' into copilot/fix-32 ### 📊 Changes **32 files changed** (+32 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `app/(dashboard)/followup/actions/send-gmail/page.tsx` (+1 -1) 📝 `package.json` (+1 -1) 📝 `packages/mongodb-pipeline-ts/$fresh.test.ts` (+1 -1) 📝 `scripts/REPO_CLEAN.ts` (+1 -1) 📝 `src/EmailTasks.ts` (+1 -1) 📝 `src/FORK_OWNER.ts` (+1 -1) 📝 `src/FORK_PREFIX.ts` (+1 -1) 📝 `src/addCommentAction.ts` (+1 -1) 📝 `src/checkComfyActivated.ts` (+1 -1) 📝 `src/cli.ts` (+1 -1) 📝 `src/createGithubForkForRepo.ts` (+1 -1) 📝 `src/createGithubPullRequest.ts` (+1 -1) 📝 `src/createIssueComment.ts` (+1 -1) 📝 `src/fetchComfyRegistryNodes.ts` (+1 -1) 📝 `src/gcloud/GCloudOAuth2Credentials.ts` (+1 -1) 📝 `src/gcloud/getAuthenticatedClient.ts` (+1 -1) 📝 `src/gcloud/getOAuthTokenInfo.ts` (+1 -1) 📝 `src/gh/index.ts` (+1 -1) 📝 `src/ghUser.ts` (+1 -1) 📝 `src/initializeFollowRules.ts` (+1 -1) _...and 12 more files_ </details> ### 📄 Description This PR migrates the entire codebase from using `@snomiao/die` to `phpdie` package as requested in the issue. ## Changes Made - **Package dependency**: Updated `package.json` to replace `"@snomiao/die": "^1.2.3"` with `"phpdie": "^1.2.18"` - **Import statements**: Updated 32 files across the codebase to change import statements from: ```typescript import DIE from "@snomiao/die"; import DIE, { catchArgs } from "@snomiao/die"; ``` to: ```typescript import DIE from "phpdie"; import DIE, { catchArgs } from "phpdie"; ``` ## Files Updated The migration affected files across multiple directories: - `src/` - Core source files (28 files) - `app/` - Next.js app directory (1 file) - `scripts/` - Utility scripts (1 file) - `packages/` - Local packages (1 file) - `package.json` - Dependency update ## Compatibility The `phpdie` package provides the same API as `@snomiao/die`: - `DIE` as default export for error throwing - `catchArgs` as named export for error handling - Same author (snomiao), ensuring API compatibility ## Testing - ✅ All existing tests continue to pass/fail at the same rate as before migration - ✅ TypeScript compilation works (remaining errors are pre-existing and unrelated) - ✅ Manual verification confirms `DIE` and `catchArgs` functions work correctly - ✅ No breaking changes introduced Fixes #32. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `fonts.googleapis.com` > - Triggering command: `/usr/local/bin/node /home/REDACTED/work/Comfy-PR/Comfy-PR/node_modules/next/dist/compiled/jest-worker/processChild.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to my [firewall allow list](https://gh.io/copilot/firewall-config) > > </details>  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:09:00 +00:00