[PR #84] [MERGED] Fix duplicate draft release announcements #86

New issue

Closed

opened 2026-10-27 21:09:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:09:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/84
Author: @webfiltered
Created: 9/30/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @snomiao

Base: main ← Head: fix-duplicate-draft-announcements

📝 Commits (3)

05ce318 Fix draft release messages saved to wrong field
d6e663f Add comprehensive tests for draft release notification fix
5ac8883 Update test file imports for bun test compatibility

📊 Changes

2 files changed (+565 additions, -2 deletions)

View changed files

➕ app/tasks/gh-desktop-release-notification/index.spec.ts (+563 -0)
📝 app/tasks/gh-desktop-release-notification/index.ts (+2 -2)

📄 Description

Fixes issue where draft release messages were sent repeatedly.

Screenshot

Changes

Draft messages were being saved to slackMessage field instead of slackMessageDrafting
Comparison checked wrong field, always evaluating to true for drafts
Now correctly uses slackMessageDrafting field for draft/prerelease messages

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/84 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `fix-duplicate-draft-announcements` --- ### 📝 Commits (3) - [`05ce318`](https://github.com/Comfy-Org/Comfy-PR/commit/05ce318c3db026dd307013d4ab3de00f365a2da0) Fix draft release messages saved to wrong field - [`d6e663f`](https://github.com/Comfy-Org/Comfy-PR/commit/d6e663fb2a920364fc54994141620862f89c3810) Add comprehensive tests for draft release notification fix - [`5ac8883`](https://github.com/Comfy-Org/Comfy-PR/commit/5ac88835b7deeff3b859c12ceac82af9967bce15) Update test file imports for bun test compatibility ### 📊 Changes **2 files changed** (+565 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `app/tasks/gh-desktop-release-notification/index.spec.ts` (+563 -0) 📝 `app/tasks/gh-desktop-release-notification/index.ts` (+2 -2) </details> ### 📄 Description Fixes issue where draft release messages were sent repeatedly. ### Screenshot <img width="514" height="274" alt="image" src="https://github.com/user-attachments/assets/e1f2de4c-708d-4952-b978-216085b11766" /> ### Changes - Draft messages were being saved to `slackMessage` field instead of `slackMessageDrafting` - Comparison checked wrong field, always evaluating to true for drafts - Now correctly uses `slackMessageDrafting` field for draft/prerelease messages --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:09:26 +00:00