[PR #5] [MERGED] Edit PyProject Toml PR Message #9

Closed
opened 2026-10-27 21:08:44 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/5
Author: @haohaocreates
Created: 6/18/2024
Status: ✅ Merged
Merged: 6/20/2024
Merged by: @snomiao

Base: main ← Head: edit-toml-PR-message


📝 Commits (10+)

  • 74a1cc5 edit PR message
  • ed06b53 fix grammar and spacing in toml PR message
  • 0d45e07 Update links in initial PR according to Robin's comments
  • 43a6bc1 update implications of versioning for custom nodes
  • 80262ff Update spelling in registry PR
  • 98d36eb add original toml PR template to outdated section to enable auto edit
  • 594976d fix(edit-toml-PR-message): add v2 outdated template edit logic
  • b7719b8 fix(edit-toml-PR-message): add v2 outdated template edit logic
  • 29be9e0 Merge branch 'main' of github.com:drip-art/Comfy-Registry-PR into edit-toml-PR-message
  • d0cce7e fix(ghuser): rename

📊 Changes

4 files changed (+29 additions, -11 deletions)

View changed files

📝 bun.lockb (+0 -0)
📝 src/updateOutdatedPullsTemplates.ts (+6 -5)
📝 templates/add-toml.md (+9 -6)
➕ templates/outdated/add-toml-v2.md (+14 -0)

📄 Description

This is what the revised draft looks like, lmk what you guys think!

Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/5 **Author:** [@haohaocreates](https://github.com/haohaocreates) **Created:** 6/18/2024 **Status:** ✅ Merged **Merged:** 6/20/2024 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `edit-toml-PR-message` --- ### 📝 Commits (10+) - [`74a1cc5`](https://github.com/Comfy-Org/Comfy-PR/commit/74a1cc5a19146743eef9f654fa4c8f72199bbe70) edit PR message - [`ed06b53`](https://github.com/Comfy-Org/Comfy-PR/commit/ed06b5376d2818780430d981dc93c34340840d8d) fix grammar and spacing in toml PR message - [`0d45e07`](https://github.com/Comfy-Org/Comfy-PR/commit/0d45e07c2c1834a109612e0904b12b10921c72e2) Update links in initial PR according to Robin's comments - [`43a6bc1`](https://github.com/Comfy-Org/Comfy-PR/commit/43a6bc101ce2c42239c2b0e5f00f00f7f0e3e92e) update implications of versioning for custom nodes - [`80262ff`](https://github.com/Comfy-Org/Comfy-PR/commit/80262fff5751a1e12456b0714224b99cbb22b710) Update spelling in registry PR - [`98d36eb`](https://github.com/Comfy-Org/Comfy-PR/commit/98d36eb7af643d59f5cfa04672844910454541b2) add original toml PR template to outdated section to enable auto edit - [`594976d`](https://github.com/Comfy-Org/Comfy-PR/commit/594976d309476ff289aae6027a6d4d0ec9f8c360) fix(edit-toml-PR-message): add v2 outdated template edit logic - [`b7719b8`](https://github.com/Comfy-Org/Comfy-PR/commit/b7719b8c9916ccc4ba09be3ef9a57e4e696eed88) fix(edit-toml-PR-message): add v2 outdated template edit logic - [`29be9e0`](https://github.com/Comfy-Org/Comfy-PR/commit/29be9e08648d5ffd1c894091058e0f53634aa587) Merge branch 'main' of github.com:drip-art/Comfy-Registry-PR into edit-toml-PR-message - [`d0cce7e`](https://github.com/Comfy-Org/Comfy-PR/commit/d0cce7e06511457ea0db3fe1c673977b6b1179a4) fix(ghuser): rename ### 📊 Changes **4 files changed** (+29 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `bun.lockb` (+0 -0) 📝 `src/updateOutdatedPullsTemplates.ts` (+6 -5) 📝 `templates/add-toml.md` (+9 -6) ➕ `templates/outdated/add-toml-v2.md` (+14 -0) </details> ### 📄 Description This is what the revised draft looks like, lmk what you guys think! # Add pyproject.toml for Custom Node Registry We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users. The main benefits are that authors can - publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not - automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard Action Required: - [ ] Go to the [registry](https://registry.comfy.org). Login and create a publisher id. Add the publisher id into the pyproject.toml file. - [ ] Write a short description. - [ ] Merge the separate Github Actions PR and run the workflow. If you want to publish the node manually, [install the cli](https://docs.comfy.org/comfy-cli/getting-started#install-cli) and run `comfy node publish` Check out our [docs](https://docs.comfy.org/registry/overview#introduction) if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our [server](https://discord.com/invite/comfyorg) if you have any questions! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-27 21:08:44 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/Comfy-PR#9
No description provided.