mirror of
https://github.com/Comfy-Org/ComfyUI-Manager.git
synced 2026-11-04 23:37:31 +00:00
[GH-ISSUE #3072] comfyui-image-oasis@1.4.0 flagged by registry security scan (2 info-level false positives) - listing info missing #1096
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/ComfyUI-Manager#1096
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NikoDemon80 on GitHub (Jul 9, 2026).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/3072
Hey, dev of comfyui-image-oasis here, following up on the flags for 1.4.0. Both are info level and I believe both are benign:
requirements.txt line 28 (contains_custom_url_dependency): the URL is inside a comment block that's explicitly labeled "Non-pip dependency (NOT installable here)". It's just documentation pointing users at city96's ComfyUI-GGUF custom node, which is optional and only needed for the GGUF source type. Nothing in the file actually installs from a URL, pip never touches that line. Happy to reword the comment to drop the raw URL in the next release if that keeps the scanner quiet.
web/image_oasis.js line 2362 (python_network_operations): this one looks like a false positive. The flagged code is the node's onAdded lifecycle override, it just calls the original handler and registers the widget. There's no network operation at that line, and it's JavaScript being matched by a Python rule. The only network calls in that file are fetches to ComfyUI's own local /api routes, which is standard for any DOM widget node.
Let me know what I need to do to get Image Oasis 1.4.0 to populate the Custom Node Manager correctly. Thanks!
@coderabbitai[bot] commented on GitHub (Jul 9, 2026):
🔗 Related PRs
Comfy-Org/ComfyUI-Manager#3006 - Fix NKD Preview Tools entry: repo renamed + dedupe [merged]
Comfy-Org/ComfyUI-Manager#3022 - Add ComfyUI-TJ_NODE_STUDIO_ONE to custom-node-list [merged]
🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your
.coderabbit.yaml:💬 Have feedback or questions? Drop into our discord!