[PR #835] [MERGED] Add support for SSH-style git repo addresses #1552

Closed
opened 2026-10-27 21:32:35 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/835
Author: @guill
Created: 7/4/2024
Status: ✅ Merged
Merged: 7/4/2024
Merged by: @ltdrdata

Base: main ← Head: git_ssh_support


📝 Commits (1)

  • f81b65a Add support for SSH-style git repo addresses

📊 Changes

3 files changed (+13 additions, -6 deletions)

View changed files

📝 cm-cli.py (+1 -1)
📝 glob/manager_core.py (+9 -3)
📝 js/common.js (+3 -2)

📄 Description

This allows nodes to be pulled from git repositories that:

  1. Require authentication
  2. Are located on a computer that does not have any special software beyond an SSH server to serve up git repos
  3. Are hosted on sites that exclusively allow SSH access

I have also cleaned up the JavaScript regex for identifying valid HTTP addresses. Due to an unescaped '.' and the lack of a count on the first group, it wasn't doing a whole lot anyway -- just checking that the very first character wasn't invalid.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/835 **Author:** [@guill](https://github.com/guill) **Created:** 7/4/2024 **Status:** ✅ Merged **Merged:** 7/4/2024 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `git_ssh_support` --- ### 📝 Commits (1) - [`f81b65a`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/f81b65a749bb0c008d08605ef8bff1265aed5a8a) Add support for SSH-style git repo addresses ### 📊 Changes **3 files changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `cm-cli.py` (+1 -1) 📝 `glob/manager_core.py` (+9 -3) 📝 `js/common.js` (+3 -2) </details> ### 📄 Description This allows nodes to be pulled from git repositories that: 1. Require authentication 2. Are located on a computer that does not have any special software beyond an SSH server to serve up git repos 3. Are hosted on sites that exclusively allow SSH access I have also cleaned up the JavaScript regex for identifying valid HTTP addresses. Due to an unescaped '.' and the lack of a count on the first group, it wasn't doing a whole lot anyway -- just checking that the very first character wasn't invalid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-27 21:32:35 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#1552
No description provided.