[PR #886] [MERGED] added support for --no-deps option to node install and reinstall #1584

Closed
opened 2026-10-27 21:32:52 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/886
Author: @telamonian
Created: 7/19/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @ltdrdata

Base: feat/cnr ← Head: no-deps


📝 Commits (3)

  • af33177 added support for --no-deps option to node install and reinstall
  • ded2428 post rebase fixup
  • 1b2fb8f fixup help msg for --no-deps option

📊 Changes

3 files changed (+66 additions, -41 deletions)

View changed files

📝 .gitignore (+3 -1)
📝 cm-cli.py (+27 -5)
📝 glob/manager_core.py (+36 -35)

📄 Description

Adds support for a no-deps option to the node install and node reinstall commands. Not only is this useful to have in general, but it's needed to support the new --fast-deps behavior (unified/much faster python dependency installs) in comfy-cli.

Two unresolved questions:

  • What commands aside from install/reinstall should also get a no-deps option? I added plumbing for no-deps such that it should be respected for any command that sets cm_ctx.no_deps = True, so it should now be easy to add to any command
  • I noticed that adjacent to requirements.txt support, there is also support for running some kind of generic <node_root>/install.py installation script. Should this installation script support also be disabled by the no-deps option? For now I've left it untouched

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/886 **Author:** [@telamonian](https://github.com/telamonian) **Created:** 7/19/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `feat/cnr` ← **Head:** `no-deps` --- ### 📝 Commits (3) - [`af33177`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/af331778c8ffc6b8482a8b8ed2fa379d252126bd) added support for `--no-deps` option to node install and reinstall - [`ded2428`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/ded2428d8c36034410cae264c661cb60820755c3) post rebase fixup - [`1b2fb8f`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/1b2fb8f512d1492040d5f1387b1ab94d84793a88) fixup help msg for --no-deps option ### 📊 Changes **3 files changed** (+66 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -1) 📝 `cm-cli.py` (+27 -5) 📝 `glob/manager_core.py` (+36 -35) </details> ### 📄 Description Adds support for a `no-deps` option to the `node install` and `node reinstall` commands. Not only is this useful to have in general, but it's needed to support the new `--fast-deps` behavior (unified/much faster python dependency installs) in comfy-cli. Two unresolved questions: - What commands aside from install/reinstall should also get a `no-deps` option? I added plumbing for `no-deps` such that it should be respected for any command that sets `cm_ctx.no_deps = True`, so it should now be easy to add to any command - I noticed that adjacent to `requirements.txt` support, there is also support for running some kind of generic `<node_root>/install.py` installation script. Should this installation script support also be disabled by the `no-deps` option? For now I've left it untouched --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-27 21:32:52 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#1584
No description provided.