mirror of
https://github.com/Comfy-Org/ComfyUI-Manager.git
synced 2026-11-04 23:37:31 +00:00
[PR #886] [MERGED] added support for --no-deps option to node install and reinstall #1584
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/ComfyUI-Manager#1584
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/886
Author: @telamonian
Created: 7/19/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @ltdrdata
Base:
feat/cnr← Head:no-deps📝 Commits (3)
af33177added support for--no-depsoption to node install and reinstallded2428post rebase fixup1b2fb8ffixup help msg for --no-deps option📊 Changes
3 files changed (+66 additions, -41 deletions)
View changed files
📝
.gitignore(+3 -1)📝
cm-cli.py(+27 -5)📝
glob/manager_core.py(+36 -35)📄 Description
Adds support for a
no-depsoption to thenode installandnode reinstallcommands. Not only is this useful to have in general, but it's needed to support the new--fast-depsbehavior (unified/much faster python dependency installs) in comfy-cli.Two unresolved questions:
no-depsoption? I added plumbing forno-depssuch that it should be respected for any command that setscm_ctx.no_deps = True, so it should now be easy to add to any commandrequirements.txtsupport, there is also support for running some kind of generic<node_root>/install.pyinstallation script. Should this installation script support also be disabled by theno-depsoption? For now I've left it untouched🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.