[PR #1233] [CLOSED] fix: use ${comfy_path}/custom_nodes as custom_nodes_path #1784

Closed
opened 2026-10-28 21:04:14 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1233
Author: @molinchn
Created: 11/12/2024
Status: ❌ Closed

Base: main ← Head: main


📝 Commits (1)

  • 232a876 fix: use ${comfy_path}/custom_nodes as custom_nodes_path

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 glob/manager_core.py (+3 -2)

📄 Description

When I use cm-cli.py as a utility to manager my ComfyUI service extension (not in custom_nodes of ComfyUI), I can export the COMFYUI_PATH environment variable as the ComfyUI directory, which is also mentioned in cm-cli.py doc.

However, some functions didn't work as expected, like python cm-cli.py save-snapshot. That's because cm-cli.py will invoke methods in manager_core.py, and resolve custom_nodes_paths as ${comfyui_manager_path}/../.., not ${comfy_path}/custom_nodes. This will result some unexpected output, and COMFYUI_PATH will become meaningless in these related methods.

In my point, if ComfyUI-Manager allows user indicate ComfyUI directory by COMFYUI_PATH, other related path should base on COMFYUI_PATH, rather than ${comfyui_manager_path}, because COMFYUI_PATH is more reliable, and it makes cm-cli.py and manager_core.py behave more consistent.

Thank you for your time and consideration.
Best regards.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1233 **Author:** [@molinchn](https://github.com/molinchn) **Created:** 11/12/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`232a876`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/232a876a5fa6c1841cdbd4b6eda760a53aa3c5a3) fix: use `${comfy_path}/custom_nodes` as `custom_nodes_path` ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_core.py` (+3 -2) </details> ### 📄 Description When I use `cm-cli.py` as a utility to manager my ComfyUI service extension (not in `custom_nodes` of ComfyUI), I can export the `COMFYUI_PATH` environment variable as the ComfyUI directory, which is also mentioned in [cm-cli.py doc](https://github.com/ltdrdata/ComfyUI-Manager/blob/main/docs/en/cm-cli.md#prerequisite). However, some functions didn't work as expected, like `python cm-cli.py save-snapshot`. That's because `cm-cli.py` will invoke methods in `manager_core.py`, and resolve `custom_nodes_paths` as `${comfyui_manager_path}/../..`, not `${comfy_path}/custom_nodes`. This will result some unexpected output, and `COMFYUI_PATH` will become meaningless in these related methods. In my point, if ComfyUI-Manager allows user indicate ComfyUI directory by `COMFYUI_PATH`, other related path should base on `COMFYUI_PATH`, rather than `${comfyui_manager_path}`, because `COMFYUI_PATH` is more reliable, and it makes `cm-cli.py` and `manager_core.py` behave more consistent. Thank you for your time and consideration. Best regards. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-28 21:04:14 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#1784
No description provided.