mirror of
https://github.com/Comfy-Org/ComfyUI-Manager.git
synced 2026-11-05 07:47:25 +00:00
[PR #1233] [CLOSED] fix: use ${comfy_path}/custom_nodes as custom_nodes_path #1784
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/ComfyUI-Manager#1784
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1233
Author: @molinchn
Created: 11/12/2024
Status: ❌ Closed
Base:
main← Head:main📝 Commits (1)
232a876fix: use${comfy_path}/custom_nodesascustom_nodes_path📊 Changes
1 file changed (+3 additions, -2 deletions)
View changed files
📝
glob/manager_core.py(+3 -2)📄 Description
When I use
cm-cli.pyas a utility to manager my ComfyUI service extension (not incustom_nodesof ComfyUI), I can export theCOMFYUI_PATHenvironment variable as the ComfyUI directory, which is also mentioned in cm-cli.py doc.However, some functions didn't work as expected, like
python cm-cli.py save-snapshot. That's becausecm-cli.pywill invoke methods inmanager_core.py, and resolvecustom_nodes_pathsas${comfyui_manager_path}/../.., not${comfy_path}/custom_nodes. This will result some unexpected output, andCOMFYUI_PATHwill become meaningless in these related methods.In my point, if ComfyUI-Manager allows user indicate ComfyUI directory by
COMFYUI_PATH, other related path should base onCOMFYUI_PATH, rather than${comfyui_manager_path}, becauseCOMFYUI_PATHis more reliable, and it makescm-cli.pyandmanager_core.pybehave more consistent.Thank you for your time and consideration.
Best regards.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.