[PR #1253] [MERGED] manager_core: Fix fetch/update line erasure output issues #1797

New issue

Closed

opened 2026-10-28 21:04:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:04:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1253
Author: @clayne
Created: 11/20/2024
Status: ✅ Merged
Merged: 11/21/2024
Merged by: @ltdrdata

Base: main ← Head: 1732145930-carriage-return-cleanup-issue

📝 Commits (1)

de0f214 manager_core: Fix fetch/update line erasure output issues

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 glob/manager_core.py (+3 -3)

📄 Description

__win_check_git_update: Properly cleanup line before using a carriage return to return to the beginning. This prevents output like:

  Updated: S:\ComfyUI\custom_nodes\ComfyUI-Impact-Packrpolation
  Updated: S:\ComfyUI\custom_nodes\comfyui-inpaint-nodesayout
  Updated: S:\ComfyUI\custom_nodes\ComfyUI-LogicUtilsodes

In this case the node being updated overlaps the existing output showing nodes being checked for updates. This happens because there's no erase until end of line being used in the windows specific function whereas the non-windows version uses it in git_repo_has_updates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1253 **Author:** [@clayne](https://github.com/clayne) **Created:** 11/20/2024 **Status:** ✅ Merged **Merged:** 11/21/2024 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `1732145930-carriage-return-cleanup-issue` --- ### 📝 Commits (1) - [`de0f214`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/de0f21496219bce7971f19de66301907a2f0866a) manager_core: Fix fetch/update line erasure output issues ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_core.py` (+3 -3) </details> ### 📄 Description * __win_check_git_update: Properly cleanup line before using a carriage return to return to the beginning. This prevents output like: ``` Updated: S:\ComfyUI\custom_nodes\ComfyUI-Impact-Packrpolation Updated: S:\ComfyUI\custom_nodes\comfyui-inpaint-nodesayout Updated: S:\ComfyUI\custom_nodes\ComfyUI-LogicUtilsodes ``` In this case the node being updated overlaps the existing output showing nodes being checked for updates. This happens because there's no erase until end of line being used in the windows specific function whereas the non-windows version uses it in git_repo_has_updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:04:22 +00:00