mirror of
https://github.com/Comfy-Org/ComfyUI-Manager.git
synced 2026-11-04 23:37:31 +00:00
[GH-ISSUE #357] Server refuses to shutdown (w/ ctrl+c) if ComfyUI-Manager is installed #182
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/ComfyUI-Manager#182
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rgthree on GitHub (Jan 23, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/357
At some point recently we can no longer press
ctrl + calone to shutdown ComfyUI. This only happens when ComfyUI-Manager is installed. On windows, portable.When ctrl+c is pressed, nothing happens in the terminal, until another http request is attempted (browser refresh button, new tab and navigate, etc.).
@rgthree commented on GitHub (Jan 23, 2024):
A
reset --hardto a farther back commit works as expected (ctrl + c stops the server immediately). I can binary search for the culprit...EDIT: Looks like it's
github.com/ltdrdata/ComfyUI-Manager@b4ffaee5dc, specifically this addition inprestartup_script.py:FYI, removing/commenting this addition fixes the issue here (server stops as expected) and seems to have no further issues on my setup.
@ltdrdata commented on GitHub (Jan 24, 2024):
This patch is related to the issue at https://github.com/ltdrdata/ComfyUI-Manager/issues/339. The problem is occurring on Windows.
It seems like some thoughtful consideration may be needed.
What is your Windows version?
@rgthree commented on GitHub (Jan 24, 2024):
I'm on Windows 11 Pro, Version: 23H2, OS Build: 22631.3007
@ltdrdata commented on GitHub (Jan 25, 2024):
Now this is optional (default false)
https://github.com/ltdrdata/ComfyUI-Manager?tab=readme-ov-file#troubleshooting
@rgthree commented on GitHub (Jan 25, 2024):
Groovy, thanks!
Though, I think there's a bug on line 470, that
'bypass_ssl'is likely meant to be'windows_selector_event_loop_policy':Shouldn't really matter since there's an outer try/except.. I guess unless someone has windows_selector_event_loop_policy and not bypass_ssl defined.
@ltdrdata commented on GitHub (Jan 25, 2024):
oops...