[PR #1303] [MERGED] Bypass ComfyUI version check when in electron env #1829

New issue

Closed

opened 2026-10-28 21:04:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:04:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1303
Author: @webfiltered
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/10/2024
Merged by: @ltdrdata

Base: main ← Head: electron-check

📝 Commits (10+)

de1a030 Hacky: hide the features we do not want to ship with electron app
977d2f8 Merge pull request #1 from Comfy-Org/yo-hide-buttons-for-manager
040bcaa Backup
cfade11 Take install path for cm-cli.
41dc407 Remove unused.
02307e6 Add no deps.
ad5fae3 Add no deps.
0f6d0e6 Merge pull request #2 from Comfy-Org/rh-fix
1ca3495 Merge branch 'ltdrdata:main' into main
65a4d55 Merge branch 'ltdrdata:main' into main

📊 Changes

4 files changed (+51 additions, -255 deletions)

View changed files

📝 cm-cli.py (+25 -7)
📝 glob/manager_core.py (+8 -7)
📝 glob/manager_server.py (+7 -3)
📝 js/comfyui-manager.js (+11 -238)

📄 Description

User changes

Fixes bug - version too outdated & not in repo warnings are never displayed
When using desktop, ComfyUI version check is skipped (handled by app)

Code / dev changes

Detects Electron by via environment var (set by Electron itself)
If debugging in an IDE built with Electron, this value will very likely be set

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1303 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `electron-check` --- ### 📝 Commits (10+) - [`de1a030`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/de1a030a79b02b1ed01420397fe28283893c7717) Hacky: hide the features we do not want to ship with electron app - [`977d2f8`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/977d2f8e1db14a5ea73bdfc9a24ec7e1aca90bfb) Merge pull request #1 from Comfy-Org/yo-hide-buttons-for-manager - [`040bcaa`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/040bcaa987502d51cdb64d5eb47c52577f71777d) Backup - [`cfade11`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/cfade11352ce7f93e14773da104ce74ceaae1aa1) Take install path for cm-cli. - [`41dc407`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/41dc4076265bf41a7cc001bbc2086b282f003bae) Remove unused. - [`02307e6`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/02307e64351f7b95a48d950c54f8cfeb47bebc58) Add no deps. - [`ad5fae3`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/ad5fae39acfbd73a7c00a8713f64ad61fcb4000f) Add no deps. - [`0f6d0e6`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/0f6d0e6ef07d4a08eef91539912a01ae1dcfe237) Merge pull request #2 from Comfy-Org/rh-fix - [`1ca3495`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/1ca349523787b943f6d03201d4aed1cb0bcbbafe) Merge branch 'ltdrdata:main' into main - [`65a4d55`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/65a4d55a8a15811458ffdf4054c6f7e2331701bd) Merge branch 'ltdrdata:main' into main ### 📊 Changes **4 files changed** (+51 additions, -255 deletions) <details> <summary>View changed files</summary> 📝 `cm-cli.py` (+25 -7) 📝 `glob/manager_core.py` (+8 -7) 📝 `glob/manager_server.py` (+7 -3) 📝 `js/comfyui-manager.js` (+11 -238) </details> ### 📄 Description #### User changes - Fixes bug - version too outdated & not in repo warnings are never displayed - When using desktop, ComfyUI version check is skipped (handled by app) #### Code / dev changes - Detects Electron by via environment var (set by Electron itself) - If debugging in an IDE built with Electron, this value will very likely be set --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:04:40 +00:00