[PR #1340] [MERGED] Enable pyflake ruff lint rules #1848

New issue

Closed

opened 2026-10-28 21:04:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:04:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1340
Author: @huchenlei
Created: 12/17/2024
Status: ✅ Merged
Merged: 12/18/2024
Merged by: @ltdrdata

Base: main ← Head: ruff

📝 Commits (1)

19532ae Enable pyflake ruff lint rules

📊 Changes

12 files changed (+111 additions, -80 deletions)

View changed files

➕ .github/workflows/ruff.yml (+23 -0)
📝 __init__.py (+3 -3)
📝 cm-cli.py (+8 -9)
📝 git_helper.py (+1 -1)
📝 glob/manager_core.py (+9 -9)
📝 glob/manager_server.py (+26 -26)
📝 glob/manager_util.py (+8 -8)
📝 glob/security_check.py (+1 -1)
📝 glob/share_3rdparty.py (+3 -5)
📝 prestartup_script.py (+15 -16)
➕ ruff.toml (+12 -0)
📝 scanner.py (+2 -2)

📄 Description

This PR enables the same ruff lint rules as in the main ComfyUI repo in preparation of eventual merge of manager to the core repo.

Ref: https://github.com/comfyanonymous/ComfyUI/pull/6033

Fixes are:

unnecessary use of f-string
used undefined variable (missing datetime import)
unused variable
"*" import
redefinition of same function name

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1340 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 12/18/2024 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `ruff` --- ### 📝 Commits (1) - [`19532ae`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/19532ae97928d69c10696ed3388c3362c6344690) Enable pyflake ruff lint rules ### 📊 Changes **12 files changed** (+111 additions, -80 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/ruff.yml` (+23 -0) 📝 `__init__.py` (+3 -3) 📝 `cm-cli.py` (+8 -9) 📝 `git_helper.py` (+1 -1) 📝 `glob/manager_core.py` (+9 -9) 📝 `glob/manager_server.py` (+26 -26) 📝 `glob/manager_util.py` (+8 -8) 📝 `glob/security_check.py` (+1 -1) 📝 `glob/share_3rdparty.py` (+3 -5) 📝 `prestartup_script.py` (+15 -16) ➕ `ruff.toml` (+12 -0) 📝 `scanner.py` (+2 -2) </details> ### 📄 Description This PR enables the same ruff lint rules as in the main ComfyUI repo in preparation of eventual merge of manager to the core repo. Ref: https://github.com/comfyanonymous/ComfyUI/pull/6033 Fixes are: - unnecessary use of f-string - used undefined variable (missing datetime import) - unused variable - "*" import - redefinition of same function name --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:04:51 +00:00