[PR #1615] [MERGED] small fix for running as py-module on windows #1976

New issue

Closed

opened 2026-10-28 21:06:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:06:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1615
Author: @bigcat88
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @ltdrdata

Base: main ← Head: fix/py-module-win32

📝 Commits (1)

c761c6c small fix for running as py-module on windows

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 glob/manager_server.py (+3 -3)
📝 prestartup_script.py (+3 -3)

📄 Description

In PR I simply changed the conditions for the code, for "python module" escaping is not important, so it can be first to not increase size of code.

I didn't notice then that there is a separate logic for Windows (I wonder why? - Linux supports paths with ") - and now that we have successfully switched to ComfyUI-Manager! test actions on Windows are starting to fail :(

P.S.: I saw another strange log string: I constantly see the text 'comfyui-frontend-package' dependency were fixed - since the package name is actually comfyui_frontend_package and code checks for comfyui-frontend-package - should I create an issue and ask you whether to fix this or not (this is the same PEP 503, where - and _ are equal in names) - or should I just open PRs right away?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1615 **Author:** [@bigcat88](https://github.com/bigcat88) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `fix/py-module-win32` --- ### 📝 Commits (1) - [`c761c6c`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/c761c6cef0dcb17491f541358b2d47216b531d8a) small fix for running as py-module on windows ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_server.py` (+3 -3) 📝 `prestartup_script.py` (+3 -3) </details> ### 📄 Description In PR I simply changed the conditions for the code, for "python module" escaping is not important, so it can be first to not increase size of code. I didn't notice then that there is a separate logic for Windows (_I wonder why? - Linux supports paths with `"`_) - and now that we have successfully switched to ComfyUI-Manager! test actions on Windows are starting to fail :( P.S.: I saw another strange log string: I constantly see the text `'comfyui-frontend-package' dependency were fixed` - since the package name is actually `comfyui_frontend_package` and code checks for `comfyui-frontend-package` - should I create an issue and ask you whether to fix this or not (this is the same PEP 503, where `-` and `_` are equal in names) - or should I just open PRs right away? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:06:01 +00:00