[PR #1737] draft: ComfyUI-Manager v4 #2036

Open
opened 2026-10-28 21:06:32 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1737
Author: @ltdrdata
Created: 4/12/2025
Status: 🔄 Open

Base: main ← Head: draft-v4


📝 Commits (10+)

  • ebcb14e support installation of system added nodepack
  • 01ac9c8 Modify the structure to be installable via pip.
  • 212b8e7 feat: support task batch
  • 149257e Merge branch 'main' into feat/queue_batch
  • 57b847e fixed: failed[..].ui_id -> failed
  • a128baf fixed: ruff check
  • 208ca31 support installation of system added nodepack
  • 42e8a95 Modify the structure to be installable via pip.
  • 81e84fa add workflow to publish to pypi
  • b4dc593 fix merge conflict

📊 Changes

82 files changed (+9731 additions, -1931 deletions)

View changed files

➕ .env.example (+1 -0)
➕ .github/workflows/ci.yml (+70 -0)
📝 .github/workflows/publish-to-pypi.yml (+15 -15)
➖ .github/workflows/publish.yml (+0 -25)
📝 .gitignore (+5 -1)
➕ CONTRIBUTING.md (+47 -0)
➕ MANIFEST.in (+14 -0)
📝 README.md (+44 -92)
➖ __init__.py (+0 -25)
➖ channels.list.template (+0 -6)
➖ cm-cli.sh (+0 -2)
📝 comfyui_manager/README.md (+4 -8)
➕ comfyui_manager/__init__.py (+104 -0)
📝 comfyui_manager/alter-list.json (+0 -0)
➕ comfyui_manager/channels.list.template (+6 -0)
📝 comfyui_manager/cm_cli/__init__.py (+0 -0)
📝 comfyui_manager/cm_cli/__main__.py (+61 -45)
➕ comfyui_manager/common/README.md (+16 -0)
➕ comfyui_manager/common/__init__.py (+0 -0)
📝 comfyui_manager/common/cm_global.py (+0 -0)

...and 62 more files

📄 Description

This PR is meant to be paired with:

This PR is based on branch:

TODO:

  • Disable eager requests made by legacy manager FE code
  • Publish initial version to pypi manually for easier testing
  • Implement cacheless
  • Test
    • Test: Can use legacy manager UI with --enable-manager-legacy-ui
      • Test: Model Manager with legacy ui
      • Test: Snapshot restore with legacy ui
      • Test: Node browsing with legacy ui
      • Test: Node management/actions with legacy ui
      • Test: Config/settings with legacy ui
      • Test: Updating and switching versions with legacy ui
      • Test: Misc. features with legacy ui
      • Test: Community Manual, Workflow Gallery, Nodes info with legacy ui
      • Test: Installing nodes with legacy ui
    • Test: Using every single feature and manager API endpoint with the full e2e setup
    • Test: Using with --disable-manager arg
    • Test: Using when manager custom node is still on user system
    • Test: ComfyUI updated but comfyui-frontend-package was not
      • Result: manager is just not useable, because no UI entry. Should be fine. Let the frontend warning in ComfyUI handle.
    • Test: Using --disable-manager arg then loading manager as a custom node This is not worth supporting--if the user wants the legacy version they can use --enable-manager-legacy-ui

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1737 **Author:** [@ltdrdata](https://github.com/ltdrdata) **Created:** 4/12/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `draft-v4` --- ### 📝 Commits (10+) - [`ebcb14e`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/ebcb14e6aab33d6ec2b26c54fd3d97881d68b27b) support installation of system added nodepack - [`01ac9c8`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/01ac9c895a7815a0923a8b942bfff4e41c804d20) Modify the structure to be installable via pip. - [`212b8e7`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/212b8e7ed2bcc6ca199e799eab61a683ac001b28) feat: support task batch - [`149257e`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/149257e4f1aaca322c2ac4abef26365a9209f835) Merge branch 'main' into feat/queue_batch - [`57b847e`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/57b847eebfa3c61dd9c6d97ed4e33cd498261686) fixed: failed[..].ui_id -> failed - [`a128baf`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/a128baf894f24c8df8208815eea81ac3461a442e) fixed: ruff check - [`208ca31`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/208ca318365f3fb15886082a2bdfce108ddf0e35) support installation of system added nodepack - [`42e8a95`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/42e8a959ddeab02207bfd68cff6fdf403b696adb) Modify the structure to be installable via pip. - [`81e84fa`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/81e84fad787cfa103a878bbf1291822902eaceae) add workflow to publish to pypi - [`b4dc593`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/b4dc59331d4f0ffa458fa88d5678569d6886c069) fix merge conflict ### 📊 Changes **82 files changed** (+9731 additions, -1931 deletions) <details> <summary>View changed files</summary> ➕ `.env.example` (+1 -0) ➕ `.github/workflows/ci.yml` (+70 -0) 📝 `.github/workflows/publish-to-pypi.yml` (+15 -15) ➖ `.github/workflows/publish.yml` (+0 -25) 📝 `.gitignore` (+5 -1) ➕ `CONTRIBUTING.md` (+47 -0) ➕ `MANIFEST.in` (+14 -0) 📝 `README.md` (+44 -92) ➖ `__init__.py` (+0 -25) ➖ `channels.list.template` (+0 -6) ➖ `cm-cli.sh` (+0 -2) 📝 `comfyui_manager/README.md` (+4 -8) ➕ `comfyui_manager/__init__.py` (+104 -0) 📝 `comfyui_manager/alter-list.json` (+0 -0) ➕ `comfyui_manager/channels.list.template` (+6 -0) 📝 `comfyui_manager/cm_cli/__init__.py` (+0 -0) 📝 `comfyui_manager/cm_cli/__main__.py` (+61 -45) ➕ `comfyui_manager/common/README.md` (+16 -0) ➕ `comfyui_manager/common/__init__.py` (+0 -0) 📝 `comfyui_manager/common/cm_global.py` (+0 -0) _...and 62 more files_ </details> ### 📄 Description This PR is meant to be paired with: - BE Change: https://github.com/comfyanonymous/ComfyUI/pull/7555 - FE Change: https://github.com/Comfy-Org/ComfyUI_frontend/pull/3367 This PR is based on branch: - https://github.com/Comfy-Org/ComfyUI-Manager/tree/feat/cacheless-v2 - https://github.com/Comfy-Org/ComfyUI-Manager/tree/feat/queue_batch ### TODO: - [x] Disable eager requests made by legacy manager FE code - [x] Publish initial version to pypi manually for easier testing - [ ] Implement cacheless - [ ] Test - [x] Test: Can use legacy manager UI with `--enable-manager-legacy-ui` - [x] Test: Model Manager with legacy ui - [ ] Test: Snapshot restore with legacy ui - [x] Test: Node browsing with legacy ui - [x] Test: Node management/actions with legacy ui - [x] Test: Config/settings with legacy ui - [ ] Test: Updating and switching versions with legacy ui - [x] Test: Misc. features with legacy ui - [x] Test: Community Manual, Workflow Gallery, Nodes info with legacy ui - [ ] Test: Installing nodes with legacy ui - [ ] Test: Using every single feature and manager API endpoint with the full e2e setup - [x] Test: Using with `--disable-manager` arg - [x] Test: Using when manager custom node is still on user system - [x] Test: ComfyUI updated but `comfyui-frontend-package` was not - Result: manager is just not useable, because no UI entry. Should be fine. Let the frontend warning in ComfyUI handle. - [x] ~~Test: Using `--disable-manager` arg then loading manager as a custom node~~ This is not worth supporting--if the user wants the legacy version they can use `--enable-manager-legacy-ui` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#2036
No description provided.