[PR #1867] [MERGED] fix(manager_util): used non normalized package name #2118

New issue

Closed

opened 2026-10-28 21:07:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:07:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1867
Author: @bigcat88
Created: 5/25/2025
Status: ✅ Merged
Merged: 5/25/2025
Merged by: @ltdrdata

Base: main ← Head: fix/manager-util/normalize-pack-name

📝 Commits (3)

988c6f6 set channel=default, mode=cache for git clone
89fded5 Merge remote-tracking branch 'origin/main'
da01f79 fix(manager_util): use normalized_name of package in fix_broken

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 glob/manager_util.py (+1 -1)

📄 Description

There is check for normalized name to be present in the new_pip_versions dictionary, but after that check the access is done using non-normalized name which leads to exceptions.

The easiest way to reproduce this is to put ComfyUI requirements into pip_auto_fix.list like comfyui-frontend-package==1.20.4 and comfyui-workflow-templates==0.1.18 which both have - in their names.

Traceback (most recent call last):
  File "/home/shurik/Visionatrix/ComfyUI/custom_nodes/ComfyUI-Manager/glob/manager_util.py", line 479, in fix_broken
    cur = StrictVersion(new_pip_versions[parsed['package']])
                        ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'comfyui-workflow-templates'
[ComfyUI-Manager] Failed to restore 'comfyui-workflow-templates==0.1.18

edited: Please just squash commits into one form the GitHub UI

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1867 **Author:** [@bigcat88](https://github.com/bigcat88) **Created:** 5/25/2025 **Status:** ✅ Merged **Merged:** 5/25/2025 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `fix/manager-util/normalize-pack-name` --- ### 📝 Commits (3) - [`988c6f6`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/988c6f67f443bbe61c527f3cc042e96443069bd4) set channel=default, mode=cache for git clone - [`89fded5`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/89fded5c0ea8db92b4ba180db37db60553eca30a) Merge remote-tracking branch 'origin/main' - [`da01f79`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/da01f79b2eb55ff70eebc9729f6f926cbfac1303) fix(manager_util): use normalized_name of package in fix_broken ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_util.py` (+1 -1) </details> ### 📄 Description There is check for normalized name to be present in the `new_pip_versions` dictionary, but after that check the access is done **using non-normalized name** which leads to exceptions. The easiest way to reproduce this is to put ComfyUI requirements into `pip_auto_fix.list` like `comfyui-frontend-package==1.20.4` and `comfyui-workflow-templates==0.1.18` which both have `-` in their names. ``` Traceback (most recent call last): File "/home/shurik/Visionatrix/ComfyUI/custom_nodes/ComfyUI-Manager/glob/manager_util.py", line 479, in fix_broken cur = StrictVersion(new_pip_versions[parsed['package']]) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ KeyError: 'comfyui-workflow-templates' [ComfyUI-Manager] Failed to restore 'comfyui-workflow-templates==0.1.18 ``` _edited: Please just squash commits into one form the GitHub UI_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:07:12 +00:00