[PR #2192] [draft] pip package policy management system #2341

New issue

Open

opened 2026-10-28 21:09:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-10-28 21:09:03 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2192
Author: @ltdrdata
Created: 10/3/2025
Status: 🔄 Open

Base: manager-v4 ← Head: feat/manager-v4-general-pip-policy

---

📝 Commits (1)

• 2866193 ● feat: Draft pip package policy management system (not yet integrated)

📊 Changes

29 files changed (+10024 additions, -1 deletions)

View changed files

📝 MANIFEST.in (+2 -1)
➕ comfyui_manager/common/pip_util.design.en.md (+713 -0)
➕ comfyui_manager/common/pip_util.implementation-plan.en.md (+614 -0)
➕ comfyui_manager/common/pip_util.py (+629 -0)
➕ comfyui_manager/common/pip_util.test-design.md (+2916 -0)
➕ tests/.gitignore (+34 -0)
➕ tests/README.md (+181 -0)
➕ tests/common/pip_util/CONTEXT_FILES_GUIDE.md (+423 -0)
➕ tests/common/pip_util/DEPENDENCY_ANALYSIS.md (+261 -0)
➕ tests/common/pip_util/DEPENDENCY_TREE_CONTEXT.md (+413 -0)
➕ tests/common/pip_util/README.md (+305 -0)
➕ tests/common/pip_util/TEST_IMPROVEMENTS.md (+433 -0)
➕ tests/common/pip_util/TEST_SCENARIOS.md (+573 -0)
➕ tests/common/pip_util/analyze_dependencies.py (+261 -0)
➕ tests/common/pip_util/conftest.py (+387 -0)
➕ tests/common/pip_util/pytest.ini (+52 -0)
➕ tests/common/pip_util/requirements-test-base.txt (+20 -0)
➕ tests/common/pip_util/setup_test_env.sh (+47 -0)
➕ tests/common/pip_util/test_dependency_protection.py (+271 -0)
➕ tests/common/pip_util/test_edge_cases.py (+279 -0)

...and 9 more files

📄 Description

Add comprehensive pip dependency conflict resolution framework as draft implementation. This is self-contained and does not affect existing ComfyUI Manager functionality.

Key components:

• pip_util.py with PipBatch class for policy-driven package management
• Lazy-loaded policy system supporting base + user overrides
• Multi-stage policy execution (uninstall → apply_first_match → apply_all_matches → restore)
• Conditional policies based on platform, installed packages, and ComfyUI version
• Comprehensive test suite covering edge cases, workflows, and platform scenarios
• Design and implementation documentation

Policy capabilities (draft):

• Package replacement (e.g., PIL → Pillow, opencv-python → opencv-contrib-python)
• Version pinning to prevent dependency conflicts
• Dependency protection during installations
• Platform-specific handling (Linux/Windows, GPU detection)
• Pre-removal and post-restoration workflows

Testing infrastructure:

• Pytest-based test suite with isolated environments
• Dependency analysis tools for conflict detection
• Coverage for policy priority, edge cases, and environment recovery

Status: Draft implementation complete, integration with manager workflows pending.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2192 **Author:** [@ltdrdata](https://github.com/ltdrdata) **Created:** 10/3/2025 **Status:** 🔄 Open **Base:** `manager-v4` ← **Head:** `feat/manager-v4-general-pip-policy` --- ### 📝 Commits (1) - [`2866193`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/2866193baf116476a78a26a1def71a525f866acb) ● feat: Draft pip package policy management system (not yet integrated) ### 📊 Changes **29 files changed** (+10024 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MANIFEST.in` (+2 -1) ➕ `comfyui_manager/common/pip_util.design.en.md` (+713 -0) ➕ `comfyui_manager/common/pip_util.implementation-plan.en.md` (+614 -0) ➕ `comfyui_manager/common/pip_util.py` (+629 -0) ➕ `comfyui_manager/common/pip_util.test-design.md` (+2916 -0) ➕ `tests/.gitignore` (+34 -0) ➕ `tests/README.md` (+181 -0) ➕ `tests/common/pip_util/CONTEXT_FILES_GUIDE.md` (+423 -0) ➕ `tests/common/pip_util/DEPENDENCY_ANALYSIS.md` (+261 -0) ➕ `tests/common/pip_util/DEPENDENCY_TREE_CONTEXT.md` (+413 -0) ➕ `tests/common/pip_util/README.md` (+305 -0) ➕ `tests/common/pip_util/TEST_IMPROVEMENTS.md` (+433 -0) ➕ `tests/common/pip_util/TEST_SCENARIOS.md` (+573 -0) ➕ `tests/common/pip_util/analyze_dependencies.py` (+261 -0) ➕ `tests/common/pip_util/conftest.py` (+387 -0) ➕ `tests/common/pip_util/pytest.ini` (+52 -0) ➕ `tests/common/pip_util/requirements-test-base.txt` (+20 -0) ➕ `tests/common/pip_util/setup_test_env.sh` (+47 -0) ➕ `tests/common/pip_util/test_dependency_protection.py` (+271 -0) ➕ `tests/common/pip_util/test_edge_cases.py` (+279 -0) _...and 9 more files_ </details> ### 📄 Description Add comprehensive pip dependency conflict resolution framework as draft implementation. This is self-contained and does not affect existing ComfyUI Manager functionality. Key components: - pip_util.py with PipBatch class for policy-driven package management - Lazy-loaded policy system supporting base + user overrides - Multi-stage policy execution (uninstall → apply_first_match → apply_all_matches → restore) - Conditional policies based on platform, installed packages, and ComfyUI version - Comprehensive test suite covering edge cases, workflows, and platform scenarios - Design and implementation documentation Policy capabilities (draft): - Package replacement (e.g., PIL → Pillow, opencv-python → opencv-contrib-python) - Version pinning to prevent dependency conflicts - Dependency protection during installations - Platform-specific handling (Linux/Windows, GPU detection) - Pre-removal and post-restoration workflows Testing infrastructure: - Pytest-based test suite with isolated environments - Dependency analysis tools for conflict detection - Coverage for policy priority, edge cases, and environment recovery Status: Draft implementation complete, integration with manager workflows pending. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi added the

pull-request

label 2026-10-28 21:09:03 +00:00

bsakaguchi referenced this issue 2026-10-28 21:09:51 +00:00

[PR #2341] [MERGED] Added new file to existing HALXP-Comfy custom node #2444

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

fix/per-graph-clear-hook

fix/manager-theme-styles

desktop-linux-form-factor

chore/node-runtime-refresh-2026-09-28

manager-v4

feat/v4-flagged-policy

fix/v3-ui-escaping

fix/v4-ui-escaping

feat/v3-flagged-policy

fix/v4-uv-conflict-attribution

test/issue-3128-c1-guard

fix/issue-3128-c1

feat/v4-dedicated-install-flags

fix/pygit2-fallback-followups

fix/comfyui-versions-pick-latest

brucew4yn3rp/main

manager-cacheless

feat/manager-v4-general-pip-policy

readme-for-migration

draft-v4

reverted-matrix-nio

fix/missing-nodes-in-subgraph

draft-v4-snapshot-diff

feat/add-taskqueue-unit-tests

feat/complete-todo-implementation

docs/docs-readme

docs/js-readme

tests/api-tests

api/openapi-spec

docs/node-db-readme

docs/glob-readme

draft-v4-add-legacy-route

draft-v4-contributing

feat/cacheless-v2

rh-test

rhform

dbg1484-1

rework_version_store

attach_node_versions

refactor/pygit2

4.3

3.42

4.2.2

4.2.1

4.1

3.39.3

4.1b8

4.1b6

4.1b5

4.1b4

4.1b3

4.1b2

4.1b1

4.0.5

3.39.2

3.39.1

4.0.4

4.0.3

3.39

3.38.3

3.38.2

3.38

3.37.1

3.37

3.35

3.33.8

3.33.7

3.33.6

3.33.5

3.33.4

3.33.3

3.33.2

3.33

3.32.5

3.32.4

3.32.3

3.32.2

3.32.1

3.32

3.31.13

3.31.12

3.31.11

3.31.8

3.31.6

3.31.4

3.31.2

3.31.1

3.31

3.30.8

3.30.7

3.30.6

3.30.5

3.30.4

3.30.2

3.29

3.28

3.27.11

3.27.8

3.27.3

3.27.2

3.27

3.26.2

3.26.1

3.26

3.25.1

3.25

3.24.1

3.24

3.23

3.22

3.21.5

3.21.3

3.21.1

3.19

3.18.1

3.17.11

3.17.9

3.17.7

3.17.6

3.17.4

3.17.3

3.17.2

3.17.1

3.17

3.16

3.15

3.14

3.13.1

3.13

3.12.2

3.12.1

3.12

3.11.3

3.11.2

3.11

3.10

3.9.4

3.9.3

3.9.2

3.9.1

3.9

3.8.1

3.8

3.7.6

3.7.5

3.7.4

3.7.3

3.7.2

3.7

3.6.5

3.6.4

3.6.2

3.6.1

3.5

3.3.11

3.3.10

3.3.9

3.3.8

3.3.7

3.3.6

3.3.5

3.3.4

3.3.3

3.3.2

2.56.2

3.3

2.55.5

2.55.3

2.54

2.53

2.52

3.0.1

2.51.9

2.51.8

2.51.7

2.51.6

2.51.5

2.51.4

2.51.2

2.51.1

2.50.1

2.50

2.48.7

2.48.6

2.48.3

2.48.4

2.48.2

2.48.1

Labels

Clear labels   

bug

  

CNR

  

duplicate

  

enhancement

  

feature request

  

feature request

  

pull-request

Mirrored from GitHub Pull Request

  

wontfix

No labels

bug

CNR

duplicate

enhancement

feature request

feature request

pull-request

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/ComfyUI-Manager#2341

No description provided.