[PR #2427] [MERGED] Fix for peername tuple size variability in get_client_ip #2487

New issue

Closed

opened 2026-10-28 21:10:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:10:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2427
Author: @GeorgeR
Created: 12/25/2025
Status: ✅ Merged
Merged: 12/26/2025
Merged by: @ltdrdata

Base: manager-v4 ← Head: manager-v4

📝 Commits (1)

6f32f95 Fix for peername tuple size variability in get_client_ip

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 comfyui_manager/__init__.py (+3 -2)

📄 Description

Was getting an error when specifying the --listen flag, which caused additional params in the peername tuple. This restricts the unpacked values to the first two (address, port) and ignores the rest.

Error handling request from ::1
Traceback (most recent call last):
  File "D:\ComfyUI\venv\Lib\site-packages\aiohttp\web_protocol.py", line 510, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\venv\Lib\site-packages\aiohttp\web_app.py", line 569, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\venv\Lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\middleware\cache_middleware.py", line 27, in cache_control
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\server.py", line 81, in deprecation_warning
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\server.py", line 171, in origin_only_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\venv\Lib\site-packages\comfyui_manager\__init__.py", line 75, in manager_middleware
    client_ip = get_client_ip(request)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ComfyUI\venv\Lib\site-packages\comfyui_manager\__init__.py", line 59, in get_client_ip
    host, port = peername
    ^^^^^^^^^^
ValueError: too many values to unpack (expected 2)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2427 **Author:** [@GeorgeR](https://github.com/GeorgeR) **Created:** 12/25/2025 **Status:** ✅ Merged **Merged:** 12/26/2025 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `manager-v4` ← **Head:** `manager-v4` --- ### 📝 Commits (1) - [`6f32f95`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/6f32f95e793eb4cbebb5e2aa1e159ec7e9db7795) Fix for peername tuple size variability in get_client_ip ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `comfyui_manager/__init__.py` (+3 -2) </details> ### 📄 Description Was getting an error when specifying the --listen flag, which caused additional params in the peername tuple. This restricts the unpacked values to the first two (address, port) and ignores the rest. ``` Error handling request from ::1 Traceback (most recent call last): File "D:\ComfyUI\venv\Lib\site-packages\aiohttp\web_protocol.py", line 510, in _handle_request resp = await request_handler(request) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\venv\Lib\site-packages\aiohttp\web_app.py", line 569, in _handle return await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\venv\Lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl return await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\middleware\cache_middleware.py", line 27, in cache_control response: web.Response = await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\server.py", line 81, in deprecation_warning response: web.Response = await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\server.py", line 171, in origin_only_middleware response = await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\venv\Lib\site-packages\comfyui_manager\__init__.py", line 75, in manager_middleware client_ip = get_client_ip(request) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI\venv\Lib\site-packages\comfyui_manager\__init__.py", line 59, in get_client_ip host, port = peername ^^^^^^^^^^ ValueError: too many values to unpack (expected 2) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:10:12 +00:00