[PR #2669] Fix: Add support for UNC network paths in channel normalization #2679

New issue

Open

opened 2026-10-28 21:11:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:11:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2669
Author: @Stefano-retinize
Created: 3/4/2026
Status: 🔄 Open

Base: main ← Head: fix-unc-path-normalization

📝 Commits (1)

7d27d9d Fix: Add support for UNC network paths in channel normalization

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 glob/manager_core.py (+2 -0)

📄 Description

What this PR does

This PR patches glob/manager_core.py -> normalize_channel() to correctly identify and allow UNC network paths (e.g., \\Server\Share\...) and absolute local paths when loading custom nodes from a private registry/channel list.

The Bug

Currently, ComfyUI-Manager rejects UNC network paths when attempting to load a custom channel. Because normalize_channel() primarily checks for http, https, or specific local directory structures, using a NAS or shared network drive throws an error and prevents the manager from loading custom node lists.

Traceback context:
manager_core.InvalidChannel: \\Retinize_NAS\our_enterprise_custom_nodes

The Fix

Updated the string matching logic in normalize_channel() so that UNC paths (starting with \\) and absolute local paths bypass the InvalidChannel exception and are treated as valid local channels. Tested locally and confirmed that custom-node-list.json now successfully resolves and loads custom nodes over a network drive.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2669 **Author:** [@Stefano-retinize](https://github.com/Stefano-retinize) **Created:** 3/4/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-unc-path-normalization` --- ### 📝 Commits (1) - [`7d27d9d`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/7d27d9d7db961202f44e29f094db29da1e948663) Fix: Add support for UNC network paths in channel normalization ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_core.py` (+2 -0) </details> ### 📄 Description ### What this PR does This PR patches `glob/manager_core.py` -> `normalize_channel()` to correctly identify and allow UNC network paths (e.g., `\\Server\Share\...`) and absolute local paths when loading custom nodes from a private registry/channel list. ### The Bug Currently, `ComfyUI-Manager` rejects UNC network paths when attempting to load a custom channel. Because `normalize_channel()` primarily checks for `http`, `https`, or specific local directory structures, using a NAS or shared network drive throws an error and prevents the manager from loading custom node lists. **Traceback context:** `manager_core.InvalidChannel: \\Retinize_NAS\our_enterprise_custom_nodes` ### The Fix Updated the string matching logic in `normalize_channel()` so that UNC paths (starting with `\\`) and absolute local paths bypass the `InvalidChannel` exception and are treated as valid local channels. Tested locally and confirmed that `custom-node-list.json` now successfully resolves and loads custom nodes over a network drive. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-28 21:11:44 +00:00

bsakaguchi referenced this issue

2026-10-28 21:11:47 +00:00

[PR #2679] [MERGED] feat: add ComfyUI Save Image Without Metadata node #2686