[PR #2682] [MERGED] feat(cli): expand --uv-compile to all node management commands with conflict attribution #2689

New issue

Closed

opened 2026-10-28 21:11:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:11:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2682
Author: @ltdrdata
Created: 3/10/2026
Status: ✅ Merged
Merged: 3/13/2026
Merged by: @ltdrdata

Base: manager-v4 ← Head: feat/unified-dep-resolver-full-rebased

📝 Commits (2)

e0f8e65 feat(cli): expand --uv-compile to all node management commands with conflict attribution
57eb67f refactor(cli): extract _finalize_resolve helper, add CNR nightly fallback and pydantic guard

📊 Changes

14 files changed (+1316 additions, -54 deletions)

View changed files

📝 cm_cli/__main__.py (+121 -27)
📝 comfyui_manager/common/unified_dep_resolver.py (+24 -3)
📝 comfyui_manager/glob/manager_core.py (+12 -2)
📝 comfyui_manager/glob/manager_server.py (+4 -3)
📝 comfyui_manager/legacy/manager_core.py (+12 -2)
📝 docs/dev/DESIGN-unified-dependency-resolver.md (+42 -7)
📝 docs/dev/PRD-unified-dependency-resolver.md (+7 -1)
📝 docs/en/cm-cli.md (+45 -4)
📝 docs/ko/cm-cli.md (+43 -4)
📝 pyproject.toml (+1 -1)
➕ tests/e2e/test_e2e_endpoint.py (+306 -0)
➕ tests/e2e/test_e2e_uv_compile.py (+254 -0)
➕ tests/test_nightly_cnr_fallback.py (+325 -0)
📝 tests/test_unified_dep_resolver.py (+120 -0)

📄 Description

Add --uv-compile flag to reinstall, update, fix, restore-snapshot, restore-dependencies, and install-deps commands. Each skips per-node pip installs and runs batch uv pip compile after all operations.

Change CollectedDeps.sources type to dict[str, list[tuple[str, str]]] to store (pack_path, pkg_spec) per requester. On resolution failure, _run_unified_resolve() cross-references conflict packages with sources using word-boundary regex and displays which node packs requested each conflicting package.

Update EN/KO user docs and DESIGN/PRD developer docs to cover the expanded commands and conflict attribution output. Strengthen unit tests for sources tuple format and compile failure attribution.

Bump version to 4.1b3.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2682 **Author:** [@ltdrdata](https://github.com/ltdrdata) **Created:** 3/10/2026 **Status:** ✅ Merged **Merged:** 3/13/2026 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `manager-v4` ← **Head:** `feat/unified-dep-resolver-full-rebased` --- ### 📝 Commits (2) - [`e0f8e65`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/e0f8e653c76cb7ef4715e7496c61ada9a8567485) feat(cli): expand --uv-compile to all node management commands with conflict attribution - [`57eb67f`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/57eb67f6156b156503dea886fb16dcbbb82bdab2) refactor(cli): extract _finalize_resolve helper, add CNR nightly fallback and pydantic guard ### 📊 Changes **14 files changed** (+1316 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `cm_cli/__main__.py` (+121 -27) 📝 `comfyui_manager/common/unified_dep_resolver.py` (+24 -3) 📝 `comfyui_manager/glob/manager_core.py` (+12 -2) 📝 `comfyui_manager/glob/manager_server.py` (+4 -3) 📝 `comfyui_manager/legacy/manager_core.py` (+12 -2) 📝 `docs/dev/DESIGN-unified-dependency-resolver.md` (+42 -7) 📝 `docs/dev/PRD-unified-dependency-resolver.md` (+7 -1) 📝 `docs/en/cm-cli.md` (+45 -4) 📝 `docs/ko/cm-cli.md` (+43 -4) 📝 `pyproject.toml` (+1 -1) ➕ `tests/e2e/test_e2e_endpoint.py` (+306 -0) ➕ `tests/e2e/test_e2e_uv_compile.py` (+254 -0) ➕ `tests/test_nightly_cnr_fallback.py` (+325 -0) 📝 `tests/test_unified_dep_resolver.py` (+120 -0) </details> ### 📄 Description Add `--uv-compile` flag to `reinstall, update, fix, restore-snapshot, restore-dependencies, and install-deps` commands. Each skips per-node pip installs and runs batch `uv pip compile` after all operations. Change `CollectedDeps.sources` type to `dict[str, list[tuple[str, str]]]` to store `(pack_path, pkg_spec)` per requester. On resolution failure, `_run_unified_resolve()` cross-references conflict packages with sources using word-boundary regex and **displays which node packs requested each conflicting package**. Update EN/KO user docs and DESIGN/PRD developer docs to cover the expanded commands and conflict attribution output. Strengthen unit tests for sources tuple format and compile failure attribution. Bump version to 4.1b3. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:11:48 +00:00