[PR #2703] [MERGED] fix(git_helper): remove comfyui_manager import to fix Windows subprocess crash #2707

New issue

Closed

opened 2026-10-28 21:11:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:11:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2703
Author: @ltdrdata
Created: 3/17/2026
Status: ✅ Merged
Merged: 3/17/2026
Merged by: @ltdrdata

Base: manager-v4 ← Head: fix/git_helper

📝 Commits (1)

25df7dc fix(git_helper): remove comfyui_manager import to fix Windows subprocess crash

📊 Changes

2 files changed (+203 additions, -1 deletions)

View changed files

📝 comfyui_manager/common/git_helper.py (+30 -1)
➕ tests/common/test_git_helper.py (+173 -0)

📄 Description

git_helper.py is spawned as a standalone subprocess on Windows (manager_core.py:1342). The import of comfyui_manager.common.timestamp_utils triggered comfyui_manager/__init__.py which imports from comfy.cli_args — unavailable in the subprocess environment, causing ModuleNotFoundError.

Inline get_backup_branch_name() using only stdlib (time, uuid), preserving the original collision-detection and UUID-fallback semantics. Add 9 tests covering standalone subprocess loading, behavioral equivalence, edge cases (repo.heads exception, 99-suffix exhaustion with UUID fallback).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2703 **Author:** [@ltdrdata](https://github.com/ltdrdata) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 3/17/2026 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `manager-v4` ← **Head:** `fix/git_helper` --- ### 📝 Commits (1) - [`25df7dc`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/25df7dcd275cfb8a4fd84615f0d302d6e93c6f7b) fix(git_helper): remove comfyui_manager import to fix Windows subprocess crash ### 📊 Changes **2 files changed** (+203 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `comfyui_manager/common/git_helper.py` (+30 -1) ➕ `tests/common/test_git_helper.py` (+173 -0) </details> ### 📄 Description `git_helper.py` is spawned as a standalone subprocess on Windows (manager_core.py:1342). The import of `comfyui_manager.common.timestamp_utils` triggered `comfyui_manager/__init__.py` which imports from `comfy.cli_args` — unavailable in the subprocess environment, causing ModuleNotFoundError. Inline `get_backup_branch_name()` using only stdlib (time, uuid), preserving the original collision-detection and UUID-fallback semantics. Add 9 tests covering standalone subprocess loading, behavioral equivalence, edge cases (repo.heads exception, 99-suffix exhaustion with UUID fallback). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:11:57 +00:00