[PR #2849] fix: skip Content-Type gate when request is None (#2843) #2829

New issue

Open

opened 2026-10-28 21:12:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:12:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2849
Author: @SAY-5
Created: 5/2/2026
Status: 🔄 Open

Base: main ← Head: fix/legacy-ui-content-type-2843

📝 Commits (2)

481c4b6 fix: skip Content-Type gate when request is None (#2843)
4656684 chore: remove em-dashes from comments

📊 Changes

2 files changed (+15 additions, -5 deletions)

View changed files

📝 glob/manager_server.py (+8 -4)
📝 tests/test_csrf_content_type_helper.py (+7 -1)

📄 Description

Fixes #2843. Legacy-UI batch flows (e.g. queue_batch triggered by "update all" / "update comfyui" with --enable-manager-legacy-ui) invoke route handlers internally with request=None, which raised AttributeError: 'NoneType' object has no attribute 'content_type' in _reject_simple_form_content_type. Adds an early None short-circuit (no Content-Type to gate against on internal calls) plus a regression test in the existing helper suite.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2849 **Author:** [@SAY-5](https://github.com/SAY-5) **Created:** 5/2/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/legacy-ui-content-type-2843` --- ### 📝 Commits (2) - [`481c4b6`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/481c4b6772e74ef10fbac91a594e891befadd6f6) fix: skip Content-Type gate when request is None (#2843) - [`4656684`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/46566848bb664c5c5dab15c06a58b7befd008ba2) chore: remove em-dashes from comments ### 📊 Changes **2 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_server.py` (+8 -4) 📝 `tests/test_csrf_content_type_helper.py` (+7 -1) </details> ### 📄 Description Fixes #2843. Legacy-UI batch flows (e.g. `queue_batch` triggered by "update all" / "update comfyui" with `--enable-manager-legacy-ui`) invoke route handlers internally with `request=None`, which raised `AttributeError: 'NoneType' object has no attribute 'content_type'` in `_reject_simple_form_content_type`. Adds an early `None` short-circuit (no Content-Type to gate against on internal calls) plus a regression test in the existing helper suite. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-28 21:12:59 +00:00