[PR #2999] Fix aria2 path handling for local (non-Docker) installations #2937

New issue

Open

opened 2026-10-28 21:13:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:13:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/2999
Author: @ViolinKaine
Created: 6/15/2026
Status: 🔄 Open

Base: main ← Head: fix/aria2-local-paths

📝 Commits (2)

857b453 Fix aria2 path handling for local (non-Docker) installations
0681955 Address Docker regression: detect container mode for aria2 path remapping

📊 Changes

1 file changed (+12 additions, -4 deletions)

View changed files

📝 glob/manager_downloader.py (+12 -4)

📄 Description

The previous logic stripped the ComfyUI base path prefix and sent a root-relative path (e.g. /custom_nodes) to aria2 via RPC, causing a permission error when aria2 tried to create that directory at the filesystem root.

Use the full absolute path when model_dir is absolute; fall back to /models/"directory" only for relative paths (Docker-style setups).

Aria2 RPC was receiving /custom_nodes instead of the full path, causing permission denied on non-Docker (local venv's) installs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/2999 **Author:** [@ViolinKaine](https://github.com/ViolinKaine) **Created:** 6/15/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/aria2-local-paths` --- ### 📝 Commits (2) - [`857b453`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/857b4534f1142f37a771760ab5f237712b63d205) Fix aria2 path handling for local (non-Docker) installations - [`0681955`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/0681955bd8def3f567dc3fced73aa912a3139046) Address Docker regression: detect container mode for aria2 path remapping ### 📊 Changes **1 file changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `glob/manager_downloader.py` (+12 -4) </details> ### 📄 Description The previous logic stripped the ComfyUI base path prefix and sent a root-relative path (e.g. /custom_nodes) to aria2 via RPC, causing a permission error when aria2 tried to create that directory at the filesystem root. Use the full absolute path when model_dir is absolute; fall back to /models/"directory" only for relative paths (Docker-style setups). Aria2 RPC was receiving /custom_nodes instead of the full path, causing permission denied on non-Docker (local venv's) installs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-28 21:13:50 +00:00