[PR #3299] [MERGED] v4: Restrict Flagged CNR installs on non-local listeners #3175

New issue

Closed

opened 2026-10-28 21:15:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:15:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/3299
Author: @ltdrdata
Created: 9/18/2026
Status: ✅ Merged
Merged: 9/18/2026
Merged by: @ltdrdata

Base: manager-v4 ← Head: feat/v4-flagged-policy

📝 Commits (1)

0c8f423 Restrict flagged CNR installs on non-local listeners

📊 Changes

12 files changed (+1325 additions, -168 deletions)

View changed files

📝 README.md (+52 -2)
📝 comfyui_manager/common/cnr_utils.py (+2 -1)
📝 comfyui_manager/common/manager_security.py (+42 -0)
📝 comfyui_manager/glob/manager_core.py (+71 -37)
📝 comfyui_manager/glob/manager_server.py (+10 -7)
📝 comfyui_manager/legacy/manager_core.py (+150 -86)
📝 comfyui_manager/legacy/manager_server.py (+29 -27)
📝 comfyui_manager/prestartup_script.py (+23 -3)
➕ tests/e2e/test_e2e_flagged_nodepacks.py (+509 -0)
➕ tests/test_flagged_nodepack_policy.py (+431 -0)
📝 tests/test_install_flags_config.py (+3 -2)
📝 tests/test_legacy_secgate_other_paths.py (+3 -3)

📄 Description

Purpose and scope

A successful Registry install response previously allowed a Flagged CNR version to proceed. Require Flagged versions to satisfy the same installation conditions as Active versions, plus a server listening exclusively on loopback or an explicit administrator override. Covers glob and legacy installation, switching, updates, deferred startup and server-scheduled restores, plus legacy batch reinstallation.

The allow_flagged_nodepack_install option belongs in config.ini’s [default] section. It defaults to false; only case-insensitive true enables it, after restarting ComfyUI. The override is intended for a trusted private network and permits non-loopback listeners. It does not detect private networks or bypass common security checks, Registry refusals or Git/pip restrictions.

Key changes

Use status from the existing CNR install response. Check policy before changing the current pack and reuse that response for execution, without another Registry lookup.
Allow CNR release installation on non-local listeners at normal-or-lower security levels in both servers. Active/Pending releases use this common gate; Flagged releases must also pass the listener/override check. Strong security still denies all CNR installation requests, and Git/nightly retain their existing restrictions.
Validate legacy reinstallation before removal, then install and rerun the pack’s script. Both cores preserve files and activation state on policy denial, retain the reason in queue/update results and avoid retrying rejected restore targets.
Recheck deferred work against current startup settings and pass the resolved server permission to scheduled restore children. Standalone CLI retains its existing interface and local administrator behavior.
Show a short security-configuration denial in the UI. Only terminal logs provide the loopback listener and private-network override remedies, including restart instructions.

Affected modules: CNR metadata mapping, installation cores, server queues, startup processing, configuration and README. Deferred switches use stored status without refreshing it from the Registry. Older reservations without status require loopback-only listeners or the override; otherwise startup rejects them without changing the pack and tells the user to request installation again. Enabling an already installed identical version remains a local activation with no Registry lookup or installation script.

Validation approach

Core tests run production installation paths with controlled external responses. E2E uses actual HTTP requests, queues, ZIP installation, restart and CLI subprocesses, with a local Registry and isolated node paths, settings and databases.

Intent	Observed result
Add restrictions only to Flagged	Active/Pending controls install; Flagged needs loopback or override. Strong-security controls reject both Active and Flagged before metadata lookup.
Preserve state on denial	Existing files, versions and activation state survive; no download or reservation is created.
Avoid duplicate lookups	Count metadata requests through installation and restore; deferred switches make no additional lookup.
Preserve execution context	Observe immediate file replacement versus deferred reservation, callback timing, standalone CLI behavior and actual server-scheduled restore children. Existing-version activation needs no Registry lookup or installation script.
Keep errors and settings correct	Verify short UI errors versus terminal remedies, Registry refusal, listener edge cases, old reservations and configuration persistence.

Tests fail when status propagation is removed, Registry refusals are ignored, or reinstall script execution is suppressed. Immediate-switch checks fail when the execution flag is dropped, and missing-status reservations are tested under both allowed and denied startup settings. Restored code passes; successful Git reinstall cases cover both catalogue entries and the CNR repository fallback.

Validation results

Current source is 0c8f423f on manager-v4, which includes #3297. Its complete Git tree is identical to the verified UI + Flagged integration 6df4aa14. Integration results below were recorded on 1a04122a; the only difference is the strengthened legacy denial-response test, and production and policy E2E files are identical. Focused policy/configuration regressions were rerun on 0c8f423f: 176 passed.

Scope	Result
Pre-rebase standalone 0ceeec62, non-E2E regression	453 passed; 12 skipped; 3 inherited failures
UI + Flagged integration 1a04122a, non-E2E regression	569 passed; 12 skipped; the same 3 failures
Policy server E2E on 1a04122a, glob and legacy	108 passed; 12 skipped
Live legacy browser E2E on 1a04122a	7 scenarios passed; no uncaught browser exceptions

The three Git backup fixture failures also occur on unchanged manager-v4. The complete local regression suite is not green. The twelve non-E2E skips require a separate CLI environment. Eight policy E2E skips require a preinstalled pack under strong security; four exclude loopback from non-local Git checks. Strong-security denial is tested directly.

Ruff, OpenAPI, code-quality and Socket checks passed on 0c8f423f. CLI E2E CI also passed on Ubuntu, Windows and macOS after rebasing onto the merged UI change.

Policy E2E uses a local Registry with real HTTP routes, queues, archive installation, deferred startup and CLI subprocesses. Separate Playwright scenarios exercise the integrated legacy UI, real installation and WebSocket completion, Active installation, Flagged denial and configuration preservation. Browser checks use frontend 1.45.15 and single-tab sessions; the legacy menu opens through its registered command because of an inherited toolbar issue.

Tests use Python 3.12 and ComfyUI 039ed38e on Python 3.10.20. The public Registry was not exercised in this run. Snapshot checks establish admission, extraction and denial-state preservation; fresh-snapshot install.py completion and file-lock/deferred-deletion handling remain outside this PR.

The existing deferred-deletion/state-consistency defect is tracked in #3301, including removal-result semantics, restart cleanup and regression acceptance criteria. The uninstall-failure test in this PR checks a reported failure; it does not establish correct reporting of a deferred deletion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/3299 **Author:** [@ltdrdata](https://github.com/ltdrdata) **Created:** 9/18/2026 **Status:** ✅ Merged **Merged:** 9/18/2026 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `manager-v4` ← **Head:** `feat/v4-flagged-policy` --- ### 📝 Commits (1) - [`0c8f423`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/0c8f423f524e01b615dfffedc662b96e482c6b62) Restrict flagged CNR installs on non-local listeners ### 📊 Changes **12 files changed** (+1325 additions, -168 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+52 -2) 📝 `comfyui_manager/common/cnr_utils.py` (+2 -1) 📝 `comfyui_manager/common/manager_security.py` (+42 -0) 📝 `comfyui_manager/glob/manager_core.py` (+71 -37) 📝 `comfyui_manager/glob/manager_server.py` (+10 -7) 📝 `comfyui_manager/legacy/manager_core.py` (+150 -86) 📝 `comfyui_manager/legacy/manager_server.py` (+29 -27) 📝 `comfyui_manager/prestartup_script.py` (+23 -3) ➕ `tests/e2e/test_e2e_flagged_nodepacks.py` (+509 -0) ➕ `tests/test_flagged_nodepack_policy.py` (+431 -0) 📝 `tests/test_install_flags_config.py` (+3 -2) 📝 `tests/test_legacy_secgate_other_paths.py` (+3 -3) </details> ### 📄 Description ## Purpose and scope A successful Registry install response previously allowed a Flagged CNR version to proceed. Require Flagged versions to satisfy the same installation conditions as Active versions, plus a server listening exclusively on loopback or an explicit administrator override. Covers glob and legacy installation, switching, updates, deferred startup and server-scheduled restores, plus legacy batch reinstallation. The allow_flagged_nodepack_install option belongs in config.ini’s [default] section. It defaults to false; only case-insensitive true enables it, after restarting ComfyUI. The override is intended for a trusted private network and permits non-loopback listeners. It does not detect private networks or bypass common security checks, Registry refusals or Git/pip restrictions. ## Key changes - Use status from the existing CNR install response. Check policy before changing the current pack and reuse that response for execution, without another Registry lookup. - Allow CNR release installation on non-local listeners at normal-or-lower security levels in both servers. Active/Pending releases use this common gate; Flagged releases must also pass the listener/override check. Strong security still denies all CNR installation requests, and Git/nightly retain their existing restrictions. - Validate legacy reinstallation before removal, then install and rerun the pack’s script. Both cores preserve files and activation state on policy denial, retain the reason in queue/update results and avoid retrying rejected restore targets. - Recheck deferred work against current startup settings and pass the resolved server permission to scheduled restore children. Standalone CLI retains its existing interface and local administrator behavior. - Show a short security-configuration denial in the UI. Only terminal logs provide the loopback listener and private-network override remedies, including restart instructions. Affected modules: CNR metadata mapping, installation cores, server queues, startup processing, configuration and README. Deferred switches use stored status without refreshing it from the Registry. Older reservations without status require loopback-only listeners or the override; otherwise startup rejects them without changing the pack and tells the user to request installation again. Enabling an already installed identical version remains a local activation with no Registry lookup or installation script. ## Validation approach Core tests run production installation paths with controlled external responses. E2E uses actual HTTP requests, queues, ZIP installation, restart and CLI subprocesses, with a local Registry and isolated node paths, settings and databases. | Intent | Observed result | |---|---| | Add restrictions only to Flagged | Active/Pending controls install; Flagged needs loopback or override. Strong-security controls reject both Active and Flagged before metadata lookup. | | Preserve state on denial | Existing files, versions and activation state survive; no download or reservation is created. | | Avoid duplicate lookups | Count metadata requests through installation and restore; deferred switches make no additional lookup. | | Preserve execution context | Observe immediate file replacement versus deferred reservation, callback timing, standalone CLI behavior and actual server-scheduled restore children. Existing-version activation needs no Registry lookup or installation script. | | Keep errors and settings correct | Verify short UI errors versus terminal remedies, Registry refusal, listener edge cases, old reservations and configuration persistence. | Tests fail when status propagation is removed, Registry refusals are ignored, or reinstall script execution is suppressed. Immediate-switch checks fail when the execution flag is dropped, and missing-status reservations are tested under both allowed and denied startup settings. Restored code passes; successful Git reinstall cases cover both catalogue entries and the CNR repository fallback. ## Validation results Current source is 0c8f423f on manager-v4, which includes #3297. Its complete Git tree is identical to the verified UI + Flagged integration 6df4aa14. Integration results below were recorded on 1a04122a; the only difference is the strengthened legacy denial-response test, and production and policy E2E files are identical. Focused policy/configuration regressions were rerun on 0c8f423f: 176 passed. | Scope | Result | |---|---| | Pre-rebase standalone 0ceeec62, non-E2E regression | 453 passed; 12 skipped; 3 inherited failures | | UI + Flagged integration 1a04122a, non-E2E regression | 569 passed; 12 skipped; the same 3 failures | | Policy server E2E on 1a04122a, glob and legacy | 108 passed; 12 skipped | | Live legacy browser E2E on 1a04122a | 7 scenarios passed; no uncaught browser exceptions | The three Git backup fixture failures also occur on unchanged manager-v4. The complete local regression suite is not green. The twelve non-E2E skips require a separate CLI environment. Eight policy E2E skips require a preinstalled pack under strong security; four exclude loopback from non-local Git checks. Strong-security denial is tested directly. Ruff, OpenAPI, code-quality and Socket checks passed on 0c8f423f. [CLI E2E CI](https://github.com/Comfy-Org/ComfyUI-Manager/actions/runs/35404887995) also passed on Ubuntu, Windows and macOS after rebasing onto the merged UI change. Policy E2E uses a local Registry with real HTTP routes, queues, archive installation, deferred startup and CLI subprocesses. Separate Playwright scenarios exercise the integrated legacy UI, real installation and WebSocket completion, Active installation, Flagged denial and configuration preservation. Browser checks use frontend 1.45.15 and single-tab sessions; the legacy menu opens through its registered command because of an inherited toolbar issue. Tests use Python 3.12 and ComfyUI 039ed38e on Python 3.10.20. The public Registry was not exercised in this run. Snapshot checks establish admission, extraction and denial-state preservation; fresh-snapshot install.py completion and file-lock/deferred-deletion handling remain outside this PR. The existing deferred-deletion/state-consistency defect is tracked in [#3301](https://github.com/Comfy-Org/ComfyUI-Manager/issues/3301), including removal-result semantics, restart cleanup and regression acceptance criteria. The uninstall-failure test in this PR checks a reported failure; it does not establish correct reporting of a deferred deletion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-28 21:15:50 +00:00