[PR #3349] fix: correlate legacy Model Manager queue events with the active batch #3218

New issue

Open

opened 2026-10-28 21:16:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:16:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/3349
Author: @ArianMoeini
Created: 10/5/2026
Status: 🔄 Open

Base: manager-v4 ← Head: fix/model-batch-correlation

📝 Commits (1)

32add3d fix: correlate model manager queue events by batch

📊 Changes

2 files changed (+88 additions, -14 deletions)

View changed files

📝 comfyui_manager/js/model-manager.js (+22 -14)
📝 tests/playwright/legacy-message-errors.spec.ts (+66 -0)

📄 Description

Summary

Ignore progress and completion events whose batch_id does not match the active Model Manager install request.
Guard missing rows on progress and stale completions after the operation has ended.
Keep matching success, failure, and empty completion paths accurate. In particular, count the backend's model_result object correctly and do not replace failure text with the refresh prompt.

Fixes #3303. Targets manager-v4, where the legacy Model Manager lives.

Validation

Added Playwright cases for unrelated progress/completion, matching success/failure/empty completion, and stale completion.
Isolated source-handler check: failed on the original v4 handler and passed on this branch.
node --check passes for the changed source and test file.
npx playwright test tests/playwright/legacy-message-errors.spec.ts --list discovers all new cases.

The Playwright cases were not executed here because no local ComfyUI legacy server is available; the repository's documented browser test setup needs that server.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/3349 **Author:** [@ArianMoeini](https://github.com/ArianMoeini) **Created:** 10/5/2026 **Status:** 🔄 Open **Base:** `manager-v4` ← **Head:** `fix/model-batch-correlation` --- ### 📝 Commits (1) - [`32add3d`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/32add3d4c8d0471ed8a6c32171d95a07497ef366) fix: correlate model manager queue events by batch ### 📊 Changes **2 files changed** (+88 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `comfyui_manager/js/model-manager.js` (+22 -14) 📝 `tests/playwright/legacy-message-errors.spec.ts` (+66 -0) </details> ### 📄 Description ## Summary - Ignore progress and completion events whose `batch_id` does not match the active Model Manager install request. - Guard missing rows on progress and stale completions after the operation has ended. - Keep matching success, failure, and empty completion paths accurate. In particular, count the backend's `model_result` object correctly and do not replace failure text with the refresh prompt. Fixes #3303. Targets `manager-v4`, where the legacy Model Manager lives. ## Validation - Added Playwright cases for unrelated progress/completion, matching success/failure/empty completion, and stale completion. - Isolated source-handler check: failed on the original v4 handler and passed on this branch. - `node --check` passes for the changed source and test file. - `npx playwright test tests/playwright/legacy-message-errors.spec.ts --list` discovers all new cases. The Playwright cases were not executed here because no local ComfyUI legacy server is available; the repository's documented browser test setup needs that server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-28 21:16:11 +00:00