[PR #3377] v4: Report desktop-linux form factor for Desktop installs on Linux #3245

New issue

Open

opened 2026-10-28 21:16:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-28 21:16:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/3377
Author: @benceruleanlu
Created: 10/15/2026
Status: 🔄 Open

Base: manager-v4 ← Head: desktop-linux-form-factor

📝 Commits (1)

9c069c1 v4: Report desktop-linux form factor for Desktop installs on Linux

📊 Changes

3 files changed (+65 additions, -21 deletions)

View changed files

📝 CHANGELOG.md (+5 -0)
📝 comfyui_manager/common/cnr_utils.py (+24 -21)
➕ tests/test_form_factor.py (+36 -0)

📄 Description

Purpose and scope

Desktop installs on Linux report form_factor=other to the registry. cnr_utils only maps the __COMFYUI_DESKTOP_VERSION__ marker to desktop-win and desktop-mac, because Desktop didn't run on Linux when it was written. The Desktop app now ships Linux standalone installs and is about to set the marker for them (Comfy-Org/Comfy-Desktop#1732), so without this change their registry data can't identify the platform.

Key changes

Move the form-factor choice out of fetch_all into get_form_factor(), so it can be tested.
Desktop on Linux reports desktop-linux. Every other combination reports what it did before.

The registry stores form_factor as free text, so the new value needs no backend change. Dashboards that group on known values need desktop-linux added.

Validation

tests/test_form_factor.py covers every platform, with and without the marker. 8 passed, 3 runs in a row. Against the previous code it fails (no helper, and Linux Desktop mapped to other). tests/test_flagged_nodepack_policy.py, which also exercises cnr_utils, still passes (89 passed). ruff check is clean on both files.

Change breakdown

Category	Files	Added	Deleted	Share of changed lines
Product code	1 (`comfyui_manager/common/cnr_utils.py`)	24	21	52% (45/86)
Test code	1 (`tests/test_form_factor.py`)	36	0	42% (36/86)
Documentation	1 (`CHANGELOG.md`)	5	0	6% (5/86)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/3377 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 10/15/2026 **Status:** 🔄 Open **Base:** `manager-v4` ← **Head:** `desktop-linux-form-factor` --- ### 📝 Commits (1) - [`9c069c1`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/9c069c13c580f47e2b434ee021f59f728f7fd2e7) v4: Report desktop-linux form factor for Desktop installs on Linux ### 📊 Changes **3 files changed** (+65 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -0) 📝 `comfyui_manager/common/cnr_utils.py` (+24 -21) ➕ `tests/test_form_factor.py` (+36 -0) </details> ### 📄 Description ## Purpose and scope Desktop installs on Linux report `form_factor=other` to the registry. `cnr_utils` only maps the `__COMFYUI_DESKTOP_VERSION__` marker to `desktop-win` and `desktop-mac`, because Desktop didn't run on Linux when it was written. The Desktop app now ships Linux standalone installs and is about to set the marker for them (Comfy-Org/Comfy-Desktop#1732), so without this change their registry data can't identify the platform. ## Key changes - Move the form-factor choice out of `fetch_all` into `get_form_factor()`, so it can be tested. - Desktop on Linux reports `desktop-linux`. Every other combination reports what it did before. The registry stores `form_factor` as free text, so the new value needs no backend change. Dashboards that group on known values need `desktop-linux` added. ## Validation `tests/test_form_factor.py` covers every platform, with and without the marker. 8 passed, 3 runs in a row. Against the previous code it fails (no helper, and Linux Desktop mapped to `other`). `tests/test_flagged_nodepack_policy.py`, which also exercises `cnr_utils`, still passes (89 passed). `ruff check` is clean on both files. ## Change breakdown | Category | Files | Added | Deleted | Share of changed lines | |---|---|---|---|---| | Product code | 1 (`comfyui_manager/common/cnr_utils.py`) | 24 | 21 | 52% (45/86) | | Test code | 1 (`tests/test_form_factor.py`) | 36 | 0 | 42% (36/86) | | Documentation | 1 (`CHANGELOG.md`) | 5 | 0 | 6% (5/86) | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-28 21:16:24 +00:00