[PR #3403] [MERGED] Add Stylebook and SceneWeaver to custom node index #3267

Closed
opened 2026-10-28 21:16:36 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/3403
Author: @EnragedAntelope
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/27/2026
Merged by: @ltdrdata

Base: main ← Head: register-stylebook-sceneweaver


📝 Commits (1)

  • 580052d Add Stylebook and SceneWeaver to custom node index

📊 Changes

1 file changed (+20 additions, -0 deletions)

View changed files

📝 custom-node-list.json (+20 -0)

📄 Description

Summary

  • Register Stylebook and SceneWeaver in custom-node-list.json.
  • Use the same repository URLs as their existing Comfy Registry records.
  • Leave generated databases and all Manager code unchanged.

Repositories:

Both packs already appear through Comfy Registry, but have no entries in the
Manager catalog. Their rows therefore use Registry page URLs as reference,
and populate_github_stats cannot match those URLs to GitHub statistics.
The normal scanner also does not discover their repository URLs from this
catalog. Both stars and Last Update consequently show N/A.

These entries put the packs on the existing catalog-backed Registry merge
path. That path retains the GitHub reference and emits the update-state field
used by the UI. The general Registry-only update-state defect is already
tracked in #3220 and addressed by the existing #3261; this PR does not duplicate
that code change.

Please allow the normal database generation to populate github-stats.json;
no generated statistics are included here.

Validation

  • Parsed the complete modified JSON; confirmed exactly two additions, matching
    canonical repository URLs, no duplicate target entries, and no modifications
    to existing entries.
  • Ran the actual scanner.get_git_urls_from_json function against this file;
    both repository URLs were discovered.
  • Exercised the actual Manager catalog loader, Registry merge, and GitHub stats
    lookup in an isolated harness using the local catalog and read-only live
    Registry snapshots. Installation-state scenarios used synthetic inventory;
    the live API separately confirmed that both installed packs were nightly.
    Filesystem reload was disabled; production merge/lookup functions were not
    reimplemented.
  • Reproduced the current last_update=-1 and missing update-state rows using
    the original catalog. With these entries and fresh GitHub statistics modeling
    the next scanner refresh, both dates and stars resolved.
  • Checked nightly, older stable, current stable, and not-installed states;
    older stable versions emitted update-state=true, while current stable
    versions did not. Verified the adjacent Identity Forge row was unchanged.
  • Ran
    python -m pytest tests/test_pack_column_escaping.py tests/test_update_result_rendering.py -q:
    16 passed, 2 skipped, 16 subtests passed. The optional Playwright scenarios
    were skipped; metadata-column tests ran.
  • git diff --check passed.

The README's exact Use local DB dialog check was not performed: no connected
browser automation session was available. The real local-mode loader and merge
were checked through the isolated harness instead. No queue operations, jobs,
installs, updates, or restarts were performed on the running ComfyUI instance.
The checkout's full Ruff check could not run because Ruff is not installed in
the available Python environment; this change contains no Python edits.

Registry security flags on the latest releases are separate from this catalog
registration. This PR does not clear flags or bypass installation policy.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/3403 **Author:** [@EnragedAntelope](https://github.com/EnragedAntelope) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 10/27/2026 **Merged by:** [@ltdrdata](https://github.com/ltdrdata) **Base:** `main` ← **Head:** `register-stylebook-sceneweaver` --- ### 📝 Commits (1) - [`580052d`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/580052dcd25eda0758f3f488f53a70d9b5b952e0) Add Stylebook and SceneWeaver to custom node index ### 📊 Changes **1 file changed** (+20 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `custom-node-list.json` (+20 -0) </details> ### 📄 Description ## Summary - Register Stylebook and SceneWeaver in `custom-node-list.json`. - Use the same repository URLs as their existing Comfy Registry records. - Leave generated databases and all Manager code unchanged. Repositories: - https://github.com/EnragedAntelope/comfyui-stylebook - https://github.com/EnragedAntelope/comfyui-sceneweaver Both packs already appear through Comfy Registry, but have no entries in the Manager catalog. Their rows therefore use Registry page URLs as `reference`, and `populate_github_stats` cannot match those URLs to GitHub statistics. The normal scanner also does not discover their repository URLs from this catalog. Both stars and Last Update consequently show `N/A`. These entries put the packs on the existing catalog-backed Registry merge path. That path retains the GitHub reference and emits the `update-state` field used by the UI. The general Registry-only update-state defect is already tracked in #3220 and addressed by the existing #3261; this PR does not duplicate that code change. Please allow the normal database generation to populate `github-stats.json`; no generated statistics are included here. ## Validation - Parsed the complete modified JSON; confirmed exactly two additions, matching canonical repository URLs, no duplicate target entries, and no modifications to existing entries. - Ran the actual `scanner.get_git_urls_from_json` function against this file; both repository URLs were discovered. - Exercised the actual Manager catalog loader, Registry merge, and GitHub stats lookup in an isolated harness using the local catalog and read-only live Registry snapshots. Installation-state scenarios used synthetic inventory; the live API separately confirmed that both installed packs were nightly. Filesystem reload was disabled; production merge/lookup functions were not reimplemented. - Reproduced the current `last_update=-1` and missing `update-state` rows using the original catalog. With these entries and fresh GitHub statistics modeling the next scanner refresh, both dates and stars resolved. - Checked nightly, older stable, current stable, and not-installed states; older stable versions emitted `update-state=true`, while current stable versions did not. Verified the adjacent Identity Forge row was unchanged. - Ran `python -m pytest tests/test_pack_column_escaping.py tests/test_update_result_rendering.py -q`: 16 passed, 2 skipped, 16 subtests passed. The optional Playwright scenarios were skipped; metadata-column tests ran. - `git diff --check` passed. The README's exact `Use local DB` dialog check was not performed: no connected browser automation session was available. The real local-mode loader and merge were checked through the isolated harness instead. No queue operations, jobs, installs, updates, or restarts were performed on the running ComfyUI instance. The checkout's full Ruff check could not run because Ruff is not installed in the available Python environment; this change contains no Python edits. Registry security flags on the latest releases are separate from this catalog registration. This PR does not clear flags or bypass installation policy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-28 21:16:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#3267
No description provided.