[GH-ISSUE #772] bumping version of installed package in requirements.txt does not automatically install the required version #348

Closed
opened 2026-10-27 21:16:32 +00:00 by bsakaguchi · 2 comments
Owner

Originally created by @ljleb on GitHub (Jun 14, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/772

I just bumped the version of the library that I use for my node pack:
github.com/ljleb/comfy-mecha@4569a8bbee

after trying to update the pack from before to after this commit, I see this in the console:

 ### ComfyUI-Impact-Pack: Check basic models
 Install: pip packages for 'D:\src\ComfyUI\custom_nodes\comfy-mecha'

[ComfyUI-Manager] Startup script completed.
#######################################################################

So it does not try to update the newer required version 0.0.17 of the backing lib, even though an older version 0.0.16 is currently installed.

Is this the expected behavior by manager? I would expect it to try to honor the versions specified in requirements.txt

Originally created by @ljleb on GitHub (Jun 14, 2024). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/772 I just bumped the version of the library that I use for my node pack: https://github.com/ljleb/comfy-mecha/commit/4569a8bbeea08809800800f47e5b51183ed405f9 after trying to update the pack from before to after this commit, I see this in the console: ``` ### ComfyUI-Impact-Pack: Check basic models Install: pip packages for 'D:\src\ComfyUI\custom_nodes\comfy-mecha' [ComfyUI-Manager] Startup script completed. ####################################################################### ``` So it does not try to update the newer required version 0.0.17 of the backing lib, even though an older version 0.0.16 is currently installed. Is this the expected behavior by manager? I would expect it to try to honor the versions specified in requirements.txt
Author
Owner

@ltdrdata commented on GitHub (Jun 15, 2024):

Need to be checked.

<!-- gh-comment-id:2169303999 --> @ltdrdata commented on GitHub (Jun 15, 2024): Need to be checked.
Author
Owner

@ljleb commented on GitHub (Jun 18, 2024):

I can confirm the new version of is_installed does the job! thanks for the quick work on this issue. I'm closing this as it seems to be good enough for my use case.

<!-- gh-comment-id:2176191031 --> @ljleb commented on GitHub (Jun 18, 2024): I can confirm the new version of `is_installed` does the job! thanks for the quick work on this issue. I'm closing this as it seems to be good enough for my use case.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#348
No description provided.