Comfy-Org/ComfyUI-Manager
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI-Manager.git synced 2026-11-05 07:47:25 +00:00
Code Issues 456 Projects Packages Wiki Activity

[GH-ISSUE #848] [BUG] download_url function needs three params but only two passed when called in copy_install function #373

New issue
Closed
opened 2026-10-27 21:16:49 +00:00 by bsakaguchi · 10 comments
bsakaguchi commented 2026-10-27 21:16:49 +00:00
Owner
Copy link

Originally created by @Maslino on GitHub (Jul 9, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/848

As the following code shows

def copy_install(files, js_path_name=None):
    for url in files:
        if url.endswith("/"):
            url = url[:-1]
        try:
            if url.endswith(".py"):
                download_url(url, core.custom_nodes_path)                           # this call
            else:
                path = os.path.join(core.js_path, js_path_name) if js_path_name is not None else core.js_path
                if not os.path.exists(path):
                    os.makedirs(path)
                download_url(url, path)                                             # and this call

        except Exception as e:
            print(f"Install(copy) error: {url} / {e}", file=sys.stderr)
            return False

    print("Installation was successful.")
    return True
Originally created by @Maslino on GitHub (Jul 9, 2024). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/848 As the following code shows ```python def copy_install(files, js_path_name=None): for url in files: if url.endswith("/"): url = url[:-1] try: if url.endswith(".py"): download_url(url, core.custom_nodes_path) # this call else: path = os.path.join(core.js_path, js_path_name) if js_path_name is not None else core.js_path if not os.path.exists(path): os.makedirs(path) download_url(url, path) # and this call except Exception as e: print(f"Install(copy) error: {url} / {e}", file=sys.stderr) return False print("Installation was successful.") return True ```
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@MAkC8 commented on GitHub (Jul 9, 2024):

ComfyUI does not load Manager as usual. May this bug disappear Manager button ?
Screenshot 2024-07-09 at 5 40 54 PM

<!-- gh-comment-id:2217781149 --> @MAkC8 commented on GitHub (Jul 9, 2024): ComfyUI does not load Manager as usual. May this bug disappear Manager button ? ![Screenshot 2024-07-09 at 5 40 54 PM](https://github.com/ltdrdata/ComfyUI-Manager/assets/14121746/d0e84dba-67fc-44de-b36f-ba572ccb839e)
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@ltdrdata commented on GitHub (Jul 9, 2024):

I have no problem. What is your terminal log?

<!-- gh-comment-id:2217793262 --> @ltdrdata commented on GitHub (Jul 9, 2024): I have no problem. What is your terminal log?
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@MAkC8 commented on GitHub (Jul 9, 2024):

I using Vast.ai with docker image of "ghcr.io/ai-dock/comfyui:latest-jupyter" which install ComfyUI-Manager by default. Always it is ok , but today it's button didn't visible ...
I couldn't find the log of loading ComfyUI-Manager from server. I just have these logs from panel :

### Loading: ComfyUI-Manager (V2.46.1)
### ComfyUI Revision: 2129 [719fb2c8] *DETACHED | Released on '2024-04-14'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
==> /var/log/supervisor/serviceportal.log <==
INFO:     185.124.108.178:0 - "POST /ajax/processes/restart HTTP/1.1" 200 OK
INFO:     185.124.108.178:0 - "POST /ajax/logs HTTP/1.1" 200 OK
==> /var/log/supervisor/supervisor.log <==
2024-07-09 13:54:41,407 INFO success: comfyui entered RUNNING state, process has stayed up for > than 5 seconds (startsecs)
==> /var/log/supervisor/serviceportal.log <==
INFO:     ('185.124.108.178', 0) - "WebSocket /ai-dock/logtail.sh" [accepted]
<!-- gh-comment-id:2217830646 --> @MAkC8 commented on GitHub (Jul 9, 2024): I using Vast.ai with docker image of "ghcr.io/ai-dock/comfyui:latest-jupyter" which install ComfyUI-Manager by default. Always it is ok , but today it's button didn't visible ... I couldn't find the log of loading ComfyUI-Manager from server. I just have these logs from panel : ``` ### Loading: ComfyUI-Manager (V2.46.1) ### ComfyUI Revision: 2129 [719fb2c8] *DETACHED | Released on '2024-04-14' [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json ==> /var/log/supervisor/serviceportal.log <== INFO: 185.124.108.178:0 - "POST /ajax/processes/restart HTTP/1.1" 200 OK INFO: 185.124.108.178:0 - "POST /ajax/logs HTTP/1.1" 200 OK ==> /var/log/supervisor/supervisor.log <== 2024-07-09 13:54:41,407 INFO success: comfyui entered RUNNING state, process has stayed up for > than 5 seconds (startsecs) ==> /var/log/supervisor/serviceportal.log <== INFO: ('185.124.108.178', 0) - "WebSocket /ai-dock/logtail.sh" [accepted] ```
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@ltdrdata commented on GitHub (Jul 9, 2024):

Why are you using old version of ComfyUI? ComfyUI Revision: 2129 [719fb2c8] *DETACHED
Btw, press F12 and see browser console log if your are using chrome browser.

<!-- gh-comment-id:2217834652 --> @ltdrdata commented on GitHub (Jul 9, 2024): Why are you using old version of ComfyUI? `ComfyUI Revision: 2129 [719fb2c8] *DETACHED ` Btw, press F12 and see browser console log if your are using chrome browser.
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@MAkC8 commented on GitHub (Jul 9, 2024):

Is there any shortcut for command to show manager window without touching button of "Manager" from right panel ?

<!-- gh-comment-id:2217835777 --> @MAkC8 commented on GitHub (Jul 9, 2024): Is there any shortcut for command to show manager window without touching button of "Manager" from right panel ?
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@ltdrdata commented on GitHub (Jul 9, 2024):

I confirmed that issue is the problem of the old ComfyUI version (the specific commit hash 719fb2c8).
You have to update ComfyUI.

<!-- gh-comment-id:2217839576 --> @ltdrdata commented on GitHub (Jul 9, 2024): I confirmed that issue is the problem of the old ComfyUI version (the specific commit hash 719fb2c8). You have to update ComfyUI.
bsakaguchi commented 2026-10-27 21:16:50 +00:00
Author
Owner
Copy link

@MAkC8 commented on GitHub (Jul 9, 2024):

I just run the last version right now, I thought maybe it related to new version.
this is the console log of browser for the latest version:
Screenshot 2024-07-09 at 6 12 06 PM

<!-- gh-comment-id:2217852929 --> @MAkC8 commented on GitHub (Jul 9, 2024): I just run the last version right now, I thought maybe it related to new version. this is the console log of browser for the latest version: ![Screenshot 2024-07-09 at 6 12 06 PM](https://github.com/ltdrdata/ComfyUI-Manager/assets/14121746/d7c60deb-ce31-43e3-99c6-cd92b68d768d)
bsakaguchi commented 2026-10-27 21:16:51 +00:00
Author
Owner
Copy link

@ltdrdata commented on GitHub (Jul 9, 2024):

I just run the last version right now, I thought maybe it related to new version. this is the console log of browser for the latest version: Screenshot 2024-07-09 at 6 12 06 PM

That issue is fixed now.

<!-- gh-comment-id:2217858393 --> @ltdrdata commented on GitHub (Jul 9, 2024): > I just run the last version right now, I thought maybe it related to new version. this is the console log of browser for the latest version: ![Screenshot 2024-07-09 at 6 12 06 PM](https://private-user-images.githubusercontent.com/14121746/346990535-d7c60deb-ce31-43e3-99c6-cd92b68d768d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MzQ3NzcsIm5iZiI6MTcyMDUzNDQ3NywicGF0aCI6Ii8xNDEyMTc0Ni8zNDY5OTA1MzUtZDdjNjBkZWItY2UzMS00M2UzLTk5YzYtY2Q5MmI2OGQ3NjhkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDE0MTQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyYTdlMmY3YWQ1NjY4NGU4Yzg2NWEwM2U3ZTA3ZWIwNDcyZmFiMTcwZDY4MzA0ZjgyNjkwMzFiZmY1YzUwMGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bimzxd7gU8EGPx-_F_ofsaWhOHoy6Gec0XPowWHo3SQ) That issue is fixed now.
bsakaguchi commented 2026-10-27 21:16:51 +00:00
Author
Owner
Copy link

@MAkC8 commented on GitHub (Jul 9, 2024):

Maybe it related to ComfyUI version?

<!-- gh-comment-id:2217873480 --> @MAkC8 commented on GitHub (Jul 9, 2024): Maybe it related to ComfyUI version?
bsakaguchi commented 2026-10-27 21:16:51 +00:00
Author
Owner
Copy link

@ltdrdata commented on GitHub (Jul 9, 2024):

Maybe it related to ComfyUI version?
image

While ComfyUI-Manager now supports a new style menu, a backward compatibility feature was included for users of older versions of ComfyUI. However, this feature had an error, causing issues for those using older ComfyUI versions.

The problem can be resolved by either updating ComfyUI-Manager to the latest version or by updating ComfyUI itself to the most recent version.

<!-- gh-comment-id:2217882634 --> @ltdrdata commented on GitHub (Jul 9, 2024): > Maybe it related to ComfyUI version? ![image](https://github.com/ltdrdata/ComfyUI-Manager/assets/128333288/4fa40c5c-68be-40e3-bfe4-edb6f23b938a) While ComfyUI-Manager now supports a new style menu, a backward compatibility feature was included for users of older versions of ComfyUI. However, this feature had an error, causing issues for those using older ComfyUI versions. The problem can be resolved by either updating ComfyUI-Manager to the latest version or by updating ComfyUI itself to the most recent version.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/per-graph-clear-hook
fix/manager-theme-styles
desktop-linux-form-factor
chore/node-runtime-refresh-2026-09-28
manager-v4
feat/v4-flagged-policy
fix/v3-ui-escaping
fix/v4-ui-escaping
feat/v3-flagged-policy
fix/v4-uv-conflict-attribution
test/issue-3128-c1-guard
fix/issue-3128-c1
feat/v4-dedicated-install-flags
fix/pygit2-fallback-followups
fix/comfyui-versions-pick-latest
brucew4yn3rp/main
manager-cacheless
feat/manager-v4-general-pip-policy
readme-for-migration
draft-v4
reverted-matrix-nio
fix/missing-nodes-in-subgraph
draft-v4-snapshot-diff
feat/add-taskqueue-unit-tests
feat/complete-todo-implementation
docs/docs-readme
docs/js-readme
tests/api-tests
api/openapi-spec
docs/node-db-readme
docs/glob-readme
draft-v4-add-legacy-route
draft-v4-contributing
feat/cacheless-v2
rh-test
rhform
dbg1484-1
rework_version_store
attach_node_versions
refactor/pygit2
4.3
3.42
4.2.2
4.2.1
4.1
3.39.3
4.1b8
4.1b6
4.1b5
4.1b4
4.1b3
4.1b2
4.1b1
4.0.5
3.39.2
3.39.1
4.0.4
4.0.3
3.39
3.38.3
3.38.2
3.38
3.37.1
3.37
3.35
3.33.8
3.33.7
3.33.6
3.33.5
3.33.4
3.33.3
3.33.2
3.33
3.32.5
3.32.4
3.32.3
3.32.2
3.32.1
3.32
3.31.13
3.31.12
3.31.11
3.31.8
3.31.6
3.31.4
3.31.2
3.31.1
3.31
3.30.8
3.30.7
3.30.6
3.30.5
3.30.4
3.30.2
3.29
3.28
3.27.11
3.27.8
3.27.3
3.27.2
3.27
3.26.2
3.26.1
3.26
3.25.1
3.25
3.24.1
3.24
3.23
3.22
3.21.5
3.21.3
3.21.1
3.19
3.18.1
3.17.11
3.17.9
3.17.7
3.17.6
3.17.4
3.17.3
3.17.2
3.17.1
3.17
3.16
3.15
3.14
3.13.1
3.13
3.12.2
3.12.1
3.12
3.11.3
3.11.2
3.11
3.10
3.9.4
3.9.3
3.9.2
3.9.1
3.9
3.8.1
3.8
3.7.6
3.7.5
3.7.4
3.7.3
3.7.2
3.7
3.6.5
3.6.4
3.6.2
3.6.1
3.5
3.3.11
3.3.10
3.3.9
3.3.8
3.3.7
3.3.6
3.3.5
3.3.4
3.3.3
3.3.2
2.56.2
3.3
2.55.5
2.55.3
2.54
2.53
2.52
3.0.1
2.51.9
2.51.8
2.51.7
2.51.6
2.51.5
2.51.4
2.51.2
2.51.1
2.50.1
2.50
2.48.7
2.48.6
2.48.3
2.48.4
2.48.2
2.48.1
Labels
Clear labels   
bug

   
CNR

   
duplicate

   
enhancement

   
feature request

   
feature request

   
pull-request
Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
CNR
duplicate
enhancement
feature request
feature request
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#373
No description provided.