[GH-ISSUE #921] Cmd('git') failed due to: exit code(129) when updating node #400

Open
opened 2026-10-27 21:17:08 +00:00 by bsakaguchi · 10 comments
Owner

Originally created by @irrikrlla on GitHub (Aug 1, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/921

屏幕截图 2024-08-01 224219
I tried to update a node, with the newest ComfyUImanager, but failed with the e Cmd('git') failed due to: exit code(129). I also tried to fix by modifying the code, but had no idea where is the bug. Is there any idea to solve this? It's the first time I meet the issue with manager.

Originally created by @irrikrlla on GitHub (Aug 1, 2024). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/921 ![屏幕截图 2024-08-01 224219](https://github.com/user-attachments/assets/0a453e5b-ed7d-46d2-b05c-3ef99e5ebe42) I tried to update a node, with the newest ComfyUImanager, but failed with the e Cmd('git') failed due to: exit code(129). I also tried to fix by modifying the code, but had no idea where is the bug. Is there any idea to solve this? It's the first time I meet the issue with manager.
Author
Owner

@ltdrdata commented on GitHub (Aug 1, 2024):

Please show the results of executing the following commands in cmd:

git diff --cached
git --version
<!-- gh-comment-id:2263491050 --> @ltdrdata commented on GitHub (Aug 1, 2024): Please show the results of executing the following commands in cmd: ``` git diff --cached git --version ```
Author
Owner

@irrikrlla commented on GitHub (Aug 2, 2024):

屏幕截图 2024-08-02 083055
Here is the result~
git version is the latest, git diff --cached command gives nothing

<!-- gh-comment-id:2264275458 --> @irrikrlla commented on GitHub (Aug 2, 2024): ![屏幕截图 2024-08-02 083055](https://github.com/user-attachments/assets/b25127bd-afb7-4380-a5c7-5a8e144d3ad6) Here is the result~ git version is the latest, git diff --cached command gives nothing
Author
Owner

@cheezmil commented on GitHub (Sep 23, 2024):

+1
image

<!-- gh-comment-id:2368665379 --> @cheezmil commented on GitHub (Sep 23, 2024): +1 ![image](https://github.com/user-attachments/assets/6c0e4c24-ab9c-48f3-8b58-d57d64739d4e)
Author
Owner

@cheezmil commented on GitHub (Sep 23, 2024):

image
After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do.

<!-- gh-comment-id:2368699399 --> @cheezmil commented on GitHub (Sep 23, 2024): ![image](https://github.com/user-attachments/assets/bf3376bd-3734-488b-a3df-55c72c2b06dc) After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do.
Author
Owner

@ltdrdata commented on GitHub (Sep 23, 2024):

After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do.

That directory isn't on a network drive, is it?

<!-- gh-comment-id:2368714683 --> @ltdrdata commented on GitHub (Sep 23, 2024): > After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do. That directory isn't on a network drive, is it?
Author
Owner

@cheezmil commented on GitHub (Sep 23, 2024):

After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do.

That directory isn't on a network drive, is it?

“That directory isn't on a network drive, is it?” No, it may not have anything to do with this.

I found that running cmd as an administrator can solve this problem, but I don't know if it's safe to do so..

<!-- gh-comment-id:2368730933 --> @cheezmil commented on GitHub (Sep 23, 2024): > > After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do. > > That directory isn't on a network drive, is it? “That directory isn't on a network drive, is it?” No, it may not have anything to do with this. I found that running cmd as an administrator can solve this problem, but I don't know if it's safe to do so..
Author
Owner

@ltdrdata commented on GitHub (Sep 23, 2024):

After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do.

That directory isn't on a network drive, is it?

“That directory isn't on a network drive, is it?” No, it may not have anything to do with this.

I found that running cmd as an administrator can solve this problem, but I don't know if it's safe to do so..

What about permission?

<!-- gh-comment-id:2368755358 --> @ltdrdata commented on GitHub (Sep 23, 2024): > > > After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do. > > > > > > That directory isn't on a network drive, is it? > > “That directory isn't on a network drive, is it?” No, it may not have anything to do with this. > > I found that running cmd as an administrator can solve this problem, but I don't know if it's safe to do so.. What about permission?
Author
Owner

@cheezmil commented on GitHub (Sep 24, 2024):

After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do.

That directory isn't on a network drive, is it?

“That directory isn't on a network drive, is it?” No, it may not have anything to do with this.
I found that running cmd as an administrator can solve this problem, but I don't know if it's safe to do so..

What about permission?

I have found a solution。
https://www.zhihu.com/tardis/bd/art/619858339

Running Comfyui's cmd as an administrator can also solve the problem.

In addition, there is also an issue with ComfyUI Manager. Even though it reports an error with exit code (129), it still shows that the update was successful. The exception should be caught instead of informing the user that the update was successful.

<!-- gh-comment-id:2371444741 --> @cheezmil commented on GitHub (Sep 24, 2024): > > > > After entering this command, I can click on "try updata" in Comfyui. It's really strange. Do I have to enter this command every time I update? It's too troublesome. What should I do. > > > > > > > > > That directory isn't on a network drive, is it? > > > > > > “That directory isn't on a network drive, is it?” No, it may not have anything to do with this. > > I found that running cmd as an administrator can solve this problem, but I don't know if it's safe to do so.. > > What about permission? I have found a solution。 https://www.zhihu.com/tardis/bd/art/619858339 Running Comfyui's cmd as an administrator can also solve the problem. In addition, there is also an issue with ComfyUI Manager. Even though it reports an error with exit code (129), it still shows that the update was successful. The exception should be caught instead of informing the user that the update was successful.
Author
Owner

@n0valis commented on GitHub (Nov 24, 2024):

Yes can confirm. ComfyUI does not capture the fail instead claims success.

I have found a solution。 https://www.zhihu.com/tardis/bd/art/619858339

How is that a solutution? That's bloody chinese

<!-- gh-comment-id:2496278761 --> @n0valis commented on GitHub (Nov 24, 2024): Yes can confirm. ComfyUI does not capture the fail instead claims success. > I have found a solution。 https://www.zhihu.com/tardis/bd/art/619858339 > How is that a solutution? That's bloody chinese
Author
Owner

@ltdrdata commented on GitHub (Nov 25, 2024):

Yes can confirm. ComfyUI does not capture the fail instead claims success.

I have found a solution。 https://www.zhihu.com/tardis/bd/art/619858339

How is that a solutution? That's bloody chinese

In Explorer, check the properties of the directory in the permissions section to verify if the owner is set to your account.

<!-- gh-comment-id:2496506243 --> @ltdrdata commented on GitHub (Nov 25, 2024): > Yes can confirm. ComfyUI does not capture the fail instead claims success. > > > I have found a solution。 https://www.zhihu.com/tardis/bd/art/619858339 > > How is that a solutution? That's bloody chinese In Explorer, check the properties of the directory in the permissions section to verify if the owner is set to your account.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#400
No description provided.