[GH-ISSUE #920] [BUG] wrong channel_url param in get_risky_level function #402

New issue

Closed

opened 2026-10-27 21:17:08 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-27 21:17:08 +00:00

Owner

Originally created by @Maslino on GitHub (Aug 1, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/920

async def get_risky_level(files):
    json_data1 = await core.get_data_by_mode('local', 'custom-node-list.json')
    json_data2 = await core.get_data_by_mode('cache', 'custom-node-list.json', channel_url='https://github.com/ltdrdata/ComfyUI-Manager/raw/main/custom-node-list.json')

    all_urls = set()
    for x in json_data1['custom_nodes'] + json_data2['custom_nodes']:
        all_urls.update(x['files'])

    for x in files:
        if x not in all_urls:
            return "high"

    return "middle"

The channel_url param value(https://github.com/ltdrdata/ComfyUI-Manager/raw/main/custom-node-list.json) is not correct.
It will be joined with filename(custom-node-list.json) in core.get_data_by_mode function and result a url like this:

https://github.com/ltdrdata/ComfyUI-Manager/raw/main/custom-node-list.json/custom-node-list.json

which is apprently wrong.

Originally created by @Maslino on GitHub (Aug 1, 2024). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/920 ```python async def get_risky_level(files): json_data1 = await core.get_data_by_mode('local', 'custom-node-list.json') json_data2 = await core.get_data_by_mode('cache', 'custom-node-list.json', channel_url='https://github.com/ltdrdata/ComfyUI-Manager/raw/main/custom-node-list.json') all_urls = set() for x in json_data1['custom_nodes'] + json_data2['custom_nodes']: all_urls.update(x['files']) for x in files: if x not in all_urls: return "high" return "middle" ``` The channel_url param value(https://github.com/ltdrdata/ComfyUI-Manager/raw/main/custom-node-list.json) is not correct. It will be joined with filename(custom-node-list.json) in core.get_data_by_mode function and result a url like this: https://github.com/ltdrdata/ComfyUI-Manager/raw/main/custom-node-list.json/custom-node-list.json which is apprently wrong.

bsakaguchi closed this issue

2026-10-27 21:17:08 +00:00

bsakaguchi commented

2026-10-27 21:17:09 +00:00

Author

Owner

@ltdrdata commented on GitHub (Aug 1, 2024):

This is patched.

@ltdrdata commented on GitHub (Aug 1, 2024): This is patched.

bsakaguchi referenced this issue

2026-10-27 21:30:02 +00:00

[PR #402] [MERGED] Fix typo author #1311