[GH-ISSUE #1301] Compatible release clause will bypass downgrade_blacklist #539

Closed
opened 2026-10-27 21:18:45 +00:00 by bsakaguchi · 5 comments
Owner

Originally created by @sko00o on GitHub (Dec 5, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/1301

I noticed some custom_nodes using ~= in requirements.txt .

It will make downgrade_blacklist not work.

How to reproduce this

  1. set diffusers in downgrade_blacklist
# ComfyUI/custom_nodes/ComfyUI-Manager/config.ini
[default]
# ...
downgrade_blacklist = diffusers
  1. install diffusers in venv
$ pip install diffusers==0.27.2
$ pip list | grep diffusers
diffusers                         0.27.2
  1. restart ComfyUI

  2. Install custom_nodes StableZero123-comfyui

The requirements.txt in this repo has this line diffusers~=0.21.4

  1. check diffusers version again
$ pip list | grep diffusers
diffusers                         0.21.4
Originally created by @sko00o on GitHub (Dec 5, 2024). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/1301 I noticed some custom_nodes using `~=` in requirements.txt . It will make downgrade_blacklist not work. ## How to reproduce this 1. set diffusers in downgrade_blacklist ```ini # ComfyUI/custom_nodes/ComfyUI-Manager/config.ini [default] # ... downgrade_blacklist = diffusers ``` 2. install diffusers in venv ``` $ pip install diffusers==0.27.2 $ pip list | grep diffusers diffusers 0.27.2 ``` 3. restart ComfyUI 4. Install custom_nodes [StableZero123-comfyui](https://github.com/deroberon/StableZero123-comfyui) The requirements.txt in this repo has this [line](https://github.com/deroberon/StableZero123-comfyui/blob/main/requirements.txt#L1) `diffusers~=0.21.4` 5. check diffusers version again ``` $ pip list | grep diffusers diffusers 0.21.4 ```
bsakaguchi 2026-10-27 21:18:45 +00:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@ltdrdata commented on GitHub (Dec 5, 2024):

I cannot reproduce that issue.
Is your ComfyUI up to date?

<!-- gh-comment-id:2521271969 --> @ltdrdata commented on GitHub (Dec 5, 2024): I cannot reproduce that issue. Is your ComfyUI up to date?
Author
Owner

@sko00o commented on GitHub (Dec 6, 2024):

Is your ComfyUI up to date?

Yes, I'm using the latest ComfyUI. And the issue is not related to ComfyUI.


Sorry for missing one step in bug reproduction. I should install a higher version diffusers in Step 2.
Considering the ComfyUI does not rely on diffusers. I simply use pip install to mock some custom nodes installation behavior.

For demonstration, I built a docker image with latest ComfyUI and ComfyUI-Manager installed. (https://github.com/sko00o/playground/tree/main/comfyui)

Open this repo in Github Codespace, and follow the steps:

# 1. launch comfyui and downgrade_blacklist will be set automatic
sudo bash comfyui/run.sh

# 2. install diffusers
pip install diffusers==0.27.2
pip list | grep diffusers
# diffusers                 0.27.2

# 3. open WebUI to install `StableZero123-comfyui` by ComfyUI-Manager

# 4. check diffusers version again
pip list | grep diffusers
# diffusers                 0.21.4
<!-- gh-comment-id:2522291715 --> @sko00o commented on GitHub (Dec 6, 2024): > Is your ComfyUI up to date? Yes, I'm using the latest ComfyUI. And the issue is not related to ComfyUI. --- Sorry for missing one step in bug reproduction. I should install a higher version diffusers in Step 2. Considering the ComfyUI does not rely on diffusers. I simply use `pip install` to mock some custom nodes installation behavior. For demonstration, I built a docker image with latest ComfyUI and ComfyUI-Manager installed. (https://github.com/sko00o/playground/tree/main/comfyui) Open this repo in [Github Codespace](https://github.com/codespaces/new?hide_repo_select=true&ref=main&repo=558393073), and follow the steps: ```sh # 1. launch comfyui and downgrade_blacklist will be set automatic sudo bash comfyui/run.sh # 2. install diffusers pip install diffusers==0.27.2 pip list | grep diffusers # diffusers 0.27.2 # 3. open WebUI to install `StableZero123-comfyui` by ComfyUI-Manager # 4. check diffusers version again pip list | grep diffusers # diffusers 0.21.4 ```
Author
Owner

@sko00o commented on GitHub (Dec 10, 2024):

PTAL @ltdrdata

<!-- gh-comment-id:2530096298 --> @sko00o commented on GitHub (Dec 10, 2024): PTAL @ltdrdata
Author
Owner

@ltdrdata commented on GitHub (Jan 11, 2025):

confirmed the issue.

<!-- gh-comment-id:2585321865 --> @ltdrdata commented on GitHub (Jan 11, 2025): confirmed the issue.
Author
Owner

@ltdrdata commented on GitHub (Jan 11, 2025):

This is fixed.

<!-- gh-comment-id:2585323203 --> @ltdrdata commented on GitHub (Jan 11, 2025): This is fixed.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#539
No description provided.