mirror of
https://github.com/Comfy-Org/ComfyUI-Manager.git
synced 2026-11-04 23:37:31 +00:00
[GH-ISSUE #1410] Local Custom Nodes without remotes cause "Update All" to fail #582
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/ComfyUI-Manager#582
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @drozbay on GitHub (Jan 7, 2025).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/1410
With the recent update my personal custom nodes that I have only local to my PC cause the entire Manager "Update All" process to fail because when it gets to my repo it can't find a remote (there is no remote). It stops when it gets to that local node repo and doesn't continue updating any other nodes.
Am I missing something like needing to set something up in my repo to indicate to the Manager that it shouldn't look for a remote? Otherwise, it seems like the Manager should allow for local Custom Nodes that aren't tied to Github but are initialized as local gits, it's very useful for local debugging and development.
This is the actual error:
@drozbay commented on GitHub (Jan 10, 2025):
Just wondering if this is intended behavior, so I can work around it, otherwise I can wait for a fix.
@ltdrdata commented on GitHub (Jan 10, 2025):
This issue is suspected to occur only with certain custom nodes after snapshot recovery. I’ll take a closer look when I get home.
@ltdrdata commented on GitHub (Jan 11, 2025):
This is fixed.
@drozbay commented on GitHub (Jan 11, 2025):
@ltdrdata Thank you for fixing this issue, I tested it and it is resolved.
I have another issue that may be related: Custom nodes that have a local branch that is not on the original repo will result in Update All failing.
Should I create a new issue or re-open this one and expand the scope?
@ltdrdata commented on GitHub (Jan 11, 2025):
I'll take a look.
@ltdrdata commented on GitHub (Jan 11, 2025):
I also have a local repo without a remote, but I don't encounter any issues when using "Update All."
Are you still experiencing this issue with the latest version?
If the issue still occurs, please upload logs that include the relevant case.
@drozbay commented on GitHub (Jan 12, 2025):
The issue with having a local repo without a remote is resolved, thank you again for doing that so quickly.
But I noticed another potential issues once I could continue using "Update All" that still result in
Failed to update ComfyUI or several extensions.In this case I have installed a custom node from the manager, but then I made my own branch "dev" in order to make a few local edits. In the past, the Manager has just ignored these custom nodes that I have branched, which was fine. In the current Manager I get this error during Update All:
@ltdrdata commented on GitHub (Jan 13, 2025):
This is fixed. Update to latest version and try again.
@drozbay commented on GitHub (Jan 15, 2025):
Thanks, the latest updates fixed these issues!