[GH-ISSUE #1410] Local Custom Nodes without remotes cause "Update All" to fail #582

Closed
opened 2026-10-27 21:19:23 +00:00 by bsakaguchi · 9 comments
Owner

Originally created by @drozbay on GitHub (Jan 7, 2025).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/1410

With the recent update my personal custom nodes that I have only local to my PC cause the entire Manager "Update All" process to fail because when it gets to my repo it can't find a remote (there is no remote). It stops when it gets to that local node repo and doesn't continue updating any other nodes.

Am I missing something like needing to set something up in my repo to indicate to the Manager that it shouldn't look for a remote? Otherwise, it seems like the Manager should allow for local Custom Nodes that aren't tied to Github but are initialized as local gits, it's very useful for local debugging and development.

This is the actual error:

  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1228, in repo_update
    remote = repo.remote(name=remote_name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\repo\base.py", line 460, in remote
    raise ValueError("Remote named '%s' didn't exist" % name)
ValueError: Remote named 'origin' didn't exist```
Originally created by @drozbay on GitHub (Jan 7, 2025). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/1410 With the recent update my personal custom nodes that I have only local to my PC cause the entire Manager "Update All" process to fail because when it gets to my repo it can't find a remote (there is no remote). It stops when it gets to that local node repo and doesn't continue updating any other nodes. Am I missing something like needing to set something up in my repo to indicate to the Manager that it shouldn't look for a remote? Otherwise, it seems like the Manager should allow for local Custom Nodes that aren't tied to Github but are initialized as local gits, it's very useful for local debugging and development. This is the actual error: ``` File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1228, in repo_update remote = repo.remote(name=remote_name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\repo\base.py", line 460, in remote raise ValueError("Remote named '%s' didn't exist" % name) ValueError: Remote named 'origin' didn't exist```
Author
Owner

@drozbay commented on GitHub (Jan 10, 2025):

Just wondering if this is intended behavior, so I can work around it, otherwise I can wait for a fix.

<!-- gh-comment-id:2581728559 --> @drozbay commented on GitHub (Jan 10, 2025): Just wondering if this is intended behavior, so I can work around it, otherwise I can wait for a fix.
Author
Owner

@ltdrdata commented on GitHub (Jan 10, 2025):

Just wondering if this is intended behavior, so I can work around it, otherwise I can wait for a fix.

This issue is suspected to occur only with certain custom nodes after snapshot recovery. I’ll take a closer look when I get home.

<!-- gh-comment-id:2582129227 --> @ltdrdata commented on GitHub (Jan 10, 2025): > Just wondering if this is intended behavior, so I can work around it, otherwise I can wait for a fix. This issue is suspected to occur only with certain custom nodes after snapshot recovery. I’ll take a closer look when I get home.
Author
Owner

@ltdrdata commented on GitHub (Jan 11, 2025):

This is fixed.

<!-- gh-comment-id:2584959565 --> @ltdrdata commented on GitHub (Jan 11, 2025): This is fixed.
Author
Owner

@drozbay commented on GitHub (Jan 11, 2025):

@ltdrdata Thank you for fixing this issue, I tested it and it is resolved.
I have another issue that may be related: Custom nodes that have a local branch that is not on the original repo will result in Update All failing.

Should I create a new issue or re-open this one and expand the scope?

<!-- gh-comment-id:2585046446 --> @drozbay commented on GitHub (Jan 11, 2025): @ltdrdata Thank you for fixing this issue, I tested it and it is resolved. I have another issue that may be related: Custom nodes that have a local branch that is not on the original repo will result in Update All failing. Should I create a new issue or re-open this one and expand the scope?
Author
Owner

@ltdrdata commented on GitHub (Jan 11, 2025):

I'll take a look.

<!-- gh-comment-id:2585134141 --> @ltdrdata commented on GitHub (Jan 11, 2025): I'll take a look.
Author
Owner

@ltdrdata commented on GitHub (Jan 11, 2025):

@ltdrdata Thank you for fixing this issue, I tested it and it is resolved. I have another issue that may be related: Custom nodes that have a local branch that is not on the original repo will result in Update All failing.

Should I create a new issue or re-open this one and expand the scope?

I also have a local repo without a remote, but I don't encounter any issues when using "Update All."
Are you still experiencing this issue with the latest version?

If the issue still occurs, please upload logs that include the relevant case.

<!-- gh-comment-id:2585320939 --> @ltdrdata commented on GitHub (Jan 11, 2025): > @ltdrdata Thank you for fixing this issue, I tested it and it is resolved. I have another issue that may be related: Custom nodes that have a local branch that is not on the original repo will result in Update All failing. > > Should I create a new issue or re-open this one and expand the scope? I also have a local repo without a remote, but I don't encounter any issues when using "Update All." Are you still experiencing this issue with the latest version? If the issue still occurs, please upload logs that include the relevant case.
Author
Owner

@drozbay commented on GitHub (Jan 12, 2025):

I also have a local repo without a remote, but I don't encounter any issues when using "Update All."

The issue with having a local repo without a remote is resolved, thank you again for doing that so quickly.

But I noticed another potential issues once I could continue using "Update All" that still result in Failed to update ComfyUI or several extensions.
In this case I have installed a custom node from the manager, but then I made my own branch "dev" in order to make a few local edits. In the past, the Manager has just ignored these custom nodes that I have branched, which was fine. In the current Manager I get this error during Update All:

Updating: ComfyUI-SmolVLM[ComfyUI-Manager] There is no tracking branch (dev)
Traceback (most recent call last):
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1209, in __getitem__
    return getattr(self, index)
           ^^^^^^^^^^^^^^^^^^^^
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1198, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'origin/dev'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_server.py", line 471, in update_all
    res = core.unified_manager.unified_update(k, v[0])
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1298, in unified_update
    return self.repo_update(self.unknown_active_nodes[node_id][1], instant_execution=instant_execution, no_deps=no_deps, return_postinstall=return_postinstall).with_target('unknown')
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1263, in repo_update
    remote_commit_hash = repo.refs[f'{remote_name}/{branch_name}'].object.hexsha
                         ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1211, in __getitem__
    raise IndexError("No item found with id %r" % (self._prefix + index)) from e
IndexError: No item found with id 'origin/dev'
<!-- gh-comment-id:2585550423 --> @drozbay commented on GitHub (Jan 12, 2025): > I also have a local repo without a remote, but I don't encounter any issues when using "Update All." The issue with having a local repo without a remote is resolved, thank you again for doing that so quickly. But I noticed another potential issues once I could continue using "Update All" that still result in `Failed to update ComfyUI or several extensions.` In this case I have installed a custom node from the manager, but then I made my own branch "dev" in order to make a few local edits. In the past, the Manager has just ignored these custom nodes that I have branched, which was fine. In the current Manager I get this error during Update All: ``` Updating: ComfyUI-SmolVLM[ComfyUI-Manager] There is no tracking branch (dev) Traceback (most recent call last): File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1209, in __getitem__ return getattr(self, index) ^^^^^^^^^^^^^^^^^^^^ File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1198, in __getattr__ return list.__getattribute__(self, attr) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'IterableList' object has no attribute 'origin/dev' The above exception was the direct cause of the following exception: Traceback (most recent call last): File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_server.py", line 471, in update_all res = core.unified_manager.unified_update(k, v[0]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1298, in unified_update return self.repo_update(self.unknown_active_nodes[node_id][1], instant_execution=instant_execution, no_deps=no_deps, return_postinstall=return_postinstall).with_target('unknown') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1263, in repo_update remote_commit_hash = repo.refs[f'{remote_name}/{branch_name}'].object.hexsha ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1211, in __getitem__ raise IndexError("No item found with id %r" % (self._prefix + index)) from e IndexError: No item found with id 'origin/dev' ```
Author
Owner

@ltdrdata commented on GitHub (Jan 13, 2025):

I also have a local repo without a remote, but I don't encounter any issues when using "Update All."

The issue with having a local repo without a remote is resolved, thank you again for doing that so quickly.

But I noticed another potential issues once I could continue using "Update All" that still result in Failed to update ComfyUI or several extensions. In this case I have installed a custom node from the manager, but then I made my own branch "dev" in order to make a few local edits. In the past, the Manager has just ignored these custom nodes that I have branched, which was fine. In the current Manager I get this error during Update All:

Updating: ComfyUI-SmolVLM[ComfyUI-Manager] There is no tracking branch (dev)
Traceback (most recent call last):
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1209, in __getitem__
    return getattr(self, index)
           ^^^^^^^^^^^^^^^^^^^^
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1198, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'origin/dev'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_server.py", line 471, in update_all
    res = core.unified_manager.unified_update(k, v[0])
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1298, in unified_update
    return self.repo_update(self.unknown_active_nodes[node_id][1], instant_execution=instant_execution, no_deps=no_deps, return_postinstall=return_postinstall).with_target('unknown')
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1263, in repo_update
    remote_commit_hash = repo.refs[f'{remote_name}/{branch_name}'].object.hexsha
                         ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1211, in __getitem__
    raise IndexError("No item found with id %r" % (self._prefix + index)) from e
IndexError: No item found with id 'origin/dev'

This is fixed. Update to latest version and try again.

<!-- gh-comment-id:2587491899 --> @ltdrdata commented on GitHub (Jan 13, 2025): > > I also have a local repo without a remote, but I don't encounter any issues when using "Update All." > > The issue with having a local repo without a remote is resolved, thank you again for doing that so quickly. > > But I noticed another potential issues once I could continue using "Update All" that still result in `Failed to update ComfyUI or several extensions.` In this case I have installed a custom node from the manager, but then I made my own branch "dev" in order to make a few local edits. In the past, the Manager has just ignored these custom nodes that I have branched, which was fine. In the current Manager I get this error during Update All: > > ``` > Updating: ComfyUI-SmolVLM[ComfyUI-Manager] There is no tracking branch (dev) > Traceback (most recent call last): > File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1209, in __getitem__ > return getattr(self, index) > ^^^^^^^^^^^^^^^^^^^^ > File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1198, in __getattr__ > return list.__getattribute__(self, attr) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > AttributeError: 'IterableList' object has no attribute 'origin/dev' > > The above exception was the direct cause of the following exception: > > Traceback (most recent call last): > File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_server.py", line 471, in update_all > res = core.unified_manager.unified_update(k, v[0]) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1298, in unified_update > return self.repo_update(self.unknown_active_nodes[node_id][1], instant_execution=instant_execution, no_deps=no_deps, return_postinstall=return_postinstall).with_target('unknown') > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "H:\AppsDir\git\ComfyBase\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_core.py", line 1263, in repo_update > remote_commit_hash = repo.refs[f'{remote_name}/{branch_name}'].object.hexsha > ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "h:\AppsDir\git\ComfyBase\python_embeded\Lib\site-packages\git\util.py", line 1211, in __getitem__ > raise IndexError("No item found with id %r" % (self._prefix + index)) from e > IndexError: No item found with id 'origin/dev' > ``` This is fixed. Update to latest version and try again.
Author
Owner

@drozbay commented on GitHub (Jan 15, 2025):

Thanks, the latest updates fixed these issues!

<!-- gh-comment-id:2594009006 --> @drozbay commented on GitHub (Jan 15, 2025): Thanks, the latest updates fixed these issues!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#582
No description provided.