mirror of
https://github.com/Comfy-Org/ComfyUI-Manager.git
synced 2026-11-05 07:47:25 +00:00
[GH-ISSUE #105] Duplicate model and 2 face_restore directories #61
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/ComfyUI-Manager#61
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coreyryanhanson on GitHub (Sep 12, 2023).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/105
I noticed in the model list there is one section for face_restore that defaults to a face_restore directory:
github.com/ltdrdata/ComfyUI-Manager@0d50544287/model-list.json (L93C1-L122C7)But also at the same time there appears to be a newer addition where models are saved to the face_restore_models directory:
github.com/ltdrdata/ComfyUI-Manager@0d50544287/model-list.json (L1137C5-L1176C7)Existing in both is GFPGANv1.4 (but implying a later release in the hyperlink on the second one)
Is there a reason to keep both sections unconsolidated or is the first face_restore output path planned to be deprecated?
@ltdrdata commented on GitHub (Sep 12, 2023):
Unfortunately, the problem lies in the fact that custom nodes require different paths.
face_restoreis the path used in theMTBnode, whilefacerestore_modelsis the path used in the later addedFacerestore CF (Code Former)node.Due to this reason, there are several duplicate items available for download for each path.
@coreyryanhanson commented on GitHub (Sep 12, 2023):
Makes sense. Hopefully in the future one of the paths will win out