[GH-ISSUE #2240] comfyui-manager should never upgrade torch, torchvision or torchaudio; numpy and opencv require complex logic #905

Open
opened 2026-10-27 21:23:49 +00:00 by bsakaguchi · 3 comments
Owner

Originally created by @doctorpangloss on GitHub (Oct 23, 2025).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/2240

torch

The overrides when using pip or uv should basically freeze the currently installed torch, torchvision, torchaudio

numpy

anything that requires jax will require numpy >= 2
the numpy 1.x issue is related to opencv

it is basically always safe to upgrade numpy except in containers like nvidia's, where the packages are built against numpy 1. this means you will want to freeze numpy depending on the environment, which is complex. you can enumerate all the packages in the venv and determine which one is required.

opencv

There are four opencv packages:

opencv-python
opencv-contrib-python
opencv-python-headless
opencv-contrib-python-headless

the controlnet aux package is radioactive in that it installs an opencv package that requires numpy 1.x even though it doesn't have metadata as such. So you must always use 4.12.0.88 or higher. If there is a currently installed non-headless opencv-python or opencv-contrib-python, you must get the path to the package (sometimes in dist-packages, not always in site-packages, due to packaging in images like Runpod), uninstall it, rm -rf the path, and then install the corresponding headless package. It's a completely stylistic choice whether or not to use the contrib packages, the most notable thing in them is tracking features.

all the opencv packages specified by nodes should be ignored, and the installation must always firs tuninstall all currently installed opencv, then install exactly opencv-contrib-python-headless or opencv-python-headless >= 4.12.0.88

transformers

It should be >=4.54, the whole 4.53 series should have been yanked

Originally created by @doctorpangloss on GitHub (Oct 23, 2025). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/2240 ##### `torch` The overrides when using `pip` or `uv` should basically freeze the currently installed torch, torchvision, torchaudio ##### `numpy` anything that requires jax will require numpy >= 2 the numpy 1.x issue is related to opencv it is basically always safe to upgrade numpy except in containers like nvidia's, where the packages are built against numpy 1. this means you will want to freeze numpy depending on the environment, which is complex. you can enumerate all the packages in the venv and determine which one is required. ##### `opencv` There are four opencv packages: ``` opencv-python opencv-contrib-python opencv-python-headless opencv-contrib-python-headless ``` the controlnet aux package is radioactive in that it installs an opencv package that requires numpy 1.x even though it doesn't have metadata as such. So you must always use `4.12.0.88` or higher. If there is a currently installed non-headless opencv-python or opencv-contrib-python, you must get the path to the package (sometimes in dist-packages, not always in site-packages, due to packaging in images like Runpod), uninstall it, rm -rf the path, and then install the corresponding headless package. It's a completely stylistic choice whether or not to use the contrib packages, the most notable thing in them is tracking features. all the opencv packages specified by nodes should be ignored, and the installation must always firs tuninstall all currently installed opencv, then install exactly opencv-contrib-python-headless or opencv-python-headless >= 4.12.0.88 ##### `transformers` It should be >=4.54, the whole 4.53 series should have been yanked
Author
Owner

@doctorpangloss commented on GitHub (Oct 23, 2025):

aiohttp must also be pinned to >=3.13

<!-- gh-comment-id:3439527719 --> @doctorpangloss commented on GitHub (Oct 23, 2025): aiohttp must also be pinned to >=3.13
Author
Owner

@doctorpangloss commented on GitHub (Oct 23, 2025):

onnxruntime-gpu>=1.23.0

<!-- gh-comment-id:3439529999 --> @doctorpangloss commented on GitHub (Oct 23, 2025): onnxruntime-gpu>=1.23.0
Author
Owner

@doctorpangloss commented on GitHub (Oct 23, 2025):

ultralytics>=8.3.206

it looks like a bunch of packages have been copying and pasting some particularly radioactive settings

<!-- gh-comment-id:3439533052 --> @doctorpangloss commented on GitHub (Oct 23, 2025): ultralytics>=8.3.206 it looks like a bunch of packages have been copying and pasting some particularly radioactive settings
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#905
No description provided.