Comfy-Org/ComfyUI-React-Extension-Template
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI-React-Extension-Template.git synced 2026-11-04 23:37:20 +00:00
Code Issues 5 Projects Packages Wiki Activity

[PR #6] [MERGED] Fix localization language selection: Use navigator for client-only config #9

New issue
Closed
opened 2026-10-26 22:08:28 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:08:28 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-React-Extension-Template/pull/6
Author: @christian-byrne
Created: 5/30/2025
Status: ✅ Merged
Merged: 5/30/2025
Merged by: @christian-byrne

Base: main ← Head: fix-locale-cascade

📝 Commits (1)

📊 Changes

1 file changed (+8 additions, -3 deletions)

View changed files

📝 ui/src/utils/i18n.ts (+8 -3)

📄 Description

Fixes issue in which translations are not applied despite having browser in separate language setting. Since we are a local client-only application, we should use the navigator language rather than the htmlTag or subdomain.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-React-Extension-Template/pull/6 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 5/30/2025 **Status:** ✅ Merged **Merged:** 5/30/2025 **Merged by:** [@christian-byrne](https://github.com/christian-byrne) **Base:** `main` ← **Head:** `fix-locale-cascade` --- ### 📝 Commits (1) - [`06468aa`](https://github.com/Comfy-Org/ComfyUI-React-Extension-Template/commit/06468aafcb94420a1952514c32756cad8b3a6843) fix locale cascade ### 📊 Changes **1 file changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/utils/i18n.ts` (+8 -3) </details> ### 📄 Description Fixes issue in which translations are not applied despite having browser in separate language setting. Since we are a local client-only application, we should use the navigator language rather than the htmlTag or subdomain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:08:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
assets-branch
No results found.
Labels
Clear labels   
help wanted

   
pull-request
Mirrored from GitHub Pull Request

No labels
help wanted
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-React-Extension-Template#9
No description provided.