Comfy-Org/ComfyUI-Standalone-Environments

Fork 0

mirror of https://github.com/Comfy-Org/ComfyUI-Standalone-Environments.git synced 2026-11-04 23:47:22 +00:00

[PR #11] [MERGED] Move AMD builds to ROCm 7.14 multi-arch wheels; add amd-multi-arch-index manifest kind #13

New issue

Closed

opened 2026-10-26 22:22:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:22:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/11
Author: @Kosinkadink
Created: 7/26/2026
Status: ✅ Merged
Merged: 7/27/2026
Merged by: @Kosinkadink

Base: main ← Head: feat/rocm-7.14-amd-builds

📝 Commits (2)

9e33b45 Move AMD builds to ROCm 7.14 multi-arch wheels; win-amd to Python 3.13
5716ea2 Add amd-multi-arch-index manifest kind for ROCm 7.14 switching

📊 Changes

6 files changed (+150 additions, -26 deletions)

View changed files

📝 .github/workflows/build-standalone-env.yml (+2 -2)
📝 requirements-amd-win.txt (+13 -10)
📝 requirements-amd.txt (+9 -7)
📝 scripts/test_torch_index_scripts.py (+67 -0)
📝 scripts/validate_torch_index_stacks.py (+27 -7)
📝 torch-index-stacks.json (+32 -0)

📄 Description

Bundle builds

requirements-amd.txt (Linux) and requirements-amd-win.txt (Windows) now install from AMD's TheRock multi-arch index (https://repo.amd.com/rocm/whl-multi-arch/): torch[device-all]==2.10.0+rocm7.14.0, torchvision[device-all]==0.25.0+rocm7.14.0, torchaudio==2.10.0+rocm7.14.0.
win-amd drops its Python 3.12 override and builds with the default Python 3.13.12 (the multi-arch index publishes cp310-cp314 wheels; the old 7.2.1 SDK channel was the only reason for the 3.12 pin).
RDNA-specific requirements files are untouched.

Torch manifest: new `amd-multi-arch-index` kind

Desktop's PyTorch picker gets a trusted mechanism for AMD's multi-arch index, which serves Windows AND Linux ROCm wheels (pytorch.org has no Windows ROCm builds):

Validator accepts kind: "amd-multi-arch-index" only for accel: "amd", stable tuples only; plain pytorch-index AMD entries stay Linux-only.
Validator now rejects unknown entry fields at authoring time, so no URL-shaped field can ride in through the manifest - the index URL stays a hardcoded constant in Desktop.
Manifest adds a rocm7.14.0 series note and two selectable stacks (torch 2.10.0 / 2.11.0 +rocm7.14.0; 2.12.0 omitted because the index has no matching torchaudio yet). Wheels verified for win_amd64 + linux_x86_64, cp310-cp314.
Old Desktop versions drop the unknown kind, so they can never misapply these entries; the matching install mechanism ships in Comfy-Org/Comfy-Desktop#1248.

Compatibility notes

Existing Windows AMD installs (Python 3.12) cannot graft new 3.13 bundles, but the multi-arch index publishes cp312 wheels, so they can switch PyTorch in place through the picker once Desktop #1248 lands.
Old Python 3.12 win-amd artifacts must be retained in R2 for repair/restore of existing installs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/11 **Author:** [@Kosinkadink](https://github.com/Kosinkadink) **Created:** 7/26/2026 **Status:** ✅ Merged **Merged:** 7/27/2026 **Merged by:** [@Kosinkadink](https://github.com/Kosinkadink) **Base:** `main` ← **Head:** `feat/rocm-7.14-amd-builds` --- ### 📝 Commits (2) - [`9e33b45`](https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/commit/9e33b45d36c78863cd187a11637090624bcf7130) Move AMD builds to ROCm 7.14 multi-arch wheels; win-amd to Python 3.13 - [`5716ea2`](https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/commit/5716ea2e18233d050d19fe112d6102b39eacd4c2) Add amd-multi-arch-index manifest kind for ROCm 7.14 switching ### 📊 Changes **6 files changed** (+150 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-standalone-env.yml` (+2 -2) 📝 `requirements-amd-win.txt` (+13 -10) 📝 `requirements-amd.txt` (+9 -7) 📝 `scripts/test_torch_index_scripts.py` (+67 -0) 📝 `scripts/validate_torch_index_stacks.py` (+27 -7) 📝 `torch-index-stacks.json` (+32 -0) </details> ### 📄 Description ## Bundle builds - `requirements-amd.txt` (Linux) and `requirements-amd-win.txt` (Windows) now install from AMD's TheRock multi-arch index (https://repo.amd.com/rocm/whl-multi-arch/): `torch[device-all]==2.10.0+rocm7.14.0`, `torchvision[device-all]==0.25.0+rocm7.14.0`, `torchaudio==2.10.0+rocm7.14.0`. - `win-amd` drops its Python 3.12 override and builds with the default Python 3.13.12 (the multi-arch index publishes cp310-cp314 wheels; the old 7.2.1 SDK channel was the only reason for the 3.12 pin). - RDNA-specific requirements files are untouched. ## Torch manifest: new `amd-multi-arch-index` kind Desktop's PyTorch picker gets a trusted mechanism for AMD's multi-arch index, which serves Windows AND Linux ROCm wheels (pytorch.org has no Windows ROCm builds): - Validator accepts `kind: "amd-multi-arch-index"` only for `accel: "amd"`, stable tuples only; plain `pytorch-index` AMD entries stay Linux-only. - Validator now rejects unknown entry fields at authoring time, so no URL-shaped field can ride in through the manifest - the index URL stays a hardcoded constant in Desktop. - Manifest adds a `rocm7.14.0` series note and two selectable stacks (torch 2.10.0 / 2.11.0 `+rocm7.14.0`; 2.12.0 omitted because the index has no matching torchaudio yet). Wheels verified for win_amd64 + linux_x86_64, cp310-cp314. - Old Desktop versions drop the unknown kind, so they can never misapply these entries; the matching install mechanism ships in Comfy-Org/Comfy-Desktop#1248. ## Compatibility notes - Existing Windows AMD installs (Python 3.12) cannot graft new 3.13 bundles, but the multi-arch index publishes cp312 wheels, so they can switch PyTorch in place through the picker once Desktop #1248 lands. - Old Python 3.12 `win-amd` artifacts must be retained in R2 for repair/restore of existing installs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:22:56 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-26 22:22:58 +00:00

[PR #13] [MERGED] ci: open a PR from the nightly refresh instead of pushing to protected main #16

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/ComfyUI-Standalone-Environments#13

No description provided.

Rows
Columns