[PR #7] [MERGED] 6 unable to read workflow in webp image previous commit works fine #8

Closed
opened 2026-10-26 22:00:50 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/pull/7
Author: @snomiao
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @snomiao

Base: main ← Head: 6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine


📝 Commits (10+)

  • 04c2e6e fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): disable telementry url
  • e32a9f2 fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): handle malformed format and add lot
  • e516909 Merge branch 'main' of github.com:Comfy-Org/ComfyUI-embedded-workflow-editor into 6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine
  • 6608801 fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): format
  • 2b2bc3d fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): remove unused fn
  • 92f988f fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): refactor
  • 7e0c5f0 fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): tidy fns
  • afb3c5c fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): tidy
  • 9e86a68 fix(app): allow onclick li
  • de6ee6d fix(workflows): prettier

📊 Changes

18 files changed (+1662 additions, -682 deletions)

View changed files

📝 .github/workflows/prettier.yml (+21 -21)
📝 app/page.tsx (+7 -5)
➕ app/utils/encodeTIFFBlock.ts (+0 -0)
➕ app/utils/exif-flac.ts (+71 -0)
➕ app/utils/exif-png.ts (+196 -0)
➕ app/utils/exif-webp.ts (+407 -0)
📝 app/utils/exif.ts (+3 -648)
➕ app/utils/utils.ts (+6 -0)
📝 bun.lockb (+0 -0)
➕ cache/config.json (+6 -0)
📝 package.json (+1 -0)
➕ tests/empty-workflow.webp (+0 -0)
📝 tests/exif-png.test.ts (+1 -1)
📝 tests/exif-webp.test.ts (+93 -7)
➕ tests/malformed/hunyuan3d-non-multiview-train.webp (+0 -0)
➕ tests/malformed/hunyuan3d-non-multiview-train.workflow.json (+360 -0)
➕ tests/malformed/robot.webp (+0 -0)
➕ tests/malformed/robot.workflow.json (+490 -0)

📄 Description

  • Handle malformed webp files
  • Keep all other original exifs
  • add more tests
  • manual tested with images from #6
  • tidy code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/pull/7 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine` --- ### 📝 Commits (10+) - [`04c2e6e`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/04c2e6e70121847cf7e0138898208de2bd0d9cbe) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): disable telementry url - [`e32a9f2`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/e32a9f2deef1795cbefdbe8a2961107377fb851a) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): handle malformed format and add lot - [`e516909`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/e516909a5c27eef72de42ed5d9a7ffee98dd4a5b) Merge branch 'main' of github.com:Comfy-Org/ComfyUI-embedded-workflow-editor into 6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine - [`6608801`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/6608801cbf05308701b294f9dd674c9328fb46f0) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): format - [`2b2bc3d`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/2b2bc3dca540b2e588b2f4a82c531a40cebfadb7) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): remove unused fn - [`92f988f`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/92f988f6b77f732fe2d8ff5ca20d89d20ed8abd8) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): refactor - [`7e0c5f0`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/7e0c5f0dbbb7b9839fdc943d2770ed8c682f6e51) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): tidy fns - [`afb3c5c`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/afb3c5c35b91b1e6e20eaa621d2f0c33ae883fb6) fix(6-unable-to-read-workflow-in-webp-image-previous-commit-works-fine): tidy - [`9e86a68`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/9e86a685751a3dbcfbdb86be5bc3428e53a1029e) fix(app): allow onclick li - [`de6ee6d`](https://github.com/Comfy-Org/ComfyUI-embedded-workflow-editor/commit/de6ee6dcbd809fc18efaa2b7ae3efaf55442a504) fix(workflows): prettier ### 📊 Changes **18 files changed** (+1662 additions, -682 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/prettier.yml` (+21 -21) 📝 `app/page.tsx` (+7 -5) ➕ `app/utils/encodeTIFFBlock.ts` (+0 -0) ➕ `app/utils/exif-flac.ts` (+71 -0) ➕ `app/utils/exif-png.ts` (+196 -0) ➕ `app/utils/exif-webp.ts` (+407 -0) 📝 `app/utils/exif.ts` (+3 -648) ➕ `app/utils/utils.ts` (+6 -0) 📝 `bun.lockb` (+0 -0) ➕ `cache/config.json` (+6 -0) 📝 `package.json` (+1 -0) ➕ `tests/empty-workflow.webp` (+0 -0) 📝 `tests/exif-png.test.ts` (+1 -1) 📝 `tests/exif-webp.test.ts` (+93 -7) ➕ `tests/malformed/hunyuan3d-non-multiview-train.webp` (+0 -0) ➕ `tests/malformed/hunyuan3d-non-multiview-train.workflow.json` (+360 -0) ➕ `tests/malformed/robot.webp` (+0 -0) ➕ `tests/malformed/robot.workflow.json` (+490 -0) </details> ### 📄 Description - [x] Handle malformed webp files - [x] Keep all other original exifs - [x] add more tests - [x] manual tested with images from #6 - [x] tidy code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:00:50 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-embedded-workflow-editor#8
No description provided.