From 08220d50d9502ec32bd76642641bedca82ca4968 Mon Sep 17 00:00:00 2001 From: Alexander Brown Date: Tue, 16 Sep 2025 22:03:41 -0700 Subject: [PATCH] Lint: Turn on rules that should allow for verbatimModuleSyntax (#5616) * lint: turn on type import rules setting up for verbatimModuleSyntax * lint: --fix for type imports --- eslint.config.ts | 2 ++ src/components/MenuHamburger.vue | 3 ++- src/components/actionbar/ComfyActionbar.vue | 3 ++- .../bottomPanel/tabs/terminal/BaseTerminal.vue | 3 ++- .../bottomPanel/tabs/terminal/CommandTerminal.vue | 5 +++-- .../bottomPanel/tabs/terminal/LogsTerminal.vue | 5 +++-- .../breadcrumb/SubgraphBreadcrumbItem.vue | 3 ++- src/components/common/ExtensionSlot.vue | 2 +- src/components/common/FormItem.vue | 2 +- src/components/common/RefreshButton.vue | 2 +- src/components/common/TreeExplorerTreeNode.spec.ts | 6 ++---- .../content/ManagerProgressDialogContent.test.ts | 3 ++- src/components/dialog/content/SignInContent.vue | 2 +- .../dialog/content/UpdatePasswordContent.vue | 3 ++- .../content/manager/ManagerDialogContent.vue | 2 +- .../content/manager/NodeConflictDialogContent.vue | 2 +- .../dialog/content/manager/PackStatusMessage.vue | 2 +- .../content/manager/PackVersionBadge.test.ts | 3 ++- .../manager/PackVersionSelectorPopover.test.ts | 3 ++- .../content/manager/PackVersionSelectorPopover.vue | 4 ++-- .../manager/button/PackEnableToggle.test.ts | 3 ++- .../content/manager/button/PackEnableToggle.vue | 2 +- .../content/manager/button/PackInstallButton.vue | 10 ++++------ .../content/manager/button/PackUninstallButton.vue | 4 ++-- .../dialog/content/manager/infoPanel/InfoPanel.vue | 2 +- .../content/manager/infoPanel/InfoPanelHeader.vue | 2 +- .../manager/infoPanel/InfoPanelMultiItem.vue | 2 +- .../dialog/content/manager/infoPanel/InfoTabs.vue | 2 +- .../infoPanel/tabs/DescriptionTabPanel.test.ts | 2 +- .../manager/infoPanel/tabs/DescriptionTabPanel.vue | 2 +- .../manager/infoPanel/tabs/NodesTabPanel.vue | 2 +- .../manager/infoPanel/tabs/WarningTabPanel.vue | 4 ++-- .../content/manager/packBanner/PackBanner.vue | 2 +- .../dialog/content/manager/packIcon/PackIcon.vue | 2 +- .../content/manager/packIcon/PackIconStacked.vue | 2 +- .../registrySearchBar/RegistrySearchBar.vue | 7 +++---- .../manager/skeleton/PackCardGridSkeleton.test.ts | 3 ++- .../dialog/content/setting/UsageLogsTable.vue | 2 +- .../content/setting/keybinding/KeyComboDisplay.vue | 2 +- .../dialog/content/signin/ApiKeyForm.vue | 3 ++- .../dialog/content/signin/SignInForm.spec.ts | 3 ++- .../dialog/content/signin/SignInForm.vue | 3 ++- .../dialog/content/signin/SignUpForm.vue | 3 ++- src/components/graph/modals/ZoomControlsModal.vue | 3 ++- .../graph/selectionToolbox/ColorPickerButton.vue | 3 ++- .../graph/selectionToolbox/DeleteButton.vue | 2 +- .../selectionToolbox/ExtensionCommandButton.vue | 3 ++- .../graph/selectionToolbox/SubmenuPopover.vue | 6 +++--- src/components/graph/widgets/ChatHistoryWidget.vue | 2 +- src/components/graph/widgets/DomWidget.vue | 5 +++-- src/components/graph/widgets/TextPreviewWidget.vue | 2 +- .../helpcenter/HelpCenterMenuContent.vue | 2 +- .../input/MultiSelect.accessibility.stories.ts | 2 +- src/components/input/MultiSelect.stories.ts | 2 +- src/components/input/MultiSelect.vue | 7 +++---- src/components/input/SingleSelect.vue | 5 +++-- src/components/install/MirrorsConfiguration.vue | 12 ++++++------ src/components/install/mirror/MirrorItem.vue | 2 +- src/components/load3d/Load3D.vue | 2 +- src/components/load3d/Load3DAnimation.vue | 2 +- src/components/load3d/Load3DAnimationScene.vue | 6 +++--- src/components/load3d/Load3DControls.vue | 2 +- src/components/load3d/Load3DScene.vue | 8 ++++---- src/components/load3d/Load3dViewerContent.vue | 2 +- src/components/load3d/controls/CameraControls.vue | 2 +- src/components/load3d/controls/ModelControls.vue | 5 ++++- .../load3d/controls/RecordingControls.vue | 2 +- src/components/load3d/controls/ViewerControls.vue | 2 +- .../controls/viewer/ViewerCameraControls.vue | 2 +- .../load3d/controls/viewer/ViewerModelControls.vue | 5 ++++- src/components/maintenance/TaskListItem.vue | 2 +- src/components/maintenance/TaskListStatusIcon.vue | 3 ++- .../maintenance/TerminalOutputDrawer.vue | 5 +++-- src/components/searchbox/NodeSearchBox.vue | 7 ++----- src/components/searchbox/NodeSearchBoxPopover.vue | 14 ++++++-------- src/components/searchbox/NodeSearchFilter.vue | 5 +++-- src/components/searchbox/NodeSearchItem.vue | 3 ++- .../sidebar/tabs/ModelLibrarySidebarTab.vue | 8 ++------ .../sidebar/tabs/NodeLibrarySidebarTab.vue | 10 ++++++---- src/components/sidebar/tabs/QueueSidebarTab.vue | 9 +++------ .../sidebar/tabs/WorkflowsSidebarTab.vue | 2 +- .../sidebar/tabs/modelLibrary/ModelTreeLeaf.vue | 14 ++++---------- .../tabs/nodeLibrary/NodeBookmarkTreeExplorer.vue | 2 +- .../sidebar/tabs/nodeLibrary/NodeTreeFolder.vue | 2 +- .../sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue | 14 ++++---------- src/components/sidebar/tabs/queue/ResultAudio.vue | 2 +- .../sidebar/tabs/queue/ResultGallery.vue | 2 +- src/components/sidebar/tabs/queue/ResultItem.vue | 2 +- src/components/sidebar/tabs/queue/ResultVideo.vue | 2 +- src/components/sidebar/tabs/queue/TaskItem.vue | 2 +- .../sidebar/tabs/workflows/WorkflowTreeLeaf.vue | 6 ++---- .../templates/TemplateWorkflowCard.spec.ts | 2 +- src/components/templates/TemplateWorkflowCard.vue | 2 +- .../templates/TemplateWorkflowView.spec.ts | 2 +- src/components/topbar/CurrentUserButton.spec.ts | 3 ++- src/components/topbar/CurrentUserPopover.spec.ts | 3 ++- src/components/topbar/WorkflowTab.vue | 2 +- src/components/topbar/WorkflowTabs.vue | 6 ++---- src/components/widget/SampleModelSelector.vue | 2 +- src/components/widget/nav/NavIcon.vue | 2 +- src/components/widget/nav/NavItem.vue | 2 +- src/components/widget/panel/LeftSidePanel.vue | 2 +- .../bottomPanelTabs/useCommandSubcategories.ts | 2 +- src/composables/bottomPanelTabs/useShortcutsTab.ts | 2 +- src/composables/bottomPanelTabs/useTerminal.ts | 3 ++- src/composables/bottomPanelTabs/useTerminalTabs.ts | 2 +- src/composables/canvas/useCanvasTransformSync.ts | 2 +- .../canvas/useSelectedLiteGraphItems.ts | 8 ++------ src/composables/element/useAbsolutePosition.ts | 3 ++- src/composables/element/useDomClipping.ts | 3 ++- src/composables/graph/useMoreOptionsMenu.ts | 2 +- src/composables/graph/useSelectionState.ts | 7 ++----- .../manager/useManagerStatePersistence.ts | 7 ++----- src/composables/node/useNodeBadge.ts | 3 ++- src/composables/node/useNodeChatHistory.ts | 2 +- src/composables/node/useNodeProgressText.ts | 2 +- src/composables/nodePack/useInstalledPacks.ts | 2 +- src/composables/nodePack/useMissingNodes.ts | 4 ++-- src/composables/nodePack/useNodePacks.ts | 4 ++-- src/composables/nodePack/useWorkflowPacks.ts | 6 +++--- src/composables/useCanvasDrop.ts | 8 ++++---- src/composables/useCoreCommands.ts | 2 +- src/composables/useLoad3dViewer.ts | 4 ++-- src/composables/useManagerQueue.ts | 5 +++-- src/composables/usePaste.ts | 2 +- src/composables/useServerLogs.ts | 4 ++-- src/composables/useTreeExpansion.ts | 2 +- src/config/firebase.ts | 2 +- src/constants/serverConfig.ts | 2 +- src/lib/litegraph/src/CurveEditor.ts | 2 +- src/lib/litegraph/src/LGraphCanvas.ts | 6 +++--- src/lib/litegraph/src/interfaces.ts | 2 +- .../litegraph/src/subgraph/EmptySubgraphInput.ts | 2 +- .../litegraph/src/subgraph/EmptySubgraphOutput.ts | 2 +- .../litegraph/src/subgraph/ExecutableNodeDTO.ts | 2 +- src/lib/litegraph/src/subgraph/SubgraphNode.ts | 12 ++++++------ .../litegraph/test/LGraphNode.titleButtons.test.ts | 2 +- .../test/LinkConnector.integration.test.ts | 3 +-- src/lib/litegraph/test/NodeSlot.test.ts | 5 ++++- .../LinkConnectorSubgraphInputValidation.test.ts | 2 +- .../test/subgraph/SubgraphConversion.test.ts | 3 +-- .../test/subgraph/SubgraphNode.titleButton.test.ts | 2 +- .../test/subgraph/SubgraphSlotConnections.test.ts | 4 ++-- .../test/subgraph/SubgraphWidgetPromotion.test.ts | 3 ++- .../test/subgraph/fixtures/subgraphFixtures.ts | 5 +++-- .../settings/components/SettingDialogContent.vue | 4 ++-- src/platform/settings/components/SettingGroup.vue | 2 +- src/platform/settings/components/SettingsPanel.vue | 2 +- .../settings/composables/useSettingSearch.ts | 4 ++-- src/platform/settings/composables/useSettingUI.ts | 6 ++---- src/platform/updates/common/releaseService.ts | 3 ++- .../workflow/core/services/workflowService.ts | 2 +- .../workflow/management/stores/workflowStore.ts | 2 +- .../core/canvas/litegraph/litegraphLinkAdapter.ts | 2 +- .../core/layout/operations/layoutMutations.ts | 14 +++++++------- src/renderer/core/layout/sync/useSlotLayoutSync.ts | 5 +++-- .../core/layout/transform/TransformPane.vue | 2 +- .../core/thumbnail/useWorkflowThumbnail.ts | 2 +- .../extensions/minimap/minimapCanvasRenderer.ts | 3 ++- .../extensions/vueNodes/components/InputSlot.vue | 2 +- .../extensions/vueNodes/components/LGraphNode.vue | 2 +- .../widgets/components/WidgetInputNumber.vue | 2 +- .../widgets/components/WidgetInputNumberInput.vue | 2 +- .../components/layout/WidgetLayoutField.vue | 2 +- .../widgets/composables/useBooleanWidget.ts | 2 +- .../vueNodes/widgets/composables/useComboWidget.ts | 2 +- .../vueNodes/widgets/composables/useFloatWidget.ts | 2 +- .../widgets/composables/useImagePreviewWidget.ts | 2 +- .../widgets/composables/useImageUploadWidget.ts | 2 +- .../widgets/composables/useMarkdownWidget.ts | 4 ++-- .../widgets/composables/useRemoteWidget.ts | 4 ++-- .../widgets/composables/useStringWidget.ts | 2 +- src/router.ts | 3 +-- src/schemas/nodeDef/migration.ts | 8 +++++--- src/services/colorPaletteService.ts | 7 ++----- src/services/comfyManagerService.ts | 5 +++-- src/services/comfyRegistryService.ts | 3 ++- src/services/customerEventsService.ts | 6 ++++-- src/services/dialogService.ts | 2 +- src/services/load3dService.ts | 2 +- src/services/nodeOrganizationService.ts | 3 ++- src/services/nodeSearchService.ts | 7 ++++--- src/services/subgraphService.ts | 8 ++++---- src/stores/aboutPanelStore.ts | 2 +- src/stores/apiKeyAuthStore.ts | 4 ++-- src/stores/comfyManagerStore.ts | 4 ++-- src/stores/executionStore.ts | 6 ++---- src/stores/firebaseAuthStore.ts | 4 ++-- src/stores/imagePreviewStore.ts | 9 +++------ src/stores/keybindingStore.ts | 5 +++-- src/stores/menuItemStore.ts | 2 +- src/stores/modelToNodeStore.ts | 3 ++- src/stores/nodeBookmarkStore.ts | 3 ++- src/stores/serverConfigStore.ts | 2 +- src/stores/subgraphStore.ts | 4 ++-- src/stores/userFileStore.ts | 4 ++-- src/stores/widgetStore.ts | 3 ++- src/stores/workspace/bottomPanelStore.ts | 2 +- src/stores/workspace/sidebarTabStore.ts | 2 +- src/types/algoliasearch-lite.d.ts | 5 ++++- src/types/comfy.ts | 2 +- src/types/extensionTypes.ts | 2 +- src/types/index.ts | 2 +- src/types/widgetTypes.ts | 2 +- src/utils/envUtil.ts | 2 +- src/utils/formatUtil.ts | 2 +- src/utils/fuseUtil.ts | 3 ++- src/utils/litegraphUtil.ts | 3 ++- src/utils/mapperUtil.ts | 6 +++--- src/utils/nodeDefOrderingUtil.ts | 2 +- src/utils/typeGuardUtil.ts | 9 +++------ src/views/GraphView.vue | 2 +- src/views/MaintenanceView.vue | 2 +- src/views/ServerStartView.vue | 5 +++-- src/views/UserSelectView.vue | 3 ++- 215 files changed, 390 insertions(+), 381 deletions(-) diff --git a/eslint.config.ts b/eslint.config.ts index 191e07ba9..b92d6bbf7 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -75,6 +75,8 @@ export default defineConfig([ '@typescript-eslint/no-explicit-any': 'off', '@typescript-eslint/no-unused-vars': 'off', '@typescript-eslint/prefer-as-const': 'off', + '@typescript-eslint/consistent-type-imports': 'error', + '@typescript-eslint/no-import-type-side-effects': 'error', 'unused-imports/no-unused-imports': 'error', 'vue/no-v-html': 'off', // Enforce dark-theme: instead of dark: prefix diff --git a/src/components/MenuHamburger.vue b/src/components/MenuHamburger.vue index b46c27e27..d0856362f 100644 --- a/src/components/MenuHamburger.vue +++ b/src/components/MenuHamburger.vue @@ -21,7 +21,8 @@