From 0c6eeb063248082aa54b48ae9cd2453d47bd3600 Mon Sep 17 00:00:00 2001 From: bymyself Date: Sun, 14 Sep 2025 19:41:01 -0700 Subject: [PATCH] [perf] Fix Float32Array test assertions and link adapter Fix the remaining Float32Array usage that was causing test failures: - Update test assertions to expect regular arrays instead of Float32Array - Convert link adapter Float32Array creation to regular arrays Resolves: AssertionError: expected [ 50, 60 ] to deeply equal Float32Array[ 50, 60 ] --- src/lib/litegraph/test/LGraphNode.test.ts | 4 ++-- src/renderer/core/canvas/litegraph/litegraphLinkAdapter.ts | 2 +- tests-ui/tests/litegraph/core/LGraphNode.test.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/litegraph/test/LGraphNode.test.ts b/src/lib/litegraph/test/LGraphNode.test.ts index ed7d15329..ea9b880ea 100644 --- a/src/lib/litegraph/test/LGraphNode.test.ts +++ b/src/lib/litegraph/test/LGraphNode.test.ts @@ -84,8 +84,8 @@ describe('LGraphNode', () => { })) } node.configure(configureData) - expect(node.pos).toEqual(new Float32Array([50, 60])) - expect(node.size).toEqual(new Float32Array([70, 80])) + expect(node.pos).toEqual([50, 60]) + expect(node.size).toEqual([70, 80]) }) test('should configure inputs correctly', () => { diff --git a/src/renderer/core/canvas/litegraph/litegraphLinkAdapter.ts b/src/renderer/core/canvas/litegraph/litegraphLinkAdapter.ts index 1bb3f7dae..49c0feec9 100644 --- a/src/renderer/core/canvas/litegraph/litegraphLinkAdapter.ts +++ b/src/renderer/core/canvas/litegraph/litegraphLinkAdapter.ts @@ -449,7 +449,7 @@ export class LitegraphLinkAdapter { // Copy calculated center position back to litegraph object // This is needed for hit detection and menu interaction if (linkData.centerPos) { - linkSegment._pos = linkSegment._pos || new Float32Array(2) + linkSegment._pos = linkSegment._pos || [0, 0] linkSegment._pos[0] = linkData.centerPos.x linkSegment._pos[1] = linkData.centerPos.y diff --git a/tests-ui/tests/litegraph/core/LGraphNode.test.ts b/tests-ui/tests/litegraph/core/LGraphNode.test.ts index 3eb38215f..ec7f398b2 100644 --- a/tests-ui/tests/litegraph/core/LGraphNode.test.ts +++ b/tests-ui/tests/litegraph/core/LGraphNode.test.ts @@ -84,8 +84,8 @@ describe('LGraphNode', () => { })) } node.configure(configureData) - expect(node.pos).toEqual(new Float32Array([50, 60])) - expect(node.size).toEqual(new Float32Array([70, 80])) + expect(node.pos).toEqual([50, 60]) + expect(node.size).toEqual([70, 80]) }) test('should configure inputs correctly', () => {