mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-14 01:20:03 +00:00
chore: migrate tests from tests-ui/ to colocate with source files (#7811)
## Summary Migrates all unit tests from `tests-ui/` to colocate with their source files in `src/`, improving discoverability and maintainability. ## Changes - **What**: Relocated all unit tests to be adjacent to the code they test, following the `<source>.test.ts` naming convention - **Config**: Updated `vitest.config.ts` to remove `tests-ui` include pattern and `@tests-ui` alias - **Docs**: Moved testing documentation to `docs/testing/` with updated paths and patterns ## Review Focus - Migration patterns documented in `temp/plans/migrate-tests-ui-to-src.md` - Tests use `@/` path aliases instead of relative imports - Shared fixtures placed in `__fixtures__/` directories ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7811-chore-migrate-tests-from-tests-ui-to-colocate-with-source-files-2da6d73d36508147a4cce85365dee614) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
Alexander Brown
287
src/stores/serverConfigStore.test.ts
Normal file
287
src/stores/serverConfigStore.test.ts
Normal file
@@ -0,0 +1,287 @@
|
||||
import { createPinia, setActivePinia } from 'pinia'
|
||||
import { beforeEach, describe, expect, it } from 'vitest'
|
||||
|
||||
import type { ServerConfig } from '@/constants/serverConfig'
|
||||
import type { FormItem } from '@/platform/settings/types'
|
||||
import { useServerConfigStore } from '@/stores/serverConfigStore'
|
||||
|
||||
const dummyFormItem: FormItem = {
|
||||
name: '',
|
||||
type: 'text'
|
||||
}
|
||||
|
||||
describe('useServerConfigStore', () => {
|
||||
let store: ReturnType<typeof useServerConfigStore>
|
||||
|
||||
beforeEach(() => {
|
||||
setActivePinia(createPinia())
|
||||
store = useServerConfigStore()
|
||||
})
|
||||
|
||||
it('should initialize with empty configs', () => {
|
||||
expect(store.serverConfigs).toHaveLength(0)
|
||||
expect(Object.keys(store.serverConfigById)).toHaveLength(0)
|
||||
expect(Object.keys(store.serverConfigsByCategory)).toHaveLength(0)
|
||||
expect(Object.keys(store.serverConfigValues)).toHaveLength(0)
|
||||
expect(Object.keys(store.launchArgs)).toHaveLength(0)
|
||||
})
|
||||
|
||||
it('should load server configs with default values', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1',
|
||||
category: ['Test']
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config2',
|
||||
defaultValue: 'default2'
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {})
|
||||
|
||||
expect(store.serverConfigs).toHaveLength(2)
|
||||
expect(store.serverConfigById['test.config1'].value).toBe('default1')
|
||||
expect(store.serverConfigById['test.config2'].value).toBe('default2')
|
||||
})
|
||||
|
||||
it('should load server configs with provided values', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1',
|
||||
category: ['Test']
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {
|
||||
'test.config1': 'custom1'
|
||||
})
|
||||
|
||||
expect(store.serverConfigs).toHaveLength(1)
|
||||
expect(store.serverConfigById['test.config1'].value).toBe('custom1')
|
||||
})
|
||||
|
||||
it('should organize configs by category', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1',
|
||||
category: ['Test']
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config2',
|
||||
defaultValue: 'default2',
|
||||
category: ['Other']
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config3',
|
||||
defaultValue: 'default3'
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {})
|
||||
|
||||
expect(Object.keys(store.serverConfigsByCategory)).toHaveLength(3)
|
||||
expect(store.serverConfigsByCategory['Test']).toHaveLength(1)
|
||||
expect(store.serverConfigsByCategory['Other']).toHaveLength(1)
|
||||
expect(store.serverConfigsByCategory['General']).toHaveLength(1)
|
||||
})
|
||||
|
||||
it('should generate server config values excluding defaults', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1'
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config2',
|
||||
defaultValue: 'default2'
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {
|
||||
'test.config1': 'custom1',
|
||||
'test.config2': 'default2'
|
||||
})
|
||||
|
||||
expect(Object.keys(store.serverConfigValues)).toHaveLength(2)
|
||||
expect(store.serverConfigValues['test.config1']).toBe('custom1')
|
||||
expect(store.serverConfigValues['test.config2']).toBeUndefined()
|
||||
})
|
||||
|
||||
it('should generate launch arguments with custom getValue function', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1',
|
||||
getValue: (value: string) => ({ customArg: value })
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config2',
|
||||
defaultValue: 'default2'
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {
|
||||
'test.config1': 'custom1',
|
||||
'test.config2': 'custom2'
|
||||
})
|
||||
|
||||
expect(Object.keys(store.launchArgs)).toHaveLength(2)
|
||||
expect(store.launchArgs['customArg']).toBe('custom1')
|
||||
expect(store.launchArgs['test.config2']).toBe('custom2')
|
||||
})
|
||||
|
||||
it('should not include default values in launch arguments', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1'
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config2',
|
||||
defaultValue: 'default2'
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {
|
||||
'test.config1': 'custom1',
|
||||
'test.config2': 'default2'
|
||||
})
|
||||
|
||||
expect(Object.keys(store.launchArgs)).toHaveLength(1)
|
||||
expect(store.launchArgs['test.config1']).toBe('custom1')
|
||||
expect(store.launchArgs['test.config2']).toBeUndefined()
|
||||
})
|
||||
|
||||
it('should not include nullish values in launch arguments', () => {
|
||||
const configs: ServerConfig<any>[] = [
|
||||
{ ...dummyFormItem, id: 'test.config1', defaultValue: 'default1' },
|
||||
{ ...dummyFormItem, id: 'test.config2', defaultValue: 'default2' },
|
||||
{ ...dummyFormItem, id: 'test.config3', defaultValue: 'default3' },
|
||||
{ ...dummyFormItem, id: 'test.config4', defaultValue: null }
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {
|
||||
'test.config1': undefined,
|
||||
'test.config2': null,
|
||||
'test.config3': '',
|
||||
'test.config4': 0
|
||||
})
|
||||
|
||||
expect(Object.keys(store.launchArgs)).toEqual([
|
||||
'test.config3',
|
||||
'test.config4'
|
||||
])
|
||||
expect(Object.values(store.launchArgs)).toEqual(['', '0'])
|
||||
expect(store.serverConfigById['test.config3'].value).toBe('')
|
||||
expect(store.serverConfigById['test.config4'].value).toBe(0)
|
||||
expect(Object.values(store.serverConfigValues)).toEqual([
|
||||
undefined,
|
||||
undefined,
|
||||
'',
|
||||
0
|
||||
])
|
||||
})
|
||||
|
||||
it('should convert true to empty string in launch arguments', () => {
|
||||
store.loadServerConfig(
|
||||
[
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 0
|
||||
}
|
||||
],
|
||||
{
|
||||
'test.config1': true
|
||||
}
|
||||
)
|
||||
expect(store.launchArgs['test.config1']).toBe('')
|
||||
expect(store.commandLineArgs).toBe('--test.config1')
|
||||
})
|
||||
|
||||
it('should convert number to string in launch arguments', () => {
|
||||
store.loadServerConfig(
|
||||
[
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 1
|
||||
}
|
||||
],
|
||||
{
|
||||
'test.config1': 123
|
||||
}
|
||||
)
|
||||
expect(store.launchArgs['test.config1']).toBe('123')
|
||||
expect(store.commandLineArgs).toBe('--test.config1 123')
|
||||
})
|
||||
|
||||
it('should drop nullish values in launch arguments', () => {
|
||||
store.loadServerConfig(
|
||||
[
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 1
|
||||
}
|
||||
],
|
||||
{
|
||||
'test.config1': null
|
||||
}
|
||||
)
|
||||
expect(Object.keys(store.launchArgs)).toHaveLength(0)
|
||||
})
|
||||
|
||||
it('should track modified configs', () => {
|
||||
const configs = [
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config1',
|
||||
defaultValue: 'default1'
|
||||
},
|
||||
{
|
||||
...dummyFormItem,
|
||||
id: 'test.config2',
|
||||
defaultValue: 'default2'
|
||||
}
|
||||
]
|
||||
|
||||
store.loadServerConfig(configs, {
|
||||
'test.config1': 'initial1'
|
||||
})
|
||||
|
||||
// Initially no modified configs
|
||||
expect(store.modifiedConfigs).toHaveLength(0)
|
||||
|
||||
// Modify config1's value after loading
|
||||
store.serverConfigById['test.config1'].value = 'custom1'
|
||||
|
||||
// Now config1 should be in modified configs
|
||||
expect(store.modifiedConfigs).toHaveLength(1)
|
||||
expect(store.modifiedConfigs[0].id).toBe('test.config1')
|
||||
expect(store.modifiedConfigs[0].value).toBe('custom1')
|
||||
expect(store.modifiedConfigs[0].initialValue).toBe('initial1')
|
||||
|
||||
// Change config1 back to default
|
||||
store.serverConfigById['test.config1'].value = 'initial1'
|
||||
|
||||
// Should go back to no modified configs
|
||||
expect(store.modifiedConfigs).toHaveLength(0)
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user