mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-25 16:59:45 +00:00
chore: migrate tests from tests-ui/ to colocate with source files (#7811)
## Summary Migrates all unit tests from `tests-ui/` to colocate with their source files in `src/`, improving discoverability and maintainability. ## Changes - **What**: Relocated all unit tests to be adjacent to the code they test, following the `<source>.test.ts` naming convention - **Config**: Updated `vitest.config.ts` to remove `tests-ui` include pattern and `@tests-ui` alias - **Docs**: Moved testing documentation to `docs/testing/` with updated paths and patterns ## Review Focus - Migration patterns documented in `temp/plans/migrate-tests-ui-to-src.md` - Tests use `@/` path aliases instead of relative imports - Shared fixtures placed in `__fixtures__/` directories ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7811-chore-migrate-tests-from-tests-ui-to-colocate-with-source-files-2da6d73d36508147a4cce85365dee614) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
Alexander Brown
@@ -1,248 +0,0 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
|
||||
import { getSelectedModelsMetadata } from '@/workbench/utils/modelMetadataUtil'
|
||||
|
||||
describe('modelMetadataUtil', () => {
|
||||
describe('filterModelsByCurrentSelection', () => {
|
||||
it('should filter models to only include those selected in widget values', () => {
|
||||
const node = {
|
||||
type: 'CheckpointLoaderSimple',
|
||||
widgets_values: ['model_a.safetensors'],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
},
|
||||
{
|
||||
name: 'model_b.safetensors',
|
||||
url: 'https://example.com/model_b.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result![0].name).toBe('model_a.safetensors')
|
||||
})
|
||||
|
||||
it('should return empty array when no models match selection', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: ['unmatched_model.safetensors'],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(0)
|
||||
})
|
||||
|
||||
it('should handle multiple widget values', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: ['model_a.safetensors', 42, 'model_c.ckpt'],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
},
|
||||
{
|
||||
name: 'model_b.safetensors',
|
||||
url: 'https://example.com/model_b.safetensors',
|
||||
directory: 'checkpoints'
|
||||
},
|
||||
{
|
||||
name: 'model_c.ckpt',
|
||||
url: 'https://example.com/model_c.ckpt',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(2)
|
||||
expect(result!.map((m) => m.name)).toEqual([
|
||||
'model_a.safetensors',
|
||||
'model_c.ckpt'
|
||||
])
|
||||
})
|
||||
|
||||
it('should ignore non-string widget values', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: [42, true, null, undefined, 'model_a.safetensors'],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result![0].name).toBe('model_a.safetensors')
|
||||
})
|
||||
|
||||
it('should ignore empty strings', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: ['', ' ', 'model_a.safetensors'],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result![0].name).toBe('model_a.safetensors')
|
||||
})
|
||||
|
||||
it('should return undefined for nodes without model metadata', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: ['model_a.safetensors']
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toBeUndefined()
|
||||
})
|
||||
|
||||
it('should return undefined for nodes without widgets_values', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toBeUndefined()
|
||||
})
|
||||
|
||||
it('should return undefined for nodes with empty widgets_values', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: [],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toBeUndefined()
|
||||
})
|
||||
|
||||
it('should return undefined for nodes with empty models array', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: ['model_a.safetensors'],
|
||||
properties: {
|
||||
models: []
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toBeUndefined()
|
||||
})
|
||||
|
||||
it('should handle object widget values', () => {
|
||||
const node = {
|
||||
type: 'SomeNode',
|
||||
widgets_values: {
|
||||
ckpt_name: 'model_a.safetensors',
|
||||
seed: 42
|
||||
},
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'model_a.safetensors',
|
||||
url: 'https://example.com/model_a.safetensors',
|
||||
directory: 'checkpoints'
|
||||
},
|
||||
{
|
||||
name: 'model_b.safetensors',
|
||||
url: 'https://example.com/model_b.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result![0].name).toBe('model_a.safetensors')
|
||||
})
|
||||
|
||||
it('should work end-to-end to filter outdated metadata', () => {
|
||||
const node = {
|
||||
type: 'CheckpointLoaderSimple',
|
||||
widgets_values: ['current_model.safetensors'],
|
||||
properties: {
|
||||
models: [
|
||||
{
|
||||
name: 'current_model.safetensors',
|
||||
url: 'https://example.com/current_model.safetensors',
|
||||
directory: 'checkpoints'
|
||||
},
|
||||
{
|
||||
name: 'old_model.safetensors',
|
||||
url: 'https://example.com/old_model.safetensors',
|
||||
directory: 'checkpoints'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
const result = getSelectedModelsMetadata(node)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result![0].name).toBe('current_model.safetensors')
|
||||
})
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user