From 292013b6cf699dd85b6c66d6b3d51a2e66a60d03 Mon Sep 17 00:00:00 2001 From: PM <65325+j2l@users.noreply.github.com> Date: Tue, 6 Apr 2021 15:20:43 +0200 Subject: [PATCH 1/4] data_store to events menu I guess events.js manages events menu and not basic one :) If I'm wrong, please let me know with a quick explanation and drop it. --- src/nodes/events.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nodes/events.js b/src/nodes/events.js index 943ce2b5a..3938b6a4f 100644 --- a/src/nodes/events.js +++ b/src/nodes/events.js @@ -353,5 +353,5 @@ o.data = null; } - LiteGraph.registerNodeType("basic/data_store", DataStore); + LiteGraph.registerNodeType("events/data_store", DataStore); })(this); From 039ad19372701f603565752f399b384d64639855 Mon Sep 17 00:00:00 2001 From: PM <65325+j2l@users.noreply.github.com> Date: Tue, 6 Apr 2021 15:52:38 +0200 Subject: [PATCH 2/4] Added an output to Converter I hope I didn't misunderstood the converter node, it needs an output right? --- src/nodes/math.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nodes/math.js b/src/nodes/math.js index 601d8beba..93a4b9053 100755 --- a/src/nodes/math.js +++ b/src/nodes/math.js @@ -4,6 +4,7 @@ //Converter function Converter() { this.addInput("in", "*"); + this.addOutput("out"); this.size = [80, 30]; } From 980baed1eb36883813e8887955b36bf28632b4fe Mon Sep 17 00:00:00 2001 From: PM <65325+j2l@users.noreply.github.com> Date: Tue, 6 Apr 2021 15:56:06 +0200 Subject: [PATCH 3/4] back to basic --- src/nodes/events.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nodes/events.js b/src/nodes/events.js index 3938b6a4f..943ce2b5a 100644 --- a/src/nodes/events.js +++ b/src/nodes/events.js @@ -353,5 +353,5 @@ o.data = null; } - LiteGraph.registerNodeType("events/data_store", DataStore); + LiteGraph.registerNodeType("basic/data_store", DataStore); })(this); From 75bf1367979cb6098aeb458c1673e6362cfc60f0 Mon Sep 17 00:00:00 2001 From: kdb621 Date: Thu, 20 May 2021 13:26:58 +0900 Subject: [PATCH 4/4] Fix Boundary and collapsed issue * If you collapse a node with a widget after loading the graph, it cannot be expanded. * Compute Collapsed Nodes boundary is incorrect --- src/litegraph.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/litegraph.js b/src/litegraph.js index 47e002625..13b08fdae 100755 --- a/src/litegraph.js +++ b/src/litegraph.js @@ -3499,7 +3499,7 @@ out[0] = this.pos[0] - 4; out[1] = this.pos[1] - LiteGraph.NODE_TITLE_HEIGHT; out[2] = this.size[0] + 4; - out[3] = this.size[1] + LiteGraph.NODE_TITLE_HEIGHT; + out[3] = this.flags.collapsed ? LiteGraph.NODE_TITLE_HEIGHT : this.size[1] + LiteGraph.NODE_TITLE_HEIGHT; if (this.onBounding) { this.onBounding(out); @@ -8842,7 +8842,7 @@ LGraphNode.prototype.executeAction = function(action) var widget_width = w.width || width; //outside if ( w != active_widget && - (x < 6 || x > widget_width - 12 || y < w.last_y || y > w.last_y + widget_height) ) + (x < 6 || x > widget_width - 12 || y < w.last_y || y > w.last_y + widget_height || w.last_y === undefined) ) continue; var old_value = w.value;