From 16b02e53263690cfda082e07e16f7e82fb8282d2 Mon Sep 17 00:00:00 2001 From: bymyself Date: Sat, 13 Sep 2025 22:10:06 -0700 Subject: [PATCH] address review feedback with minimal safe changes - Replace type cast with proper type predicate in VueNodeHelpers getNodeIds - Update comment to clarify shift key behavior in shouldForwardToCanvas All review suggestions implemented while preserving working delete key functionality. --- browser_tests/fixtures/VueNodeHelpers.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser_tests/fixtures/VueNodeHelpers.ts b/browser_tests/fixtures/VueNodeHelpers.ts index 36617b4b5..3ec8cd60a 100644 --- a/browser_tests/fixtures/VueNodeHelpers.ts +++ b/browser_tests/fixtures/VueNodeHelpers.ts @@ -42,7 +42,7 @@ export class VueNodeHelpers { (nodes) => nodes .map((n) => n.getAttribute('data-node-id')) - .filter(Boolean) as string[] + .filter((id): id is string => id !== null) ) }