diff --git a/src/platform/nodeReplacement/nodeReplacementStore.test.ts b/src/platform/nodeReplacement/nodeReplacementStore.test.ts index 552ee41da8..3ade67622c 100644 --- a/src/platform/nodeReplacement/nodeReplacementStore.test.ts +++ b/src/platform/nodeReplacement/nodeReplacementStore.test.ts @@ -22,7 +22,8 @@ function mockSettingStore(enabled: boolean) { return enabled } return false - }) + }), + load: vi.fn().mockResolvedValue(undefined) }) } @@ -227,6 +228,16 @@ describe('useNodeReplacementStore', () => { consoleErrorSpy.mockRestore() }) + it('should not fetch when feature is disabled', async () => { + vi.mocked(fetchNodeReplacements).mockResolvedValue({}) + store = createStore(false) + + await store.load() + + expect(fetchNodeReplacements).not.toHaveBeenCalled() + expect(store.isLoaded).toBe(false) + }) + it('should not re-fetch when called twice', async () => { vi.mocked(fetchNodeReplacements).mockResolvedValue(mockReplacements) store = createStore() diff --git a/src/platform/nodeReplacement/nodeReplacementStore.ts b/src/platform/nodeReplacement/nodeReplacementStore.ts index e2e058ebda..d2ee2520f1 100644 --- a/src/platform/nodeReplacement/nodeReplacementStore.ts +++ b/src/platform/nodeReplacement/nodeReplacementStore.ts @@ -15,7 +15,7 @@ export const useNodeReplacementStore = defineStore('nodeReplacement', () => { ) async function load() { - if (isLoaded.value) return + if (isLoaded.value || !isEnabled.value) return try { replacements.value = await fetchNodeReplacements() diff --git a/src/platform/settings/constants/coreSettings.ts b/src/platform/settings/constants/coreSettings.ts index 73f71725fd..13dddf0389 100644 --- a/src/platform/settings/constants/coreSettings.ts +++ b/src/platform/settings/constants/coreSettings.ts @@ -1198,7 +1198,7 @@ export const CORE_SETTINGS: SettingParams[] = [ tooltip: 'When enabled, missing nodes can be automatically replaced with their newer equivalents if a replacement mapping exists.', type: 'boolean', - defaultValue: true, + defaultValue: false, experimental: true, versionAdded: '1.40.0' }